Skip to content

πŸ™Œ OpenHands: AI-Driven Development

chore(frontend): remove unused hooks and code (#13810)

Tim O'Farrell754a96e7f33c
diff --git a/frontend/__tests__/hooks/query/use-active-host.test.tsx b/frontend/__tests__/hooks/query/use-active-host.test.tsx
deleted file mode 100644
index ab33094ff2..0000000000
--- a/frontend/__tests__/hooks/query/use-active-host.test.tsx
+++ /dev/null
@@ -1,121 +0,0 @@
-import { renderHook } from "@testing-library/react";
-import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
-import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
-
-vi.mock("@tanstack/react-query", async () => {
- const actual = await vi.importActual("@tanstack/react-query");
- return {
- ...actual,
- useQuery: vi.fn(),
- useQueries: vi.fn(),
- };
-});
-
-// Mock the dependencies
-vi.mock("#/hooks/use-conversation-id", () => ({
- useConversationId: () => ({ conversationId: "test-conversation-id" }),
-}));
-
-vi.mock("#/hooks/use-runtime-is-ready", () => ({
- useRuntimeIsReady: () => true,
-}));
-
-vi.mock("#/api/open-hands", () => ({
- default: {
- getWebHosts: vi
- .fn()
- .mockResolvedValue(["http://localhost:3000", "http://localhost:3001"]),
- },
-}));
-
-vi.mock("axios", () => ({
- default: {
- get: vi.fn().mockResolvedValue({ data: "OK" }),
- create: vi.fn(() => ({
- get: vi.fn(),
- interceptors: {
- response: {
- use: vi.fn(),
- },
- },
- })),
- },
-}));
-
-describe("useActiveHost", () => {
- let queryClient: QueryClient;
-
- beforeEach(async () => {
- queryClient = new QueryClient({
- defaultOptions: {
- queries: {
- retry: false,
- },
- },
- });
-
- // Mock useQuery to return hosts data
- const { useQuery, useQueries } = await import("@tanstack/react-query");
- vi.mocked(useQuery).mockReturnValue({
- data: { hosts: ["http://localhost:3000", "http://localhost:3001"] },
- isLoading: false,
- error: null,
- } as any);
-
- // Mock useQueries to return empty array of results
- vi.mocked(useQueries).mockReturnValue([]);
- });
-
- afterEach(() => {
- vi.clearAllMocks();
- });
-
- const wrapper = ({ children }: { children: React.ReactNode }) => (
- <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
- );
-
- it("should configure refetchInterval for host availability queries", async () => {
- // Import the hook after mocks are set up
- const { useActiveHost } = await import("#/hooks/query/use-active-host");
- const { useQueries } = await import("@tanstack/react-query");
-
- renderHook(() => useActiveHost(), { wrapper });
-
- // Check that useQueries was called
- expect(useQueries).toHaveBeenCalled();
-
- // Get the queries configuration passed to useQueries
- const queriesConfig = vi.mocked(useQueries).mock.calls[0][0];
-
- // Verify that the queries configuration includes refetchInterval
- expect(queriesConfig).toEqual({
- queries: expect.arrayContaining([
- expect.objectContaining({
- refetchInterval: 3000,
- }),
- ]),
- });
- });
-
- it("should fail if refetchInterval is not configured", async () => {
- // Import the hook after mocks are set up
- const { useActiveHost } = await import("#/hooks/query/use-active-host");
- const { useQueries } = await import("@tanstack/react-query");
-
- renderHook(() => useActiveHost(), { wrapper });
-
- // Check that useQueries was called
- expect(useQueries).toHaveBeenCalled();
-
- // Get the queries configuration passed to useQueries
- const queriesConfig = vi.mocked(useQueries).mock.calls[0][0];
-
- // This test will fail if refetchInterval is commented out in the hook
- // because the queries won't have the refetchInterval property
- const hasRefetchInterval = (queriesConfig as any).queries.some(
- (query: any) => query.refetchInterval === 3000,
- );
-
- expect(hasRefetchInterval).toBe(true);
- });
-});
diff --git a/frontend/src/hooks/mutation/use-start-conversation.ts b/frontend/src/hooks/mutation/use-start-conversation.ts
deleted file mode 100644
index 4d3e3a9f80..0000000000
--- a/frontend/src/hooks/mutation/use-start-conversation.ts
+++ /dev/null
@@ -1,43 +0,0 @@
-import { useMutation, useQueryClient } from "@tanstack/react-query";
-import ConversationService from "#/api/conversation-service/conversation-service.api";
-import { Provider } from "#/types/settings";
-
-export const useStartConversation = () => {
- const queryClient = useQueryClient();
-
- return useMutation({
- mutationFn: (variables: {
- conversationId: string;
- providers?: Provider[];
- }) =>
- ConversationService.startConversation(
- variables.conversationId,
- variables.providers,
- ),
- onMutate: async () => {
- await queryClient.cancelQueries({ queryKey: ["user", "conversations"] });
- const previousConversations = queryClient.getQueryData([
- "user",
- "conversations",
- ]);
-
- return { previousConversations };
- },
- onError: (_, __, context) => {
- if (context?.previousConversations) {
- queryClient.setQueryData(
- ["user", "conversations"],
- context.previousConversations,
- );
- }
- },
- onSettled: (_, __, variables) => {
- // Invalidate the specific conversation query to trigger automatic refetch
- queryClient.invalidateQueries({
- queryKey: ["user", "conversation", variables.conversationId],
- });
- // Also invalidate the conversations list for consistency
- queryClient.invalidateQueries({ queryKey: ["user", "conversations"] });
- },
- });
-};
diff --git a/frontend/src/hooks/mutation/use-stop-conversation.ts b/frontend/src/hooks/mutation/use-stop-conversation.ts
deleted file mode 100644
index d23f5e14ae..0000000000
--- a/frontend/src/hooks/mutation/use-stop-conversation.ts
+++ /dev/null
@@ -1,50 +0,0 @@
-import { useMutation, useQueryClient } from "@tanstack/react-query";
-import { useNavigate, useParams } from "react-router";
-import ConversationService from "#/api/conversation-service/conversation-service.api";
-
-export const useStopConversation = () => {
- const queryClient = useQueryClient();
- const navigate = useNavigate();
- const { conversationId: currentConversationId } = useParams<{
- conversationId: string;
- }>();
-
- return useMutation({
- mutationFn: (variables: { conversationId: string }) =>
- ConversationService.stopConversation(variables.conversationId),
- onMutate: async () => {
- await queryClient.cancelQueries({ queryKey: ["user", "conversations"] });
- const previousConversations = queryClient.getQueryData([
- "user",
- "conversations",
- ]);
-
- return { previousConversations };
- },
- onError: (_, __, context) => {
- if (context?.previousConversations) {
- queryClient.setQueryData(
- ["user", "conversations"],
- context.previousConversations,
- );
- }
- },
- onSettled: (_, __, variables) => {
- // Invalidate the specific conversation query to trigger automatic refetch
- queryClient.invalidateQueries({
- queryKey: ["user", "conversation", variables.conversationId],
- });
- // Also invalidate the conversations list for consistency
- queryClient.invalidateQueries({ queryKey: ["user", "conversations"] });
- },
- onSuccess: (_, variables) => {
- // Only redirect if we're stopping the conversation we're currently viewing
- if (
- currentConversationId &&
- variables.conversationId === currentConversationId
- ) {
- navigate("/");
- }
- },
- });
-};
diff --git a/frontend/src/hooks/query/use-active-host.ts b/frontend/src/hooks/query/use-active-host.ts
deleted file mode 100644
index ec20201689..0000000000
--- a/frontend/src/hooks/query/use-active-host.ts
+++ /dev/null
@@ -1,52 +0,0 @@
-import { useQueries, useQuery } from "@tanstack/react-query";
-import axios from "axios";
-import React from "react";
-import ConversationService from "#/api/conversation-service/conversation-service.api";
-import { useConversationId } from "#/hooks/use-conversation-id";
-import { useRuntimeIsReady } from "#/hooks/use-runtime-is-ready";
-
-export const useActiveHost = () => {
- const [activeHost, setActiveHost] = React.useState<string | null>(null);
- const { conversationId } = useConversationId();
- const runtimeIsReady = useRuntimeIsReady();
-
- const { data } = useQuery({
- queryKey: [conversationId, "hosts"],
- queryFn: async () => {
- const hosts = await ConversationService.getWebHosts(conversationId);
- return { hosts };
- },
- enabled: runtimeIsReady && !!conversationId,
- initialData: { hosts: [] },
- meta: {
- disableToast: true,
- },
- });
-
- const apps = useQueries({
- queries: data.hosts.map((host) => ({
- queryKey: [conversationId, "hosts", host],
- queryFn: async () => {
- try {
- await axios.get(host);
- return host;
- } catch (e) {
- return "";
- }
- },
- refetchInterval: 3000,
- meta: {
- disableToast: true,
- },
- })),
- });
-
- const appsData = apps.map((app) => app.data);
-
- React.useEffect(() => {
- const successfulApp = appsData.find((app) => app);
- setActiveHost(successfulApp || "");
- }, [appsData]);
-
- return { activeHost };
-};
diff --git a/frontend/src/hooks/query/use-get-diff.ts b/frontend/src/hooks/query/use-get-diff.ts
deleted file mode 100644
index 813474f74a..0000000000
--- a/frontend/src/hooks/query/use-get-diff.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import GitService from "#/api/git-service/git-service.api";
-import { GitChangeStatus } from "#/api/open-hands.types";
-import { useConversationId } from "#/hooks/use-conversation-id";
-
-type UseGetDiffConfig = {
- filePath: string;
- type: GitChangeStatus;
- enabled: boolean;
-};
-
-export const useGitDiff = (config: UseGetDiffConfig) => {
- const { conversationId } = useConversationId();
-
- return useQuery({
- queryKey: ["file_diff", conversationId, config.filePath, config.type],
- queryFn: () => GitService.getGitChangeDiff(conversationId, config.filePath),
- enabled: config.enabled,
- staleTime: 1000 * 60 * 5, // 5 minutes
- gcTime: 1000 * 60 * 15, // 15 minutes
- });
-};
diff --git a/frontend/src/hooks/query/use-get-git-changes.ts b/frontend/src/hooks/query/use-get-git-changes.ts
deleted file mode 100644
index 92643e703d..0000000000
--- a/frontend/src/hooks/query/use-get-git-changes.ts
+++ /dev/null
@@ -1,67 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import React from "react";
-import GitService from "#/api/git-service/git-service.api";
-import { useConversationId } from "#/hooks/use-conversation-id";
-import { GitChange } from "#/api/open-hands.types";
-import { useRuntimeIsReady } from "#/hooks/use-runtime-is-ready";
-
-export const useGetGitChanges = () => {
- const { conversationId } = useConversationId();
- const [orderedChanges, setOrderedChanges] = React.useState<GitChange[]>([]);
- const previousDataRef = React.useRef<GitChange[]>(null);
- const runtimeIsReady = useRuntimeIsReady();
-
- const result = useQuery({
- queryKey: ["file_changes", conversationId],
- queryFn: () => GitService.getGitChanges(conversationId),
- retry: false,
- staleTime: 1000 * 60 * 5, // 5 minutes
- gcTime: 1000 * 60 * 15, // 15 minutes
- enabled: runtimeIsReady && !!conversationId,
- meta: {
- disableToast: true,
- },
- });
-
- // Latest changes should be on top
- React.useEffect(() => {
- if (!result.isFetching && result.isSuccess && result.data) {
- const currentData = result.data;
-
- // If this is new data (not the same reference as before)
- if (currentData !== previousDataRef.current) {
- previousDataRef.current = currentData;
-
- // Figure out new items by comparing with what we already have
- if (Array.isArray(currentData)) {
- const currentIds = new Set(currentData.map((item) => item.path));
- const existingIds = new Set(orderedChanges.map((item) => item.path));
-
- // Filter out items that already exist in orderedChanges
- const newItems = currentData.filter(
- (item) => !existingIds.has(item.path),
- );
-
- // Filter out items that no longer exist in the API response
- const existingItems = orderedChanges.filter((item) =>
- currentIds.has(item.path),
- );
-
- // Add new items to the beginning
- setOrderedChanges([...newItems, ...existingItems]);
- } else {
- // If not an array, just use the data directly
- setOrderedChanges([currentData]);
- }
- }
- }
- }, [result.isFetching, result.isSuccess, result.data]);
-
- return {
- data: orderedChanges,
- isLoading: result.isLoading,
- isSuccess: result.isSuccess,
- isError: result.isError,
- error: result.error,
- };
-};
diff --git a/frontend/src/hooks/query/use-get-policy.ts b/frontend/src/hooks/query/use-get-policy.ts
deleted file mode 100644
index b8c450c2a3..0000000000
--- a/frontend/src/hooks/query/use-get-policy.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import React from "react";
-import InvariantService from "#/api/invariant-service";
-
-type ResponseData = string;
-
-interface UseGetPolicyConfig {
- onSuccess: (data: ResponseData) => void;
-}
-
-export const useGetPolicy = (config?: UseGetPolicyConfig) => {
- const data = useQuery<ResponseData>({
- queryKey: ["policy"],
- queryFn: InvariantService.getPolicy,
- });
-
- const { isFetching, isSuccess, data: policy } = data;
-
- React.useEffect(() => {
- if (!isFetching && isSuccess && policy) {
- config?.onSuccess(policy);
- }
- }, [isFetching, isSuccess, policy, config?.onSuccess]);
-
- return data;
-};
diff --git a/frontend/src/hooks/query/use-get-risk-severity.ts b/frontend/src/hooks/query/use-get-risk-severity.ts
deleted file mode 100644
index a72e4b30d5..0000000000
--- a/frontend/src/hooks/query/use-get-risk-severity.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import React from "react";
-import InvariantService from "#/api/invariant-service";
-
-type ResponseData = number;
-
-interface UseGetRiskSeverityConfig {
- onSuccess: (data: ResponseData) => void;
-}
-
-export const useGetRiskSeverity = (config?: UseGetRiskSeverityConfig) => {
- const data = useQuery<ResponseData>({
- queryKey: ["risk_severity"],
- queryFn: InvariantService.getRiskSeverity,
- });
-
- const { isFetching, isSuccess, data: riskSeverity } = data;
-
- React.useEffect(() => {
- if (!isFetching && isSuccess && riskSeverity) {
- config?.onSuccess(riskSeverity);
- }
- }, [isFetching, isSuccess, riskSeverity, config?.onSuccess]);
-
- return data;
-};
diff --git a/frontend/src/hooks/query/use-get-traces.ts b/frontend/src/hooks/query/use-get-traces.ts
deleted file mode 100644
index 7eaa1fed79..0000000000
--- a/frontend/src/hooks/query/use-get-traces.ts
+++ /dev/null
@@ -1,27 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import React from "react";
-import InvariantService from "#/api/invariant-service";
-
-type ResponseData = object;
-
-interface UseGetTracesConfig {
- onSuccess: (data: ResponseData) => void;
-}
-
-export const useGetTraces = (config?: UseGetTracesConfig) => {
- const data = useQuery({
- queryKey: ["traces"],
- queryFn: InvariantService.getTraces,
- enabled: false,
- });
-
- const { isFetching, isSuccess, data: traces } = data;
-
- React.useEffect(() => {
- if (!isFetching && isSuccess && traces) {
- config?.onSuccess(traces);
- }
- }, [isFetching, isSuccess, traces, config?.onSuccess]);
-
- return data;
-};
diff --git a/frontend/src/hooks/query/use-installation-repositories.ts b/frontend/src/hooks/query/use-installation-repositories.ts
deleted file mode 100644
index 8531855325..0000000000
--- a/frontend/src/hooks/query/use-installation-repositories.ts
+++ /dev/null
@@ -1,82 +0,0 @@
-import { useInfiniteQuery } from "@tanstack/react-query";
-import { useAppInstallations } from "./use-app-installations";
-import { useConfig } from "./use-config";
-import { useUserProviders } from "../use-user-providers";
-import { Provider } from "#/types/settings";
-import GitService from "#/api/git-service/git-service.api";
-import { shouldUseInstallationRepos } from "#/utils/utils";
-
-export const useInstallationRepositories = (
- selectedProvider: Provider | null,
-) => {
- const { providers } = useUserProviders();
- const { data: config } = useConfig();
- const { data: installations } = useAppInstallations(selectedProvider);
-
- const repos = useInfiniteQuery({
- queryKey: [
- "repositories",
- providers || [],
- selectedProvider,
- installations || [],
- ],
- queryFn: async ({
- pageParam,
- }: {
- pageParam: { installationIndex: number | null; repoPage: number | null };
- }) => {
- const { repoPage, installationIndex } = pageParam;
-
- if (!installations) {
- throw new Error("Missing installation list");
- }
-
- return GitService.retrieveInstallationRepositories(
- selectedProvider!,
- installationIndex || 0,
- installations,
- repoPage || 1,
- 30,
- );
- },
- initialPageParam: { installationIndex: 0, repoPage: 1 },
- getNextPageParam: (lastPage) => {
- if (lastPage.nextPage) {
- return {
- installationIndex: lastPage.installationIndex,
- repoPage: lastPage.nextPage,
- };
- }
-
- if (lastPage.installationIndex !== null) {
- return { installationIndex: lastPage.installationIndex, repoPage: 1 };
- }
-
- return null;
- },
- enabled:
- (providers || []).length > 0 &&
- !!selectedProvider &&
- shouldUseInstallationRepos(selectedProvider, config?.app_mode) &&
- Array.isArray(installations) &&
- installations.length > 0,
- staleTime: 1000 * 60 * 5, // 5 minutes
- gcTime: 1000 * 60 * 15, // 15 minutes
- });
-
- const onLoadMore = () => {
- if (repos.hasNextPage && !repos.isFetchingNextPage) {
- repos.fetchNextPage();
- }
- };
-
- // Return the query result with the scroll ref
- return {
- data: repos.data,
- isLoading: repos.isLoading,
- isError: repos.isError,
- hasNextPage: repos.hasNextPage,
- isFetchingNextPage: repos.isFetchingNextPage,
- onLoadMore,
- };
-};
diff --git a/frontend/src/hooks/query/use-search-conversations.ts b/frontend/src/hooks/query/use-search-conversations.ts
deleted file mode 100644
index 73f84f0990..0000000000
--- a/frontend/src/hooks/query/use-search-conversations.ts
+++ /dev/null
@@ -1,27 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import ConversationService from "#/api/conversation-service/conversation-service.api";
-
-export const useSearchConversations = (
- selectedRepository?: string,
- conversationTrigger?: string,
- limit: number = 100,
- cacheDisabled: boolean = false,
-) =>
- useQuery({
- queryKey: [
- "conversations",
- "search",
- selectedRepository,
- conversationTrigger,
- limit,
- ],
- queryFn: () =>
- ConversationService.searchConversations(
- selectedRepository,
- conversationTrigger,
- limit,
- ),
- enabled: true, // Always enabled since parameters are optional
- staleTime: cacheDisabled ? 0 : 1000 * 60 * 5, // 5 minutes
- gcTime: cacheDisabled ? 0 : 1000 * 60 * 15, // 15 minutes
- });
diff --git a/frontend/src/hooks/query/use-user-repositories.ts b/frontend/src/hooks/query/use-user-repositories.ts
deleted file mode 100644
index 0b7313e285..0000000000
--- a/frontend/src/hooks/query/use-user-repositories.ts
+++ /dev/null
@@ -1,41 +0,0 @@
-import { useInfiniteQuery } from "@tanstack/react-query";
-import { useConfig } from "./use-config";
-import { useUserProviders } from "../use-user-providers";
-import { Provider } from "#/types/settings";
-import GitService from "#/api/git-service/git-service.api";
-import { shouldUseInstallationRepos } from "#/utils/utils";
-
-export const useUserRepositories = (selectedProvider: Provider | null) => {
- const { providers } = useUserProviders();
- const { data: config } = useConfig();
-
- const repos = useInfiniteQuery({
- queryKey: ["repositories", providers || [], selectedProvider],
- queryFn: async ({ pageParam }) =>
- GitService.retrieveUserGitRepositories(selectedProvider!, pageParam, 30),
- initialPageParam: 1,
- getNextPageParam: (lastPage) => lastPage.nextPage,
- enabled:
- (providers || []).length > 0 &&
- !!selectedProvider &&
- !shouldUseInstallationRepos(selectedProvider, config?.app_mode),
- staleTime: 1000 * 60 * 5, // 5 minutes
- gcTime: 1000 * 60 * 15, // 15 minutes
- });
-
- const onLoadMore = () => {
- if (repos.hasNextPage && !repos.isFetchingNextPage) {
- repos.fetchNextPage();
- }
- };
-
- // Return the query result with the scroll ref
- return {
- data: repos.data,
- isLoading: repos.isLoading,
- isError: repos.isError,
- hasNextPage: repos.hasNextPage,
- isFetchingNextPage: repos.isFetchingNextPage,
- onLoadMore,
- };
-};
diff --git a/frontend/src/hooks/query/use-vscode-url.ts b/frontend/src/hooks/query/use-vscode-url.ts
deleted file mode 100644
index ac3e19e553..0000000000
--- a/frontend/src/hooks/query/use-vscode-url.ts
+++ /dev/null
@@ -1,60 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-import { useTranslation } from "react-i18next";
-import ConversationService from "#/api/conversation-service/conversation-service.api";
-import V1ConversationService from "#/api/conversation-service/v1-conversation-service.api";
-import { useConversationId } from "#/hooks/use-conversation-id";
-import { useActiveConversation } from "#/hooks/query/use-active-conversation";
-import { I18nKey } from "#/i18n/declaration";
-import { transformVSCodeUrl } from "#/utils/vscode-url-helper";
-import { useRuntimeIsReady } from "#/hooks/use-runtime-is-ready";
-
-// Define the return type for the VS Code URL query
-interface VSCodeUrlResult {
- url: string | null;
- error: string | null;
-}
-
-export const useVSCodeUrl = () => {
- const { t } = useTranslation();
- const { conversationId } = useConversationId();
- const { data: conversation } = useActiveConversation();
- const runtimeIsReady = useRuntimeIsReady();
-
- const isV1Conversation = conversation?.conversation_version === "V1";
-
- return useQuery<VSCodeUrlResult>({
- queryKey: [
- "vscode_url",
- conversationId,
- isV1Conversation,
- conversation?.url,
- conversation?.session_api_key,
- ],
- queryFn: async () => {
- if (!conversationId) throw new Error("No conversation ID");
-
- // Use appropriate API based on conversation version
- const data = isV1Conversation
- ? await V1ConversationService.getVSCodeUrl(
- conversationId,
- conversation?.url,
- conversation?.session_api_key,
- )
- : await ConversationService.getVSCodeUrl(conversationId);
-
- if (data.vscode_url) {
- return {
- url: transformVSCodeUrl(data.vscode_url),
- error: null,
- };
- }
- return {
- url: null,
- error: t(I18nKey.VSCODE$URL_NOT_AVAILABLE),
- };
- },
- enabled: runtimeIsReady && !!conversationId,
- refetchOnMount: true,
- retry: 3,
- });
-};