Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(frontend): keep plugins search usable on narrow screens (#17592)

lsmlhi_257aa7c459e7e2
diff --git a/__tests__/components/features/plugins/plugins-toolbar.test.tsx b/__tests__/components/features/plugins/plugins-toolbar.test.tsx
new file mode 100644
index 0000000000..84547ae1d2
--- /dev/null
+++ b/__tests__/components/features/plugins/plugins-toolbar.test.tsx
@@ -0,0 +1,54 @@
+import { screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { describe, expect, it, vi } from "vitest";
+import { PluginsToolbar } from "#/components/features/plugins/plugins-toolbar";
+import { renderWithProviders } from "test-utils";
+
+function renderToolbar() {
+ const onSearchChange = vi.fn();
+ const onStatusFilterChange = vi.fn();
+ renderWithProviders(
+ <PluginsToolbar
+ search=""
+ onSearchChange={onSearchChange}
+ statusFilter="all"
+ onStatusFilterChange={onStatusFilterChange}
+ />,
+ );
+ return { onSearchChange, onStatusFilterChange };
+}
+
+describe("PluginsToolbar", () => {
+ it("stacks search above status filters below the md breakpoint", () => {
+ renderToolbar();
+
+ const toolbar = screen.getByTestId("plugins-toolbar");
+ expect(toolbar.className).toContain("flex-col");
+ expect(toolbar.className).toContain("md:flex-row");
+
+ const search = screen.getByTestId("plugins-search-input");
+ expect(search.parentElement?.className).toContain("w-full");
+
+ const filters = screen.getByTestId("plugins-status-filter");
+ const filterClasses = filters.className.split(/\s+/);
+ expect(filterClasses).toContain("flex-wrap");
+ expect(filterClasses).toContain("md:flex-nowrap");
+ expect(filterClasses).not.toContain("shrink-0");
+ expect(filterClasses).toContain("md:shrink-0");
+ });
+
+ it("keeps every status filter reachable and still filters with search", async () => {
+ const user = userEvent.setup();
+ const { onSearchChange, onStatusFilterChange } = renderToolbar();
+
+ for (const value of ["all", "installed", "available", "local"]) {
+ expect(screen.getByTestId(`plugins-filter-${value}`)).toBeInTheDocument();
+ }
+
+ await user.click(screen.getByTestId("plugins-filter-installed"));
+ expect(onStatusFilterChange).toHaveBeenCalledWith("installed");
+
+ await user.type(screen.getByTestId("plugins-search-input"), "git");
+ expect(onSearchChange).toHaveBeenCalled();
+ });
+});
diff --git a/src/components/features/plugins/plugins-toolbar.tsx b/src/components/features/plugins/plugins-toolbar.tsx
index 4887040083..2b429d017f 100644
--- a/src/components/features/plugins/plugins-toolbar.tsx
+++ b/src/components/features/plugins/plugins-toolbar.tsx
@@ -30,10 +30,13 @@ export function PluginsToolbar({
const { t } = useTranslation("openhands");
return (
- <div data-testid="plugins-toolbar" className="flex items-stretch gap-2">
+ <div
+ data-testid="plugins-toolbar"
+ className="flex flex-col items-stretch gap-2 md:flex-row"
+ >
<div
className={cn(
- "relative flex flex-1 min-w-0 items-center",
+ "relative flex w-full min-w-0 flex-1 items-center",
"rounded-lg border border-border bg-base-secondary",
"focus-within:border-contrast/40 focus-within:ring-1 focus-within:ring-contrast/20",
"transition-colors",
@@ -70,7 +73,7 @@ export function PluginsToolbar({
<div
data-testid="plugins-status-filter"
- className="flex shrink-0 items-center gap-1 rounded-lg border border-border bg-base-secondary p-1"
+ className="flex w-full flex-wrap items-center gap-1 rounded-lg border border-border bg-base-secondary p-1 md:w-auto md:shrink-0 md:flex-nowrap"
>
{STATUS_FILTERS.map((filter) => (
<button