π OpenHands: AI-Driven Development
feat: switch default base image to nikolaik slim variant (#13244)
Saurya Velagapudi7fbb499f037e
diff --git a/.github/workflows/ghcr-build.yml b/.github/workflows/ghcr-build.ymlindex bd0718e651..8b15aba6d1 100644--- a/.github/workflows/ghcr-build.yml+++ b/.github/workflows/ghcr-build.yml@@ -40,11 +40,11 @@ jobs:run: |if [[ "$GITHUB_EVENT_NAME" == "pull_request" ]]; thenjson=$(jq -n -c '[- { image: "nikolaik/python-nodejs:python3.12-nodejs22", tag: "nikolaik" }+ { image: "nikolaik/python-nodejs:python3.12-nodejs22-slim", tag: "nikolaik" }]')elsejson=$(jq -n -c '[- { image: "nikolaik/python-nodejs:python3.12-nodejs22", tag: "nikolaik" },+ { image: "nikolaik/python-nodejs:python3.12-nodejs22-slim", tag: "nikolaik" },{ image: "ubuntu:24.04", tag: "ubuntu" }]')fidiff --git a/config.template.toml b/config.template.tomlindex c05d5798e2..9756ca44bf 100644--- a/config.template.toml+++ b/config.template.toml@@ -296,7 +296,7 @@ classpath = "my_package.my_module.MyCustomAgent"#user_id = 1000# Container image to use for the sandbox-#base_container_image = "nikolaik/python-nodejs:python3.12-nodejs22"+#base_container_image = "nikolaik/python-nodejs:python3.12-nodejs22-slim"# Use host network#use_host_network = falsediff --git a/openhands/core/config/sandbox_config.py b/openhands/core/config/sandbox_config.pyindex 6e782fc48f..ea6be162a5 100644--- a/openhands/core/config/sandbox_config.py+++ b/openhands/core/config/sandbox_config.py@@ -60,7 +60,7 @@ class SandboxConfig(BaseModel):rm_all_containers: bool = Field(default=False)api_key: str | None = Field(default=None)base_container_image: str | None = Field(- default='nikolaik/python-nodejs:python3.12-nodejs22'+ default='nikolaik/python-nodejs:python3.12-nodejs22-slim')runtime_container_image: str | None = Field(default=None)user_id: int = Field(default=os.getuid() if hasattr(os, 'getuid') else 1000)@@ -126,5 +126,7 @@ class SandboxConfig(BaseModel):@model_validator(mode='after')def set_default_base_image(self) -> 'SandboxConfig':if self.base_container_image is None:- self.base_container_image = 'nikolaik/python-nodejs:python3.12-nodejs22'+ self.base_container_image = (+ 'nikolaik/python-nodejs:python3.12-nodejs22-slim'+ )return selfdiff --git a/openhands/runtime/utils/runtime_build.py b/openhands/runtime/utils/runtime_build.pyindex 60be727112..e2f48384b7 100644--- a/openhands/runtime/utils/runtime_build.py+++ b/openhands/runtime/utils/runtime_build.py@@ -403,7 +403,9 @@ def _build_sandbox_image(if __name__ == '__main__':parser = argparse.ArgumentParser()parser.add_argument(- '--base_image', type=str, default='nikolaik/python-nodejs:python3.12-nodejs22'+ '--base_image',+ type=str,+ default='nikolaik/python-nodejs:python3.12-nodejs22-slim',)parser.add_argument('--build_folder', type=str, default=None)parser.add_argument('--force_rebuild', action='store_true', default=False)diff --git a/tests/runtime/conftest.py b/tests/runtime/conftest.pyindex d6e910c5e2..016bfda3a7 100644--- a/tests/runtime/conftest.py+++ b/tests/runtime/conftest.py@@ -195,7 +195,7 @@ def base_container_image(request):request.param = Noneif request.param is None:request.param = pytest.param(- 'nikolaik/python-nodejs:python3.12-nodejs22',+ 'nikolaik/python-nodejs:python3.12-nodejs22-slim','golang:1.23-bookworm',)print(f'Container image: {request.param}')diff --git a/tests/unit/core/config/test_config.py b/tests/unit/core/config/test_config.pyindex 78abd5b804..3446163045 100644--- a/tests/unit/core/config/test_config.py+++ b/tests/unit/core/config/test_config.py@@ -432,7 +432,7 @@ def test_defaults_dict_after_updates(default_config):assert defaults_after_updates['sandbox']['timeout']['default'] == 120assert (defaults_after_updates['sandbox']['base_container_image']['default']- == 'nikolaik/python-nodejs:python3.12-nodejs22'+ == 'nikolaik/python-nodejs:python3.12-nodejs22-slim')assert defaults_after_updates == initial_defaultsdiff --git a/tests/unit/runtime/builder/test_runtime_build.py b/tests/unit/runtime/builder/test_runtime_build.pyindex 922c4141f8..48a7c4dac2 100644--- a/tests/unit/runtime/builder/test_runtime_build.py+++ b/tests/unit/runtime/builder/test_runtime_build.py@@ -28,7 +28,7 @@ from openhands.runtime.utils.runtime_build import ()OH_VERSION = f'oh_v{oh_version}'-DEFAULT_BASE_IMAGE = 'nikolaik/python-nodejs:python3.12-nodejs22'+DEFAULT_BASE_IMAGE = 'nikolaik/python-nodejs:python3.12-nodejs22-slim'@pytest.fixture@@ -266,7 +266,7 @@ def test_get_runtime_image_repo_and_tag_eventstream():assert (img_repo == f'{get_runtime_image_repo()}'and img_tag- == f'{OH_VERSION}_image_nikolaik_s_python-nodejs_tag_python3.12-nodejs22'+ == f'{OH_VERSION}_image_nikolaik_s_python-nodejs_tag_python3.12-nodejs22-slim')base_image = 'ubuntu'@@ -299,7 +299,7 @@ def test_generate_dockerfile_channel_alias_not_in_non_scratch(monkeypatch):assert (img_repo == f'{get_runtime_image_repo()}'and img_tag- == f'{OH_VERSION}_image_nikolaik_s_python-nodejs_tag_python3.12-nodejs22'+ == f'{OH_VERSION}_image_nikolaik_s_python-nodejs_tag_python3.12-nodejs22-slim')base_image = 'ubuntu'