Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(verify-openhands): bug run puts back the viewport a block changed (#18850)

Engel Nyst82bf0fc278f3
diff --git a/.agents/skills/verify-openhands/scripts/control-openhands.mjs b/.agents/skills/verify-openhands/scripts/control-openhands.mjs
index 601d7da4f9..5a154b4598 100755
--- a/.agents/skills/verify-openhands/scripts/control-openhands.mjs
+++ b/.agents/skills/verify-openhands/scripts/control-openhands.mjs
@@ -41,6 +41,7 @@ import {
knownBugBlocks,
parseBugPredicate,
proofVerdict,
+ viewportToRestore,
} from "./lib/known-bug.mjs";
import { routePattern } from "./lib/route-pattern.mjs";
import {
@@ -3620,6 +3621,10 @@ async function cmdBug({ positional, flags }) {
const logFile = join(work, `${stamp}.asserts.jsonl`);
const failureFile = join(work, `${stamp}.failed`);
const doctorBefore = doctor();
+ // Every attempt starts at the viewport the caller had, and leaves it so.
+ const viewportBefore = daemonInfo(run)
+ ? (await browserCall(run, "url").catch(() => ({}))).viewport
+ : undefined;
let exec = {
exitCode: null,
timedOut: false,
@@ -3660,6 +3665,15 @@ async function cmdBug({ positional, flags }) {
const page = daemonInfo(run)
? await browserCall(run, "url").catch(() => ({}))
: {};
+ const restore = viewportToRestore(viewportBefore, page.viewport);
+ let viewportRestored;
+ if (restore) {
+ viewportRestored = await browserCall(run, "viewport", {
+ size: restore,
+ })
+ .then(() => restore)
+ .catch((error) => `failed: ${error.message}`);
+ }
const transcript = join(dir, `${stamp}.json`);
writeFileSync(
transcript,
@@ -3709,6 +3723,7 @@ async function cmdBug({ positional, flags }) {
viewport: page.viewport
? `${page.viewport.width}x${page.viewport.height}`
: undefined,
+ ...(viewportRestored ? { viewportRestored } : {}),
transcript: relative(run.dir, transcript),
};
appendFileSync(attemptsFile(run.dir), `${JSON.stringify(attempt)}\n`);
@@ -4855,6 +4870,9 @@ attempt after a passing doctor, and classifies it:
Each attempt is appended to evidence/known-bugs/attempts.jsonl (revision,
backend, viewport, recipe hash, failing line, assertion, transcript) and to the
ledger as an xfail/xpass/fail row. Exit 0 only when every attempt is xfail.
+Every attempt starts at the viewport the browser had before 'run': a block that
+switches it (browser viewport phone) is put back afterwards, and the attempt
+records the size it ran at (viewport) and what it restored (viewportRestored).
Each assertion is logged with the recipe line that ran it, and the first
failure is the one kept, so a cleanup step (an EXIT trap) cannot replace the
marked command's observation.
diff --git a/.agents/skills/verify-openhands/scripts/control-openhands.test.mjs b/.agents/skills/verify-openhands/scripts/control-openhands.test.mjs
index 6bc1d39ea5..1919d2214b 100755
--- a/.agents/skills/verify-openhands/scripts/control-openhands.test.mjs
+++ b/.agents/skills/verify-openhands/scripts/control-openhands.test.mjs
@@ -73,6 +73,7 @@ import {
knownBugBlocks,
parseBugPredicate,
proofVerdict,
+ viewportToRestore,
} from "./lib/known-bug.mjs";
const here = dirname(fileURLToPath(import.meta.url));
@@ -2875,3 +2876,18 @@ test("browser media validates motion before dispatch and preserves playback obse
rmSync(runDir, { recursive: true, force: true });
}
});
+
+test("bug run puts back the viewport a block changed", () => {
+ const desktop = { width: 1440, height: 1000 };
+ const phone = { width: 390, height: 844 };
+ // F07.overview-toggle phone-overview switches to phone: back to desktop.
+ assert.equal(viewportToRestore(desktop, phone), "1440x1000");
+ assert.equal(viewportToRestore(phone, desktop), "390x844");
+ // Unchanged, or nothing known before the block: nothing to restore.
+ assert.equal(viewportToRestore(desktop, { ...desktop }), null);
+ assert.equal(viewportToRestore(undefined, phone), null);
+ const help = spawnSync(process.execPath, [cli, "help", "bug"], {
+ encoding: "utf8",
+ });
+ assert.match(help.stdout, /viewportRestored/);
+});
diff --git a/.agents/skills/verify-openhands/scripts/lib/known-bug.mjs b/.agents/skills/verify-openhands/scripts/lib/known-bug.mjs
index 57c9f20f59..00e847a809 100644
--- a/.agents/skills/verify-openhands/scripts/lib/known-bug.mjs
+++ b/.agents/skills/verify-openhands/scripts/lib/known-bug.mjs
@@ -352,3 +352,16 @@ export function proofVerdict({ baseline, fix, sha, min = 2 }) {
ignored,
};
}
+
+/**
+ * The viewport to put back after an attempt, as `browser viewport` takes it
+ * (`WxH`), or null when the block left it as it found it. A block may switch
+ * to phone (F07.overview-toggle phone-overview); without the restore the next
+ * attempt, and the caller's next check, would silently run at phone width.
+ */
+export function viewportToRestore(before, after) {
+ if (!before?.width || !before?.height) return null;
+ if (after?.width === before.width && after?.height === before.height)
+ return null;
+ return `${before.width}x${before.height}`;
+}