Skip to content

πŸ™Œ OpenHands: AI-Driven Development

test(snapshot): skills page loaded/search/filter states (#447)

Rohit Malhotra863f479f0770
diff --git a/src/query-client-config.ts b/src/query-client-config.ts
index 70453c1a3d..0f75e9269d 100644
--- a/src/query-client-config.ts
+++ b/src/query-client-config.ts
@@ -64,6 +64,11 @@ let activeQueryClient: QueryClient | null = null;
export const getDefaultQueryClient = () => {
if (!defaultQueryClient) {
defaultQueryClient = createAgentServerQueryClient();
+ if (import.meta.env.DEV || import.meta.env.VITE_MOCK_API === "true") {
+ (
+ window as unknown as { __OH_QUERY_CLIENT__?: typeof defaultQueryClient }
+ ).__OH_QUERY_CLIENT__ = defaultQueryClient;
+ }
}
return defaultQueryClient;
diff --git a/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-loaded.png b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-loaded.png
new file mode 100644
index 0000000000..640d0a6615
Binary files /dev/null and b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-loaded.png differ
diff --git a/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-no-match.png b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-no-match.png
new file mode 100644
index 0000000000..0aae247d65
Binary files /dev/null and b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-no-match.png differ
diff --git a/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-search-filtered.png b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-search-filtered.png
new file mode 100644
index 0000000000..a2e76519db
Binary files /dev/null and b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-search-filtered.png differ
diff --git a/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-type-filter.png b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-type-filter.png
new file mode 100644
index 0000000000..910fed1a4c
Binary files /dev/null and b/tests/e2e/__snapshots__/snapshots/skills-page.snapshot.spec.ts/chromium/skills-type-filter.png differ
diff --git a/tests/e2e/snapshots/skills-page.snapshot.spec.ts b/tests/e2e/snapshots/skills-page.snapshot.spec.ts
index 513f27f916..f38524c897 100644
--- a/tests/e2e/snapshots/skills-page.snapshot.spec.ts
+++ b/tests/e2e/snapshots/skills-page.snapshot.spec.ts
@@ -5,15 +5,65 @@ import { test, expect, Page } from "@playwright/test";
*
* SkillsService.getSkills() issues POST /api/skills. In mock-API mode
* MSW returns { skills: [] }, so the empty state is free. For the loaded
- * and search states we intercept the POST with page.route() and return a
- * small set of realistic skills.
+ * and search/filter states we seed the React Query cache directly via
+ * window.__OH_QUERY_CLIENT__ (exposed in dev/mock mode) to bypass MSW's
+ * same-origin intercept.
*
- * Three states are covered:
- * 1. Empty – server returns no skills (MSW default)
- * 2. Loaded – four skill cards including one disabled via disabled_skills
- * 3. Search match / no-match – filtered results after typing in the search box
+ * Four states are covered:
+ * 1. Empty – server returns no skills (MSW default)
+ * 2. Loaded – four skill cards visible
+ * 3. Search – filtered to one card after typing "docker"
+ * 4. No match – empty message after typing an unrecognised term
+ * 5. Type filter – only agentskills cards visible after clicking filter
*/
+const MOCK_SKILLS = [
+ {
+ name: "code-review",
+ type: "agentskills" as const,
+ source: "github:OpenHands/extensions/skills/codereview",
+ description:
+ "Rigorous code review focusing on data structures, simplicity, " +
+ "security, pragmatism, and risk/safety evaluation.",
+ triggers: ["/review"],
+ version: "1.2.0",
+ license: "MIT",
+ allowed_tools: ["terminal", "file_editor"],
+ },
+ {
+ name: "docker",
+ type: "agentskills" as const,
+ source: "github:OpenHands/extensions/skills/docker",
+ description:
+ "Run Docker commands within a container environment, including " +
+ "starting the Docker daemon and managing containers.",
+ triggers: ["/docker"],
+ version: "0.9.1",
+ license: "Apache-2.0",
+ allowed_tools: ["terminal"],
+ },
+ {
+ name: "prd",
+ type: "knowledge" as const,
+ source: "github:OpenHands/extensions/skills/prd",
+ description: "Generate a Product Requirements Document for a new feature.",
+ triggers: ["/prd"],
+ version: "1.0.0",
+ license: null,
+ allowed_tools: null,
+ },
+ {
+ name: "repo-rules",
+ type: "repo" as const,
+ source: null,
+ description: "Project-specific rules for this repository.",
+ triggers: [],
+ version: undefined,
+ license: null,
+ allowed_tools: ["file_editor", "terminal"],
+ },
+];
+
/**
* Dismiss the analytics consent modal if MSW shows it.
*/
@@ -26,26 +76,33 @@ async function dismissConsentModal(page: Page) {
/**
* Wire up the base routes every skills test needs.
- *
- * NOTE: POST /api/skills goes to the same-origin Vite dev server where MSW
- * intercepts it before page.route() can. MSW always returns { skills: [] }
- * in mock mode, so tests that require skill card data need a different
- * injection mechanism (e.g. exposing a __OH_QUERY_CLIENT__ on window so
- * tests can seed the React Query cache directly). Those tests are tracked in
- * COVERAGE_PLAN.md and deferred until that mechanism is available.
*/
async function setupMocks(page: Page) {
await page.addInitScript(() => {
window.localStorage.setItem("openhands-onboarded", "true");
});
+}
- await page.route("**/api/conversations/search**", async (route) => {
- await route.fulfill({
- status: 200,
- contentType: "application/json",
- body: JSON.stringify({ results: [] }),
- });
- });
+/**
+ * Inject skills data directly into the React Query cache via the
+ * window.__OH_QUERY_CLIENT__ handle exposed in dev/mock mode.
+ */
+async function seedSkills(page: Page, skills = MOCK_SKILLS) {
+ await page.waitForFunction(
+ () =>
+ !!(window as unknown as { __OH_QUERY_CLIENT__?: unknown }).__OH_QUERY_CLIENT__,
+ { timeout: 10_000 },
+ );
+ await page.evaluate((skillsData) => {
+ (
+ window as unknown as {
+ __OH_QUERY_CLIENT__: {
+ setQueryData: (key: unknown[], data: unknown) => void;
+ };
+ }
+ ).__OH_QUERY_CLIENT__.setQueryData(["skills"], skillsData);
+ }, skills);
+ await page.waitForTimeout(200);
}
test.describe("Skills Page Visual Snapshots", () => {
@@ -69,8 +126,105 @@ test.describe("Skills Page Visual Snapshots", () => {
});
});
- // TODO: add skills-loaded, skills-search-filtered, skills-no-match once
- // window.__OH_QUERY_CLIENT__ (or equivalent) is exposed so tests can seed
- // the React Query skills cache without fighting MSW's same-origin intercept.
- // See tests/e2e/snapshots/COVERAGE_PLAN.md Β§5 for the full snapshot list.
+ test("skills page with loaded cards renders correctly", async ({ page }) => {
+ await setupMocks(page);
+
+ await page.goto("/skills");
+ await dismissConsentModal(page);
+ await page.waitForLoadState("networkidle");
+
+ const skillsScreen = page.getByTestId("skills-settings-screen");
+ await expect(skillsScreen).toBeVisible({ timeout: 15_000 });
+
+ await seedSkills(page);
+ await expect(page.getByTestId("skill-card-code-review")).toBeVisible({
+ timeout: 5_000,
+ });
+
+ await expect(skillsScreen).toHaveScreenshot("skills-loaded.png", {
+ animations: "disabled",
+ maxDiffPixelRatio: 0.01,
+ });
+ });
+
+ test("search narrows cards to matching skill", async ({ page }) => {
+ await setupMocks(page);
+
+ await page.goto("/skills");
+ await dismissConsentModal(page);
+ await page.waitForLoadState("networkidle");
+
+ const skillsScreen = page.getByTestId("skills-settings-screen");
+ await expect(skillsScreen).toBeVisible({ timeout: 15_000 });
+
+ await seedSkills(page);
+ await expect(page.getByTestId("skill-card-code-review")).toBeVisible({
+ timeout: 5_000,
+ });
+
+ await page.getByTestId("skills-search-input").fill("docker");
+ await page.waitForTimeout(300);
+
+ await expect(page.getByTestId("skill-card-docker")).toBeVisible();
+ await expect(page.getByTestId("skill-card-code-review")).toHaveCount(0);
+
+ await expect(skillsScreen).toHaveScreenshot("skills-search-filtered.png", {
+ animations: "disabled",
+ maxDiffPixelRatio: 0.01,
+ });
+ });
+
+ test("search with no results shows empty message", async ({ page }) => {
+ await setupMocks(page);
+
+ await page.goto("/skills");
+ await dismissConsentModal(page);
+ await page.waitForLoadState("networkidle");
+
+ const skillsScreen = page.getByTestId("skills-settings-screen");
+ await expect(skillsScreen).toBeVisible({ timeout: 15_000 });
+
+ await seedSkills(page);
+ await expect(page.getByTestId("skill-card-code-review")).toBeVisible({
+ timeout: 5_000,
+ });
+
+ await page.getByTestId("skills-search-input").fill("xyznonexistent");
+ await page.waitForTimeout(300);
+
+ await expect(page.getByText(/No skills match/i)).toBeVisible();
+
+ await expect(skillsScreen).toHaveScreenshot("skills-no-match.png", {
+ animations: "disabled",
+ maxDiffPixelRatio: 0.01,
+ });
+ });
+
+ test("type filter shows only matching skill type", async ({ page }) => {
+ await setupMocks(page);
+
+ await page.goto("/skills");
+ await dismissConsentModal(page);
+ await page.waitForLoadState("networkidle");
+
+ const skillsScreen = page.getByTestId("skills-settings-screen");
+ await expect(skillsScreen).toBeVisible({ timeout: 15_000 });
+
+ await seedSkills(page);
+ await expect(page.getByTestId("skill-card-code-review")).toBeVisible({
+ timeout: 5_000,
+ });
+
+ await page.getByTestId("skills-type-filter-agentskills").click();
+ await page.waitForTimeout(300);
+
+ await expect(page.getByTestId("skill-card-code-review")).toBeVisible();
+ await expect(page.getByTestId("skill-card-docker")).toBeVisible();
+ await expect(page.getByTestId("skill-card-prd")).toHaveCount(0);
+
+ await expect(skillsScreen).toHaveScreenshot("skills-type-filter.png", {
+ animations: "disabled",
+ maxDiffPixelRatio: 0.01,
+ });
+ });
});