π OpenHands: AI-Driven Development
fix: open ellipsis menu by ignoring trigger in click-outside (#696)
Hiep Le86406669990e
diff --git a/__tests__/components/features/conversation/conversation-tabs.test.tsx b/__tests__/components/features/conversation/conversation-tabs.test.tsxindex 0465ca3552..e59ec330dd 100644--- a/__tests__/components/features/conversation/conversation-tabs.test.tsx+++ b/__tests__/components/features/conversation/conversation-tabs.test.tsx@@ -477,6 +477,30 @@ describe("ConversationTabs localStorage behavior", () => {});});+ describe("ellipsis context menu", () => {+ beforeEach(() => {+ mockConversationId = REAL_CONVERSATION_ID;+ });++ it("opens the context menu when the ellipsis button is clicked", async () => {+ const user = userEvent.setup();++ render(<ConversationTabs />, {+ wrapper: createWrapper(REAL_CONVERSATION_ID),+ });++ expect(+ screen.queryByTestId("conversation-tabs-menu-open-files"),+ ).not.toBeInTheDocument();++ await user.click(screen.getByTestId("ellipsis-button"));++ expect(+ screen.getByTestId("conversation-tabs-menu-open-files"),+ ).toBeInTheDocument();+ });+ });+describe("tasklist tab", () => {beforeEach(() => {mockConversationId = REAL_CONVERSATION_ID;diff --git a/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsx b/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsxindex 80c18eab63..9209eba468 100644--- a/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsx+++ b/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsx@@ -1,3 +1,4 @@+import React from "react";import { useTranslation } from "react-i18next";import { ContextMenu } from "#/ui/context-menu";import { useClickOutsideElement } from "#/hooks/use-click-outside-element";@@ -24,13 +25,18 @@ import { cn } from "#/utils/utils";interface ConversationTabsContextMenuProps {isOpen: boolean;onClose: () => void;+ ignoreOutsideClickRef?: React.RefObject<HTMLElement | null>;}export function ConversationTabsContextMenu({isOpen,onClose,+ ignoreOutsideClickRef,}: ConversationTabsContextMenuProps) {- const ref = useClickOutsideElement<HTMLUListElement>(onClose);+ const ref = useClickOutsideElement<HTMLUListElement>(+ onClose,+ ignoreOutsideClickRef,+ );const { t } = useTranslation("openhands");const { conversationId } = useConversationId();const {diff --git a/src/components/features/conversation/conversation-tabs/conversation-tabs.tsx b/src/components/features/conversation/conversation-tabs/conversation-tabs.tsxindex bafc37b11c..5a0f72e7d8 100644--- a/src/components/features/conversation/conversation-tabs/conversation-tabs.tsx+++ b/src/components/features/conversation/conversation-tabs/conversation-tabs.tsx@@ -161,6 +161,7 @@ export function ConversationTabs({const tabsRowInnerRef = useRef<HTMLDivElement>(null);const measureRowRef = useRef<HTMLDivElement>(null);const menuRef = useRef<HTMLDivElement>(null);+ const anchorRef = useRef<HTMLButtonElement>(null);const [inlineTabCount, setInlineTabCount] = useState(visibleTabs.length);useLayoutEffect(() => {@@ -317,6 +318,7 @@ export function ConversationTabs({</div><div ref={menuRef} className="relative shrink-0"><EllipsisButton+ ref={anchorRef}onClick={() => setIsMenuOpen(!isMenuOpen)}ariaLabel={t(I18nKey.COMMON$MORE_OPTIONS)}iconClassName={@@ -326,6 +328,7 @@ export function ConversationTabs({<ConversationTabsContextMenuisOpen={isMenuOpen}onClose={() => setIsMenuOpen(false)}+ ignoreOutsideClickRef={anchorRef}/></div></div>