π OpenHands: AI-Driven Development
feat(chat): wide markdown table scroll + home LLM banner polish (#1472)
FraterCCCLXIII864ad912aaa1
diff --git a/__tests__/api/mock-conversation-handlers.test.ts b/__tests__/api/mock-conversation-handlers.test.tsindex 484ce4690d..61ddf86ff4 100644--- a/__tests__/api/mock-conversation-handlers.test.ts+++ b/__tests__/api/mock-conversation-handlers.test.ts@@ -1,6 +1,8 @@import { describe, expect, it } from "vitest";import AgentServerConversationService from "#/api/conversation-service/agent-server-conversation-service.api";import AgentServerGitService from "#/api/git-service/agent-server-git-service.api";+import EventService from "#/api/event-service/event-service.api";+import { TABLE_DEMO_CONVERSATION_ID } from "#/fixtures/table-demo-conversation";describe("mock conversation handlers", () => {it("returns adapted conversations for batch lookups", async () => {@@ -41,4 +43,27 @@ describe("mock conversation handlers", () => {"src/old-module.py",]);});++ it("returns the table demo conversation via MSW batch lookup", async () => {+ const [conversation] =+ await AgentServerConversationService.batchGetAppConversations([+ TABLE_DEMO_CONVERSATION_ID,+ ]);++ expect(conversation?.id).toBe(TABLE_DEMO_CONVERSATION_ID);+ expect(conversation?.title).toBe("Wide table demo");+ });++ it("returns table demo events sorted for conversation history", async () => {+ const page = await EventService.searchEvents(+ TABLE_DEMO_CONVERSATION_ID,+ null,+ null,+ { limit: 50, sortOrder: "TIMESTAMP_DESC" },+ );++ expect(page.items).toHaveLength(2);+ expect(page.items[0]?.source).toBe("agent");+ expect(page.items[1]?.source).toBe("user");+ });});diff --git a/__tests__/components/features/markdown/markdown-table-scroll.test.tsx b/__tests__/components/features/markdown/markdown-table-scroll.test.tsxnew file mode 100644index 0000000000..b6898393bf--- /dev/null+++ b/__tests__/components/features/markdown/markdown-table-scroll.test.tsx@@ -0,0 +1,132 @@+import { render, screen, fireEvent } from "@testing-library/react";+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";+import {+ MarkdownTableScroll,+ readScrollFadeState,+} from "#/components/features/markdown/markdown-table-scroll";++function mockScrollMetrics(+ element: HTMLElement,+ metrics: { scrollWidth: number; clientWidth: number; scrollLeft: number },+) {+ Object.defineProperty(element, "scrollWidth", {+ configurable: true,+ value: metrics.scrollWidth,+ });+ Object.defineProperty(element, "clientWidth", {+ configurable: true,+ value: metrics.clientWidth,+ });+ Object.defineProperty(element, "scrollLeft", {+ configurable: true,+ writable: true,+ value: metrics.scrollLeft,+ });+}++describe("readScrollFadeState", () => {+ it("hides both fades when the table fits", () => {+ const element = document.createElement("div");+ mockScrollMetrics(element, {+ scrollWidth: 400,+ clientWidth: 400,+ scrollLeft: 0,+ });++ expect(readScrollFadeState(element)).toEqual({ left: false, right: false });+ });++ it("shows only the right fade at the start of an overflowing table", () => {+ const element = document.createElement("div");+ mockScrollMetrics(element, {+ scrollWidth: 800,+ clientWidth: 300,+ scrollLeft: 0,+ });++ expect(readScrollFadeState(element)).toEqual({ left: false, right: true });+ });++ it("shows both fades in the middle of an overflowing table", () => {+ const element = document.createElement("div");+ mockScrollMetrics(element, {+ scrollWidth: 800,+ clientWidth: 300,+ scrollLeft: 250,+ });++ expect(readScrollFadeState(element)).toEqual({ left: true, right: true });+ });++ it("shows only the left fade at the end of an overflowing table", () => {+ const element = document.createElement("div");+ mockScrollMetrics(element, {+ scrollWidth: 800,+ clientWidth: 300,+ scrollLeft: 500,+ });++ expect(readScrollFadeState(element)).toEqual({ left: true, right: false });+ });+});++describe("MarkdownTableScroll", () => {+ beforeEach(() => {+ vi.stubGlobal(+ "ResizeObserver",+ class {+ observe = vi.fn();++ unobserve = vi.fn();++ disconnect = vi.fn();+ },+ );+ });++ afterEach(() => {+ vi.unstubAllGlobals();+ });++ it("renders animated edge fades that toggle with horizontal scroll", () => {+ render(+ <MarkdownTableScroll>+ <table>+ <tbody>+ <tr>+ <td>Wide content</td>+ </tr>+ </tbody>+ </table>+ </MarkdownTableScroll>,+ );++ const scroller = screen.getByTestId("markdown-table-scroll");+ const leftFade = screen.getByTestId("markdown-table-scroll-fade-left");+ const rightFade = screen.getByTestId("markdown-table-scroll-fade-right");++ mockScrollMetrics(scroller, {+ scrollWidth: 900,+ clientWidth: 320,+ scrollLeft: 0,+ });+ fireEvent.scroll(scroller);++ expect(rightFade).toHaveAttribute("data-visible", "true");+ expect(rightFade).toHaveClass("opacity-100");+ expect(leftFade).toHaveAttribute("data-visible", "false");+ expect(leftFade).toHaveClass("opacity-0");++ mockScrollMetrics(scroller, {+ scrollWidth: 900,+ clientWidth: 320,+ scrollLeft: 580,+ });+ fireEvent.scroll(scroller);++ expect(leftFade).toHaveAttribute("data-visible", "true");+ expect(leftFade).toHaveClass("opacity-100");+ expect(rightFade).toHaveAttribute("data-visible", "false");+ expect(rightFade).toHaveClass("opacity-0");+ });+});diff --git a/__tests__/components/features/markdown/table.test.tsx b/__tests__/components/features/markdown/table.test.tsxindex df9686dcce..958984ddfc 100644--- a/__tests__/components/features/markdown/table.test.tsx+++ b/__tests__/components/features/markdown/table.test.tsx@@ -22,10 +22,39 @@ describe("table (markdown)", () => {<MarkdownRenderer>{GFM_TABLE}</MarkdownRenderer>,);- // Wide tables must not break chat layout β wrapper enables overflow- const wrapper = container.querySelector(".overflow-x-auto");- expect(wrapper).not.toBeNull();- expect(wrapper?.querySelector("table")).not.toBeNull();+ const wrapper = screen.getByTestId("markdown-table-scroll");+ expect(wrapper).toHaveClass("overflow-x-auto");+ expect(wrapper).toHaveClass("custom-scrollbar-always");+ expect(wrapper).toHaveClass("max-w-full");+ expect(wrapper.querySelector("table")).not.toBeNull();+ expect(container.querySelector(".overflow-x-auto")).not.toBeNull();+ });++ it("should round corners on the table element", () => {+ render(<MarkdownRenderer>{GFM_TABLE}</MarkdownRenderer>);++ const table = screen.getByRole("table");+ expect(table).toHaveClass("rounded-xl");+ expect(table).toHaveClass("overflow-hidden");++ const wrapper = screen.getByTestId("markdown-table-scroll");+ expect(wrapper).not.toHaveClass("rounded-xl");++ expect(+ screen.getByTestId("markdown-table-scroll-fade-left"),+ ).toBeInTheDocument();+ expect(+ screen.getByTestId("markdown-table-scroll-fade-right"),+ ).toBeInTheDocument();+ });++ it("should let wide tables grow beyond the chat column instead of squishing columns", () => {+ render(<MarkdownRenderer>{GFM_TABLE}</MarkdownRenderer>);++ const table = screen.getByRole("table");+ expect(table).toHaveClass("w-max");+ expect(table).toHaveClass("min-w-full");+ expect(table).not.toHaveClass("w-full");});it("should render header cells as <th> elements with correct content", () => {diff --git a/__tests__/fixtures/table-demo-conversation.test.ts b/__tests__/fixtures/table-demo-conversation.test.tsnew file mode 100644index 0000000000..e186ce616d--- /dev/null+++ b/__tests__/fixtures/table-demo-conversation.test.ts@@ -0,0 +1,24 @@+import { describe, expect, it } from "vitest";+import {+ TABLE_DEMO_CONVERSATION_ID,+ TABLE_DEMO_EVENTS,+} from "#/fixtures/table-demo-conversation";++describe("table demo conversation fixture", () => {+ it("seeds a user message and an agent reply with a wide markdown table", () => {+ expect(TABLE_DEMO_CONVERSATION_ID).toBe("table-demo");+ expect(TABLE_DEMO_EVENTS).toHaveLength(2);+ expect(TABLE_DEMO_EVENTS[0]?.source).toBe("user");+ expect(TABLE_DEMO_EVENTS[1]?.source).toBe("agent");++ const agentText =+ "llm_message" in TABLE_DEMO_EVENTS[1]!+ ? TABLE_DEMO_EVENTS[1].llm_message.content[0]+ : null;+ expect(agentText).toMatchObject({ type: "text" });+ if (agentText && "text" in agentText) {+ expect(agentText.text).toContain("| Feature | OpenHands |");+ expect(agentText.text).toContain("| Continue |");+ }+ });+});diff --git a/src/components/features/home/llm-not-configured-banner.tsx b/src/components/features/home/llm-not-configured-banner.tsxindex 75634ab3ab..860456e61f 100644--- a/src/components/features/home/llm-not-configured-banner.tsx+++ b/src/components/features/home/llm-not-configured-banner.tsx@@ -29,11 +29,11 @@ export function LlmNotConfiguredBanner() {<divdata-testid="home-llm-not-configured-banner"role="alert"- className="bg-base border border-primary text-white p-4 rounded flex flex-row items-center justify-between gap-3 mt-3"+ className="mt-3 flex w-full flex-col gap-3 rounded-xl border border-[var(--oh-border)] bg-[var(--oh-surface-raised)] px-4 py-3 text-[var(--oh-foreground)] sm:flex-row sm:items-center sm:justify-between sm:py-4">- <div className="flex items-center">+ <div className="flex min-w-0 items-start sm:items-center"><div className="flex-shrink-0">- <FaTriangleExclamation className="text-primary align-middle" />+ <FaTriangleExclamation className="align-middle text-yellow-400" /></div><Typography.Text className="ml-3 text-sm font-medium">{t(I18nKey.HOME$LLM_NOT_CONFIGURED_MESSAGE)}@@ -44,6 +44,7 @@ export function LlmNotConfiguredBanner() {testId="home-llm-not-configured-action"type="button"variant="primary"+ className="w-fit shrink-0 self-start whitespace-nowrap sm:self-auto"onClick={() => navigate("/settings/llm")}>{t(I18nKey.HOME$LLM_NOT_CONFIGURED_ACTION)}diff --git a/src/components/features/markdown/markdown-table-scroll.tsx b/src/components/features/markdown/markdown-table-scroll.tsxnew file mode 100644index 0000000000..ea23ec1a8e--- /dev/null+++ b/src/components/features/markdown/markdown-table-scroll.tsx@@ -0,0 +1,97 @@+import React from "react";+import { cn } from "#/utils/utils";++const SCROLL_EDGE_THRESHOLD_PX = 1;+const FADE_WIDTH_CLASS = "w-10";++interface MarkdownTableScrollProps {+ children: React.ReactNode;+}++interface ScrollFadeState {+ left: boolean;+ right: boolean;+}++export function readScrollFadeState(element: HTMLDivElement): ScrollFadeState {+ const { scrollLeft, scrollWidth, clientWidth } = element;+ const maxScroll = scrollWidth - clientWidth;+ const hasOverflow = maxScroll > SCROLL_EDGE_THRESHOLD_PX;++ return {+ left: hasOverflow && scrollLeft > SCROLL_EDGE_THRESHOLD_PX,+ right: hasOverflow && scrollLeft < maxScroll - SCROLL_EDGE_THRESHOLD_PX,+ };+}++export function MarkdownTableScroll({ children }: MarkdownTableScrollProps) {+ const scrollRef = React.useRef<HTMLDivElement>(null);+ const [fadeState, setFadeState] = React.useState<ScrollFadeState>({+ left: false,+ right: false,+ });++ const updateFadeState = React.useCallback(() => {+ const element = scrollRef.current;+ if (!element) {+ return;+ }+ setFadeState(readScrollFadeState(element));+ }, []);++ React.useLayoutEffect(() => {+ updateFadeState();++ const element = scrollRef.current;+ if (!element) {+ return undefined;+ }++ const resizeObserver = new ResizeObserver(updateFadeState);+ resizeObserver.observe(element);++ const table = element.firstElementChild;+ if (table) {+ resizeObserver.observe(table);+ }++ return () => resizeObserver.disconnect();+ }, [updateFadeState, children]);++ return (+ <div className="relative max-w-full">+ <div+ ref={scrollRef}+ data-testid="markdown-table-scroll"+ onScroll={updateFadeState}+ className="max-w-full overflow-x-auto custom-scrollbar-always"+ >+ {children}+ </div>+ <div+ aria-hidden+ data-testid="markdown-table-scroll-fade-left"+ data-visible={fadeState.left ? "true" : "false"}+ className={cn(+ "pointer-events-none absolute inset-y-0 left-0 z-10",+ FADE_WIDTH_CLASS,+ "bg-gradient-to-r from-base to-transparent",+ "transition-opacity duration-300 ease-out motion-reduce:transition-none",+ fadeState.left ? "opacity-100" : "opacity-0",+ )}+ />+ <div+ aria-hidden+ data-testid="markdown-table-scroll-fade-right"+ data-visible={fadeState.right ? "true" : "false"}+ className={cn(+ "pointer-events-none absolute inset-y-0 right-0 z-10",+ FADE_WIDTH_CLASS,+ "bg-gradient-to-l from-base to-transparent",+ "transition-opacity duration-300 ease-out motion-reduce:transition-none",+ fadeState.right ? "opacity-100" : "opacity-0",+ )}+ />+ </div>+ );+}diff --git a/src/components/features/markdown/table.tsx b/src/components/features/markdown/table.tsxindex 615d1c189e..389430f721 100644--- a/src/components/features/markdown/table.tsx+++ b/src/components/features/markdown/table.tsx@@ -1,5 +1,6 @@import React from "react";import { ExtraProps } from "react-markdown";+import { MarkdownTableScroll } from "./markdown-table-scroll";// Custom component to render <table> in markdownexport function table({@@ -8,11 +9,18 @@ export function table({React.TableHTMLAttributes<HTMLTableElement> &ExtraProps) {return (- <div className="my-4 w-full overflow-x-auto">- <table className="w-full border-collapse border border-[var(--oh-border)] text-sm">+ <MarkdownTableScroll>+ <table+ className={[+ "my-4 w-max min-w-full border-separate border-spacing-0 overflow-hidden rounded-xl border border-[var(--oh-border)] text-sm",+ "[&_td]:border-b [&_td]:border-r [&_th]:border-b [&_th]:border-r",+ "[&_td:last-child]:border-r-0 [&_th:last-child]:border-r-0",+ "[&_tbody_tr:last-child_td]:border-b-0",+ ].join(" ")}+ >{children}</table>- </div>+ </MarkdownTableScroll>);}@@ -23,7 +31,7 @@ export function th({React.ThHTMLAttributes<HTMLTableCellElement> &ExtraProps) {return (- <th className="border border-[var(--oh-border)] bg-[var(--oh-surface)] px-3 py-2 text-left font-semibold text-white">+ <th className="whitespace-nowrap border-[var(--oh-border)] bg-[var(--oh-surface)] px-3 py-2 text-left font-semibold text-white">{children}</th>);@@ -36,7 +44,7 @@ export function td({React.TdHTMLAttributes<HTMLTableCellElement> &ExtraProps) {return (- <td className="border border-[var(--oh-border)] px-3 py-2 align-top">+ <td className="whitespace-nowrap border-[var(--oh-border)] px-3 py-2 align-top">{children}</td>);diff --git a/src/components/features/mcp-page/mcp-logo-stack-badge.tsx b/src/components/features/mcp-page/mcp-logo-stack-badge.tsxindex 94bee5cd02..2c7d173225 100644--- a/src/components/features/mcp-page/mcp-logo-stack-badge.tsx+++ b/src/components/features/mcp-page/mcp-logo-stack-badge.tsx@@ -1,4 +1,3 @@-import type { IntegrationCatalogEntry } from "@openhands/extensions/integrations";import {McpLogoBadge,type McpLogoEntry,@@ -9,12 +8,7 @@ const STACK_CONTAINER_CLASS_NAME ="inline-flex h-10 w-10 shrink-0 overflow-hidden rounded-lg border border-white/10 bg-surface-raised shadow-[inset_0_1px_0_rgba(255,255,255,0.18)]";interface McpLogoStackBadgeProps {- entries: Array<- Pick<- IntegrationCatalogEntry,- "id" | "name" | "iconBg" | "iconColor" | "logoUrl"- >- >;+ entries: McpLogoEntry[];className?: string;testId?: string;}diff --git a/src/components/features/onboarding/onboarding-modal.tsx b/src/components/features/onboarding/onboarding-modal.tsxindex facf9d516a..92db30982f 100644--- a/src/components/features/onboarding/onboarding-modal.tsx+++ b/src/components/features/onboarding/onboarding-modal.tsx@@ -220,7 +220,7 @@ export function OnboardingModal({<divdata-testid="onboarding-scroll-area"- className="flex-1 min-h-0 overflow-y-auto custom-scrollbar-always px-7 pb-7"+ className="flex-1 min-h-0 overflow-y-auto custom-scrollbar-always px-7"><divdata-testid="onboarding-slide-rail"diff --git a/src/fixtures/table-demo-conversation.ts b/src/fixtures/table-demo-conversation.tsnew file mode 100644index 0000000000..811e4f28e3--- /dev/null+++ b/src/fixtures/table-demo-conversation.ts@@ -0,0 +1,58 @@+import type { MessageEvent, OpenHandsEvent } from "#/types/agent-server/core";++export const TABLE_DEMO_CONVERSATION_ID = "table-demo";++const TABLE_DEMO_USER_MESSAGE =+ "Can you compare several coding agents in a wide table?";++/** Wide GFM table used to exercise horizontal scrolling in the chat feed. */+export const TABLE_DEMO_AGENT_MARKDOWN = [+ "Here is a wide comparison table. Scroll horizontally to read every column:",+ "",+ "| Feature | OpenHands | Claude Code | Codex | Gemini CLI | Cursor | Windsurf | Cline | Aider | Devin | Continue |",+ "| --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |",+ "| CLI | Yes | Yes | Yes | Yes | IDE | IDE | IDE | Terminal | Cloud | IDE |",+ "| MCP support | Yes | Yes | Partial | Partial | Yes | Yes | Yes | No | Yes | Yes |",+ "| Local models | Yes | Yes | Yes | Yes | Yes | Yes | Yes | Yes | No | Yes |",+ "| Browser tools | Yes | Yes | Yes | Limited | Yes | Yes | Yes | No | Yes | Yes |",+ "| Git integration | Yes | Yes | Yes | Yes | Yes | Yes | Yes | Yes | Yes | Yes |",+ "| Best for | General coding | Anthropic stack | OpenAI stack | Google stack | IDE users | IDE users | VS Code | Terminal | Autonomous | IDE users |",+].join("\n");++const TABLE_DEMO_BASE_TIME = Date.UTC(2026, 5, 23, 12, 0, 0);++function createTableDemoMessageEvent(+ id: string,+ role: "user" | "assistant",+ text: string,+ offsetMinutes: number,+): MessageEvent {+ return {+ id,+ timestamp: new Date(+ TABLE_DEMO_BASE_TIME + offsetMinutes * 60_000,+ ).toISOString(),+ source: role === "user" ? "user" : "agent",+ llm_message: {+ role,+ content: [{ type: "text", text }],+ },+ activated_microagents: [],+ extended_content: [],+ };+}++export const TABLE_DEMO_EVENTS: OpenHandsEvent[] = [+ createTableDemoMessageEvent(+ "table-demo-user-1",+ "user",+ TABLE_DEMO_USER_MESSAGE,+ 0,+ ),+ createTableDemoMessageEvent(+ "table-demo-agent-1",+ "assistant",+ TABLE_DEMO_AGENT_MARKDOWN,+ 1,+ ),+];diff --git a/src/mocks/conversation-handlers.ts b/src/mocks/conversation-handlers.tsindex 5cecc52bdb..81fcbd98b8 100644--- a/src/mocks/conversation-handlers.ts+++ b/src/mocks/conversation-handlers.ts@@ -6,9 +6,15 @@ import {type OpenHandsEvent,} from "#/types/agent-server/core";import { GetMicroagentsResponse } from "#/api/open-hands.types";+import {+ TABLE_DEMO_CONVERSATION_ID,+ TABLE_DEMO_EVENTS,+} from "#/fixtures/table-demo-conversation";/** Map from conversation id β events returned by GET /events/search */-const CONVERSATION_EVENTS: Record<string, unknown[]> = {};+const CONVERSATION_EVENTS: Record<string, unknown[]> = {+ [TABLE_DEMO_CONVERSATION_ID]: TABLE_DEMO_EVENTS,+};const now = Date.now();const PAGINATION_LOCAL_CONVERSATION_ID = "pagination-local";@@ -83,6 +89,14 @@ const conversations: MockConversation[] = [execution_status: "idle",workspace: { working_dir: "/workspace/project" },},+ {+ id: TABLE_DEMO_CONVERSATION_ID,+ title: "Wide table demo",+ created_at: new Date(now - 1 * 24 * 60 * 60 * 1000).toISOString(),+ updated_at: new Date(now - 1 * 24 * 60 * 60 * 1000).toISOString(),+ execution_status: "idle",+ workspace: { working_dir: "/workspace/project" },+ },];const CONVERSATIONS = new Map<string, MockConversation>(@@ -298,13 +312,24 @@ export const CONVERSATION_HANDLERS = ["*/api/conversations/:conversationId/events/search",async ({ params, request }) => {const conversationId = params.conversationId as string;+ const searchParams = new URL(request.url).searchParams;const paginationPage = await maybeReturnPaginationEvents(conversationId,- new URL(request.url).searchParams,+ searchParams,);if (paginationPage) return HttpResponse.json(paginationPage);- const items = CONVERSATION_EVENTS[conversationId] ?? [];- return HttpResponse.json({ items, next_page_id: null });++ const staticEvents = CONVERSATION_EVENTS[conversationId];+ if (staticEvents) {+ return HttpResponse.json(+ searchPaginationEvents(+ staticEvents as OpenHandsEvent[],+ searchParams,+ ),+ );+ }++ return HttpResponse.json({ items: [], next_page_id: null });},),diff --git a/src/routes/home.tsx b/src/routes/home.tsxindex fbe36cbbce..4cdb0862c1 100644--- a/src/routes/home.tsx+++ b/src/routes/home.tsx@@ -17,7 +17,9 @@ function HomeScreen() {data-testid="home-screen"className="custom-scrollbar-always flex h-full flex-col overflow-y-auto rounded-xl bg-transparent px-4 md:px-0 lg:px-[42px]">- <LlmNotConfiguredBanner />+ <div className="md:px-4 lg:px-0">+ <LlmNotConfiguredBanner />+ </div><div className="flex flex-1 min-h-0 flex-col items-center justify-center"><HomeChatLauncher />