Skip to content

πŸ™Œ OpenHands: AI-Driven Development

test: drop should-not-exist assertions on removed code (APP-2570) (#1554)

Tim O'Farrell8bb56236551b
diff --git a/__tests__/components/features/conversation-panel/conversation-card.test.tsx b/__tests__/components/features/conversation-panel/conversation-card.test.tsx
index fe1fd70f53..d73f53c6de 100644
--- a/__tests__/components/features/conversation-panel/conversation-card.test.tsx
+++ b/__tests__/components/features/conversation-panel/conversation-card.test.tsx
@@ -490,22 +490,6 @@ describe("ConversationCard", () => {
expect(screen.queryByTestId("ellipsis-button")).not.toBeInTheDocument();
});
- it("should not render the llm model in the conversation card", () => {
- renderWithProviders(
- <ConversationCard
- onDelete={onDelete}
- onChangeTitle={onChangeTitle}
- title="Conversation 1"
- selectedRepository={null}
- lastUpdatedAt="2021-10-01T12:00:00Z"
- />,
- );
-
- expect(
- screen.queryByTestId("conversation-card-llm-model"),
- ).not.toBeInTheDocument();
- });
-
it("renders the status dot in the header when executionStatus is provided", () => {
renderWithProviders(
<ConversationCard
diff --git a/__tests__/routes/agent-settings.test.tsx b/__tests__/routes/agent-settings.test.tsx
index 31976e08fd..162a99c66b 100644
--- a/__tests__/routes/agent-settings.test.tsx
+++ b/__tests__/routes/agent-settings.test.tsx
@@ -772,8 +772,8 @@ describe("AgentSettingsScreen", () => {
renderAgentSettingsScreen();
await screen.findByTestId("agent-settings-screen");
- // Switch to ACP (Claude Code prefilled) and paste a credential β€” there is
- // ONE Save button for the whole page; the credentials section has none.
+ // Switch to ACP (Claude Code prefilled) and paste a credential, then click
+ // the single page-level Save button.
await user.click(screen.getByTestId("agent-type-selector"));
await user.click(
await screen.findByRole("option", { name: "SETTINGS$AGENT_TYPE_ACP" }),
@@ -782,9 +782,6 @@ describe("AgentSettingsScreen", () => {
await screen.findByTestId("settings-acp-secret-ANTHROPIC_API_KEY"),
"sk-ant-xyz",
);
- expect(
- screen.queryByTestId("acp-credentials-save-button"),
- ).not.toBeInTheDocument();
await user.click(screen.getByTestId("agent-save-button"));
diff --git a/__tests__/routes/device-verify.test.tsx b/__tests__/routes/device-verify.test.tsx
index 2cce6c7e24..2e04bfb52c 100644
--- a/__tests__/routes/device-verify.test.tsx
+++ b/__tests__/routes/device-verify.test.tsx
@@ -228,30 +228,6 @@ describe("DeviceVerify", () => {
});
});
- it("keeps the device verification view OSS-only without login CTA chrome", async () => {
- useIsAuthedMock.mockReturnValue({
- data: true,
- isLoading: false,
- });
-
- render(
- <RouterStub initialEntries={["/device-verify?user_code=ABC-123"]} />,
- {
- wrapper: createWrapper(),
- },
- );
-
- await waitFor(() => {
- expect(
- screen.getByText("DEVICE$AUTHORIZATION_REQUEST"),
- ).toBeInTheDocument();
- });
-
- expect(screen.queryByTestId("login-cta")).not.toBeInTheDocument();
- expect(document.querySelector(".max-w-md")).toBeInTheDocument();
- expect(document.querySelector(".max-w-4xl")).not.toBeInTheDocument();
- });
-
it("should call window.close when cancel button is clicked", async () => {
const user = userEvent.setup();
useIsAuthedMock.mockReturnValue({