Skip to content

πŸ™Œ OpenHands: AI-Driven Development

refactor(frontend): The Jupyter tab is not showing "Waiting for runtime to start..." when connecting to an agent (#9626)

Hiep Le8d165674289c
diff --git a/frontend/src/components/features/jupyter/jupyter.tsx b/frontend/src/components/features/jupyter/jupyter.tsx
index 0ce1480c94..3fe25fa9d0 100644
--- a/frontend/src/components/features/jupyter/jupyter.tsx
+++ b/frontend/src/components/features/jupyter/jupyter.tsx
@@ -1,9 +1,11 @@
import React from "react";
import { useSelector } from "react-redux";
+import { useTranslation } from "react-i18next";
import { RootState } from "#/store";
import { useScrollToBottom } from "#/hooks/use-scroll-to-bottom";
import { JupyterCell } from "./jupyter-cell";
import { ScrollToBottomButton } from "#/components/shared/buttons/scroll-to-bottom-button";
+import { RUNTIME_INACTIVE_STATES } from "#/types/agent-state";
interface JupyterEditorProps {
maxWidth: number;
@@ -11,28 +13,43 @@ interface JupyterEditorProps {
export function JupyterEditor({ maxWidth }: JupyterEditorProps) {
const cells = useSelector((state: RootState) => state.jupyter?.cells ?? []);
+ const { curAgentState } = useSelector((state: RootState) => state.agent);
+
const jupyterRef = React.useRef<HTMLDivElement>(null);
+ const { t } = useTranslation();
+
+ const isRuntimeInactive = RUNTIME_INACTIVE_STATES.includes(curAgentState);
+
const { hitBottom, scrollDomToBottom, onChatBodyScroll } =
useScrollToBottom(jupyterRef);
return (
- <div className="flex-1 h-full flex flex-col" style={{ maxWidth }}>
- <div
- data-testid="jupyter-container"
- className="flex-1 overflow-y-auto fast-smooth-scroll"
- ref={jupyterRef}
- onScroll={(e) => onChatBodyScroll(e.currentTarget)}
- >
- {cells.map((cell, index) => (
- <JupyterCell key={index} cell={cell} />
- ))}
- </div>
- {!hitBottom && (
- <div className="sticky bottom-2 flex items-center justify-center">
- <ScrollToBottomButton onClick={scrollDomToBottom} />
+ <>
+ {isRuntimeInactive && (
+ <div className="w-full h-full flex items-center text-center justify-center text-2xl text-tertiary-light">
+ {t("DIFF_VIEWER$WAITING_FOR_RUNTIME")}
+ </div>
+ )}
+ {!isRuntimeInactive && (
+ <div className="flex-1 h-full flex flex-col" style={{ maxWidth }}>
+ <div
+ data-testid="jupyter-container"
+ className="flex-1 overflow-y-auto fast-smooth-scroll"
+ ref={jupyterRef}
+ onScroll={(e) => onChatBodyScroll(e.currentTarget)}
+ >
+ {cells.map((cell, index) => (
+ <JupyterCell key={index} cell={cell} />
+ ))}
+ </div>
+ {!hitBottom && (
+ <div className="sticky bottom-2 flex items-center justify-center">
+ <ScrollToBottomButton onClick={scrollDomToBottom} />
+ </div>
+ )}
</div>
)}
- </div>
+ </>
);
}