π OpenHands: AI-Driven Development
APP-1325: accept '1' as truthy value for SLACK_WEBHOOKS_ENABLED to surface slack integration settings (#14255)
aivong-openhands8e21654a6673
diff --git a/openhands/app_server/web_client/default_web_client_config_injector.py b/openhands/app_server/web_client/default_web_client_config_injector.pyindex 61d3803fa2..26c2dac50a 100644--- a/openhands/app_server/web_client/default_web_client_config_injector.py+++ b/openhands/app_server/web_client/default_web_client_config_injector.py@@ -100,7 +100,7 @@ def _get_github_app_slug() -> str | None:def _get_slack_enabled() -> bool:"""Return whether Slack integration is fully configured for the web client."""return (- os.getenv('SLACK_WEBHOOKS_ENABLED', 'false').lower() == 'true'+ os.getenv('SLACK_WEBHOOKS_ENABLED', 'false').lower() in ('true', '1')and bool(os.getenv('SLACK_CLIENT_ID', '').strip())and bool(os.getenv('SLACK_CLIENT_SECRET', '').strip())and bool(os.getenv('SLACK_SIGNING_SECRET', '').strip())diff --git a/tests/unit/app_server/test_default_web_client_config_injector.py b/tests/unit/app_server/test_default_web_client_config_injector.pyindex 06779ac24a..d08c44eb17 100644--- a/tests/unit/app_server/test_default_web_client_config_injector.py+++ b/tests/unit/app_server/test_default_web_client_config_injector.py@@ -538,6 +538,24 @@ class TestGetSlackEnabled:):assert _get_slack_enabled() is False+ def test_returns_true_when_webhooks_enabled_is_set_to_1(self):+ """Slack is enabled when SLACK_WEBHOOKS_ENABLED is '1' (older chart format)."""+ from openhands.app_server.web_client.default_web_client_config_injector import (+ _get_slack_enabled,+ )++ with patch.dict(+ os.environ,+ {+ 'SLACK_WEBHOOKS_ENABLED': '1',+ 'SLACK_CLIENT_ID': 'client-id',+ 'SLACK_CLIENT_SECRET': 'client-secret',+ 'SLACK_SIGNING_SECRET': 'signing-secret',+ },+ clear=True,+ ):+ assert _get_slack_enabled() is True+def test_returns_false_when_a_required_slack_secret_is_missing(self):"""Slack stays disabled when one of the required credentials is missing."""from openhands.app_server.web_client.default_web_client_config_injector import (