π OpenHands: AI-Driven Development
fix(frontend): block /settings/org-defaults* routes in OSS mode (#14144)
Hiep Le93355fd7704d
diff --git a/frontend/__tests__/routes/settings.test.tsx b/frontend/__tests__/routes/settings.test.tsxindex 1eb14c6793..f6b73010d6 100644--- a/frontend/__tests__/routes/settings.test.tsx+++ b/frontend/__tests__/routes/settings.test.tsx@@ -279,6 +279,38 @@ describe("Settings Screen", () => {getConfigSpy.mockRestore();});+ it.each([+ {+ path: "/settings/org-defaults",+ testId: "org-default-llm-settings-screen",+ },+ {+ path: "/settings/org-defaults/condenser",+ testId: "org-default-condenser-settings-screen",+ },+ {+ path: "/settings/org-defaults/verification",+ testId: "org-default-verification-settings-screen",+ },+ ])(+ "should redirect away from $path in OSS mode",+ async ({ path, testId }) => {+ const getConfigSpy = vi.spyOn(OptionService, "getConfig");+ // @ts-expect-error - only return app mode+ getConfigSpy.mockResolvedValue({ app_mode: "oss" });+ mockQueryClient.clear();++ renderSettingsScreen(path);++ await waitFor(() => {+ expect(screen.getByTestId("llm-settings-screen")).toBeInTheDocument();+ });+ expect(screen.queryByTestId(testId)).not.toBeInTheDocument();++ getConfigSpy.mockRestore();+ },+ );+it.todo("should not be able to access oss-only routes in saas mode");describe("Personal org vs team org visibility", () => {diff --git a/frontend/src/routes/settings.tsx b/frontend/src/routes/settings.tsxindex 0f5a21648a..22a74c753a 100644--- a/frontend/src/routes/settings.tsx+++ b/frontend/src/routes/settings.tsx@@ -30,6 +30,9 @@ const SAAS_ONLY_PATHS = ["/settings/api-keys","/settings/team","/settings/org",+ "/settings/org-defaults",+ "/settings/org-defaults/condenser",+ "/settings/org-defaults/verification",];const ORG_WIDE_BADGE_PATHS = new Set<string>([