Skip to content

πŸ™Œ OpenHands: AI-Driven Development

Fix: upgrade typescript-client to v1.25.0 for pinned ACP versions (#1369)

simonrosenberg94d5ecff9c09
diff --git a/__tests__/api/agent-server-adapter.test.ts b/__tests__/api/agent-server-adapter.test.ts
index e772eb55a4..20957fde77 100644
--- a/__tests__/api/agent-server-adapter.test.ts
+++ b/__tests__/api/agent-server-adapter.test.ts
@@ -1199,7 +1199,7 @@ describe("buildStartConversationRequest β€” ACP discriminator", () => {
schema_version: 1,
agent_kind: "acp",
acp_server: "claude-code",
- acp_command: ["npx", "-y", "@agentclientprotocol/claude-agent-acp"],
+ acp_command: [],
acp_model: "claude-opus-4-5",
// These fields are LLM-only and must NOT leak into ACP settings.
// (mcp_config is handled separately β€” it IS forwarded for ACP; see
@@ -1224,7 +1224,7 @@ describe("buildStartConversationRequest β€” ACP discriminator", () => {
expect(payload.agent_settings.acp_command).toEqual([
"npx",
"-y",
- "@agentclientprotocol/claude-agent-acp",
+ "@agentclientprotocol/[email protected]",
]);
expect(payload.agent_settings.acp_model).toBe("claude-opus-4-5");
// LLM-only fields must not leak into the ACP settings payload.
@@ -1373,7 +1373,7 @@ describe("buildStartConversationRequest β€” ACP discriminator", () => {
expect(payload.agent_settings.acp_command).toEqual([
"npx",
"-y",
- "@agentclientprotocol/claude-agent-acp",
+ "@agentclientprotocol/[email protected]",
]);
});
@@ -1395,7 +1395,7 @@ describe("buildStartConversationRequest β€” ACP discriminator", () => {
expect(payload.agent_settings.acp_command).toEqual([
"npx",
"-y",
- "@zed-industries/codex-acp",
+ "@zed-industries/[email protected]",
]);
});
@@ -1460,7 +1460,7 @@ describe("buildStartConversationRequest β€” ACP discriminator", () => {
agent_settings: Record<string, unknown> & { acp_model?: unknown };
};
- expect(payload.agent_settings.acp_model).toBe("claude-opus-4-7");
+ expect(payload.agent_settings.acp_model).toBe("claude-opus-4-8");
});
it("omits acp_model for the custom preset when none is configured", () => {
@@ -1542,7 +1542,7 @@ describe("buildStartConversationRequest β€” ACP discriminator", () => {
expect(acpPayload.agent_settings.acp_command).toEqual([
"npx",
"-y",
- "@agentclientprotocol/claude-agent-acp",
+ "@agentclientprotocol/[email protected]",
]);
expect(acpPayload.agent_settings.acp_model).toBe("claude-opus-4-5");
// acp_env is no longer a forwarded ACP setting β€” a stale value on saved
diff --git a/__tests__/components/features/chat/components/chat-input-model.test.tsx b/__tests__/components/features/chat/components/chat-input-model.test.tsx
index 18a1ce278e..ba84553186 100644
--- a/__tests__/components/features/chat/components/chat-input-model.test.tsx
+++ b/__tests__/components/features/chat/components/chat-input-model.test.tsx
@@ -216,10 +216,10 @@ describe("ChatInputModel", () => {
renderWithProviders(<ChatInputModel />);
const model = screen.getByTestId("chat-input-llm-model");
- // Claude Code's registered default (``claude-opus-4-7``), shown as its
+ // Claude Code's registered default (``claude-opus-4-8``), shown as its
// human label to match the conversation list chip. See CLAUDE_MODELS in
// acp-providers.ts.
- expect(model).toHaveAttribute("title", "Claude Opus 4.7");
+ expect(model).toHaveAttribute("title", "Claude Opus 4.8");
fireEvent.click(model);
expect(screen.getByRole("link")).toHaveAttribute("href", "/settings/agent");
});
@@ -246,7 +246,7 @@ describe("ChatInputModel", () => {
expect(selectedRow).toBeInTheDocument();
expect(selectedRow).toHaveTextContent("Claude Sonnet 4.6");
expect(
- screen.getByTestId("chat-input-acp-model-option-claude-opus-4-7"),
+ screen.getByTestId("chat-input-acp-model-option-claude-opus-4-8"),
).toBeInTheDocument();
});
@@ -264,14 +264,14 @@ describe("ChatInputModel", () => {
fireEvent.click(screen.getByTestId("chat-input-llm-model"));
fireEvent.click(
- screen.getByTestId("chat-input-acp-model-option-claude-opus-4-7"),
+ screen.getByTestId("chat-input-acp-model-option-claude-opus-4-8"),
);
// Active conversation β†’ live switch keyed by the conversation id from the
// navigation context (test-conversation-id), default-write NOT used.
expect(switchAcpModelMutate).toHaveBeenCalledWith({
conversationId: "test-conversation-id",
- model: "claude-opus-4-7",
+ model: "claude-opus-4-8",
});
// Popover closes after a selection.
expect(
@@ -326,7 +326,7 @@ describe("ChatInputModel", () => {
expect(selectedRow).toBeInTheDocument();
expect(selectedRow).toHaveTextContent("Claude Sonnet 4.6");
expect(
- screen.getByTestId("chat-input-acp-model-option-claude-opus-4-7"),
+ screen.getByTestId("chat-input-acp-model-option-claude-opus-4-8"),
).toBeInTheDocument();
const popover = screen.getByTestId("chat-input-llm-model-popover");
expect(popover).toHaveTextContent("Claude Sonnet 4.6");
diff --git a/__tests__/components/features/conversation-panel/conversation-card.test.tsx b/__tests__/components/features/conversation-panel/conversation-card.test.tsx
index 0a8fa770d6..0b4c5b663c 100644
--- a/__tests__/components/features/conversation-panel/conversation-card.test.tsx
+++ b/__tests__/components/features/conversation-panel/conversation-card.test.tsx
@@ -667,7 +667,7 @@ describe("ConversationCard", () => {
it("shows the provider's picker label for a known model ID", () => {
// When ``llm_model`` is a registry-known ID, the chip renders the
- // human label ("Claude Opus 4.7") instead of the raw ID β€” matching
+ // human label ("Claude Opus 4.8") instead of the raw ID β€” matching
// what the Settings β†’ Agent picker shows for the same value.
renderWithProviders(
<ConversationCard
@@ -677,13 +677,13 @@ describe("ConversationCard", () => {
showLlmProfiles
agentKind="acp"
acpServer="claude-code"
- llmModel="claude-opus-4-7"
+ llmModel="claude-opus-4-8"
/>,
);
const chip = screen.getByTestId("conversation-card-agent-chip");
- expect(chip).toHaveTextContent("Claude Opus 4.7");
- expect(chip).toHaveAttribute("title", "Claude Code Β· Claude Opus 4.7");
+ expect(chip).toHaveTextContent("Claude Opus 4.8");
+ expect(chip).toHaveAttribute("title", "Claude Code Β· Claude Opus 4.8");
});
it("falls back to the provider display name for an ACP conversation with no model", () => {
diff --git a/__tests__/components/onboarding/choose-agent-step.test.tsx b/__tests__/components/onboarding/choose-agent-step.test.tsx
index 08451150da..f6d2af35d2 100644
--- a/__tests__/components/onboarding/choose-agent-step.test.tsx
+++ b/__tests__/components/onboarding/choose-agent-step.test.tsx
@@ -171,7 +171,7 @@ describe("ChooseAgentStep", () => {
// ``acp_args`` can't survive and concatenate onto the spawn
// command at conversation-create time.
acp_args: [],
- acp_model: "claude-opus-4-7",
+ acp_model: "claude-opus-4-8",
});
});
diff --git a/__tests__/routes/agent-settings.test.tsx b/__tests__/routes/agent-settings.test.tsx
index 2f22751ad2..b80459424f 100644
--- a/__tests__/routes/agent-settings.test.tsx
+++ b/__tests__/routes/agent-settings.test.tsx
@@ -231,7 +231,7 @@ describe("AgentSettingsScreen", () => {
await screen.findByTestId("agent-command-input");
expect(screen.getByLabelText("SETTINGS$AGENT_MODEL")).toHaveValue(
- "Claude Opus 4.7",
+ "Claude Opus 4.8",
);
});
@@ -289,7 +289,7 @@ describe("AgentSettingsScreen", () => {
await screen.findByTestId("agent-command-input");
// Form loads with the Claude Code default visible.
expect(screen.getByLabelText("SETTINGS$AGENT_MODEL")).toHaveValue(
- "Claude Opus 4.7",
+ "Claude Opus 4.8",
);
// Switch to the Custom preset, then enter a different command β€” the
@@ -345,14 +345,14 @@ describe("AgentSettingsScreen", () => {
renderAgentSettingsScreen();
await screen.findByTestId("agent-command-input");
expect(screen.getByLabelText("SETTINGS$AGENT_MODEL")).toHaveValue(
- "Claude Opus 4.7",
+ "Claude Opus 4.8",
);
const commandInput = screen.getByTestId(
"agent-command-input",
) as HTMLTextAreaElement;
await user.clear(commandInput);
- await user.type(commandInput, "npx -y @zed-industries/codex-acp");
+ await user.type(commandInput, "npx -y @zed-industries/[email protected]");
// The model field now reflects the Codex default, not the stale Claude one.
expect(screen.getByLabelText("SETTINGS$AGENT_MODEL")).toHaveValue(
@@ -397,10 +397,10 @@ describe("AgentSettingsScreen", () => {
"agent-command-input",
)) as HTMLTextAreaElement;
expect(commandInput.value).toBe(
- "npx -y @agentclientprotocol/claude-agent-acp",
+ "npx -y @agentclientprotocol/[email protected]",
);
expect(screen.getByLabelText("SETTINGS$AGENT_MODEL")).toHaveValue(
- "Claude Opus 4.7",
+ "Claude Opus 4.8",
);
await user.click(screen.getByTestId("agent-save-button"));
@@ -422,7 +422,7 @@ describe("AgentSettingsScreen", () => {
// ``acp_args`` can't survive and concatenate onto the spawn
// command at conversation-create time.
acp_args: [],
- acp_model: "claude-opus-4-7",
+ acp_model: "claude-opus-4-8",
});
});
@@ -589,7 +589,7 @@ describe("AgentSettingsScreen", () => {
"agent-command-input",
)) as HTMLTextAreaElement;
expect(cmd.value).toBe(
- "npx -y @agentclientprotocol/claude-agent-acp --extra-arg",
+ "npx -y @agentclientprotocol/[email protected] --extra-arg",
);
// Touch the form to mark it dirty (Save is disabled until isDirty),
@@ -611,7 +611,7 @@ describe("AgentSettingsScreen", () => {
expect(call.agent_settings_diff?.acp_command).toEqual([
"npx",
"-y",
- "@agentclientprotocol/claude-agent-acp",
+ "@agentclientprotocol/[email protected]",
"--extra-arg",
]);
// ``acp_args: []`` resets the API-set args so they don't double up
@@ -783,7 +783,7 @@ describe("AgentSettingsScreen", () => {
schema_version: 1,
agent_kind: "acp",
acp_server: "claude-code",
- acp_command: ["npx", "-y", "@agentclientprotocol/claude-agent-acp"],
+ acp_command: [],
},
}),
);
@@ -822,7 +822,7 @@ describe("AgentSettingsScreen", () => {
schema_version: 1,
agent_kind: "acp",
acp_server: "claude-code",
- acp_command: ["npx", "-y", "@agentclientprotocol/claude-agent-acp"],
+ acp_command: [],
},
}),
);
diff --git a/package-lock.json b/package-lock.json
index e0983542a1..a7722930bf 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -13,7 +13,7 @@
"@microlink/react-json-view": "1.31.20",
"@monaco-editor/react": "4.7.0",
"@openhands/extensions": "0.5.0",
- "@openhands/typescript-client": "1.24.3",
+ "@openhands/typescript-client": "1.25.0",
"@react-router/node": "7.17.0",
"@react-router/serve": "7.17.0",
"@tailwindcss/vite": "4.2.4",
@@ -3482,9 +3482,9 @@
}
},
"node_modules/@openhands/typescript-client": {
- "version": "1.24.3",
- "resolved": "https://registry.npmjs.org/@openhands/typescript-client/-/typescript-client-1.24.3.tgz",
- "integrity": "sha512-4w5rGbgXSnRKm6DZGedGRMWa4nIyl8/1+lEzinBIjZbdE0MD6+89EAItkk6FTvKU0jdVpoCAtmLWBP3Y/r8ORA==",
+ "version": "1.25.0",
+ "resolved": "https://registry.npmjs.org/@openhands/typescript-client/-/typescript-client-1.25.0.tgz",
+ "integrity": "sha512-Xjqg3/aZi+20CYN7ZLzIiH4CqwThFIAvyp8vziu97UDaVIBrZgfXGlSI42/vNh8Dm1y33STMIKfYarMu17n9AQ==",
"dependencies": {
"@openrouter/sdk": "^0.12.35",
"ws": "^8.20.0"
diff --git a/package.json b/package.json
index 3cce306a16..8babcbf31c 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
"@microlink/react-json-view": "1.31.20",
"@monaco-editor/react": "4.7.0",
"@openhands/extensions": "0.5.0",
- "@openhands/typescript-client": "1.24.3",
+ "@openhands/typescript-client": "1.25.0",
"@react-router/node": "7.17.0",
"@react-router/serve": "7.17.0",
"@tailwindcss/vite": "4.2.4",