Skip to content

πŸ™Œ OpenHands: AI-Driven Development

feat: outline the back navigation control on settings sub-pages (#17587)

Denis Ermakov952f83fd7909
diff --git a/__tests__/components/shared/buttons/back-nav-button.test.tsx b/__tests__/components/shared/buttons/back-nav-button.test.tsx
index d260979d1e..c5fb6bc96c 100644
--- a/__tests__/components/shared/buttons/back-nav-button.test.tsx
+++ b/__tests__/components/shared/buttons/back-nav-button.test.tsx
@@ -15,4 +15,17 @@ describe("BackNavButton", () => {
expect(onClick).toHaveBeenCalledTimes(1);
});
+
+ it("outlines the back button so it stays visible before hover", () => {
+ render(
+ <BackNavButton onClick={vi.fn()} testId="back-button">
+ <span />
+ </BackNavButton>,
+ );
+
+ expect(screen.getByTestId("back-button")).toHaveClass(
+ "border",
+ "border-border",
+ );
+ });
});
diff --git a/src/utils/form-control-classes.ts b/src/utils/form-control-classes.ts
index cc7d63a8b3..6138fc74c5 100644
--- a/src/utils/form-control-classes.ts
+++ b/src/utils/form-control-classes.ts
@@ -137,9 +137,12 @@ export const formControlFilterTriggerClassName = cn(
"shrink-0 text-contrast",
);
-/** Muted back navigation control with tertiary hover fill (settings sub-pages, detail views). */
+/** Outlined back navigation control with tertiary hover fill (settings sub-pages, detail views). */
export const formControlBackNavButtonClassName = cn(
- "inline-flex items-center gap-2 self-start rounded-lg p-2",
+ formControlHeightClassName,
+ "inline-flex items-center gap-2 self-start px-2",
+ formControlRadiusClassName,
+ formControlBorderClassName,
"text-sm font-normal leading-5 text-muted cursor-pointer",
formControlTransitionClassName,
"hover:bg-tertiary hover:text-contrast",