π OpenHands: AI-Driven Development
fix (cli): issue 9386 - show settings.json path in /settings (#9481)
ManOwnFire9e72b69cf83a
diff --git a/.gitignore b/.gitignoreindex df48a5095f..c1c3dff5c3 100644--- a/.gitignore+++ b/.gitignore@@ -182,6 +182,8 @@ cython_debug/.roo/rules.cline/rules.windsurf/rules+.repomix+repomix-output.txt# evaluationevaluation/evaluation_outputsdiff --git a/openhands/cli/settings.py b/openhands/cli/settings.pyindex 314797688c..6fb1d6842a 100644--- a/openhands/cli/settings.py+++ b/openhands/cli/settings.py@@ -1,3 +1,5 @@+from pathlib import Path+from prompt_toolkit import PromptSession, print_formatted_textfrom prompt_toolkit.completion import FuzzyWordCompleterfrom prompt_toolkit.formatted_text import HTML@@ -71,6 +73,10 @@ def display_settings(config: OpenHandsConfig) -> None:' Memory Condensation','Enabled' if config.enable_default_condenser else 'Disabled',),+ (+ ' Configuration File',+ str(Path(config.file_store_path) / 'settings.json'),+ ),])diff --git a/tests/unit/test_cli_settings.py b/tests/unit/test_cli_settings.pyindex 8de111fd89..edfd28075b 100644--- a/tests/unit/test_cli_settings.py+++ b/tests/unit/test_cli_settings.py@@ -1,3 +1,4 @@+from pathlib import Pathfrom unittest.mock import AsyncMock, MagicMock, patchimport pytest@@ -37,9 +38,10 @@ class TestDisplaySettings:llm_config.api_key = SecretStr('test-api-key')config.get_llm_config.return_value = llm_configconfig.default_agent = 'test-agent'+ config.file_store_path = '/tmp'# Set up security as a separate mock- security_mock = MagicMock()+ security_mock = MagicMock(spec=OpenHandsConfig)security_mock.confirmation_mode = Trueconfig.security = security_mock@@ -48,13 +50,14 @@ class TestDisplaySettings:@pytest.fixturedef advanced_app_config(self):- config = MagicMock(spec=OpenHandsConfig)+ config = MagicMock()llm_config = MagicMock()llm_config.base_url = 'https://custom-api.com'llm_config.model = 'custom-model'llm_config.api_key = SecretStr('test-api-key')config.get_llm_config.return_value = llm_configconfig.default_agent = 'test-agent'+ config.file_store_path = '/tmp'# Set up security as a separate mocksecurity_mock = MagicMock()@@ -87,6 +90,8 @@ class TestDisplaySettings:assert 'Enabled' in settings_textassert 'Memory Condensation:' in settings_textassert 'Enabled' in settings_text+ assert 'Configuration File' in settings_text+ assert str(Path(app_config.file_store_path)) in settings_text@patch('openhands.cli.settings.print_container')def test_display_settings_advanced_config(