Skip to content

πŸ™Œ OpenHands: AI-Driven Development

extract WorkspaceModeIcon and GotItButton chat sub-components (#1400)

Hiep Lea20b0301930b
diff --git a/__tests__/components/features/chat/workspace-mode-selector.test.tsx b/__tests__/components/features/chat/workspace-mode-selector.test.tsx
new file mode 100644
index 0000000000..a32bc90a67
--- /dev/null
+++ b/__tests__/components/features/chat/workspace-mode-selector.test.tsx
@@ -0,0 +1,24 @@
+import { render, screen, fireEvent } from "@testing-library/react";
+import { describe, it, expect, vi } from "vitest";
+import { WorkspaceModeSelector } from "#/components/features/chat/workspace-mode-selector";
+
+describe("WorkspaceModeSelector", () => {
+ it("opens the menu and calls onChange when an option is selected", () => {
+ const onChange = vi.fn();
+ render(
+ <WorkspaceModeSelector
+ value="local_repo"
+ backendKind="local"
+ onChange={onChange}
+ />,
+ );
+
+ // Open the menu (trigger renders the active mode via WorkspaceModeIcon).
+ fireEvent.click(screen.getByTestId("workspace-mode-selector"));
+ fireEvent.click(
+ screen.getByTestId("workspace-mode-selector-option-new_worktree"),
+ );
+
+ expect(onChange).toHaveBeenCalledWith("new_worktree");
+ });
+});
diff --git a/src/components/features/chat/btw-messages.tsx b/src/components/features/chat/btw-messages.tsx
index fc6d8c89aa..6a5f6272eb 100644
--- a/src/components/features/chat/btw-messages.tsx
+++ b/src/components/features/chat/btw-messages.tsx
@@ -1,22 +1,8 @@
import { useTranslation } from "react-i18next";
-import CheckCircle from "#/icons/check-circle-solid.svg?react";
import { I18nKey } from "#/i18n/declaration";
import { useBtwStore } from "#/stores/btw-store";
import { GenericEventMessage } from "./generic-event-message";
-
-function GotItButton({ onClick }: { onClick: () => void }) {
- const { t } = useTranslation("openhands");
- return (
- <button
- type="button"
- onClick={onClick}
- className="flex items-center gap-1.5 px-3 py-1 rounded-full text-xs font-normal text-success bg-success/10 hover:bg-success/20 border border-success/30 transition-colors"
- >
- <CheckCircle className="w-3.5 h-3.5 fill-success" />
- <span>{t(I18nKey.CHAT_INTERFACE$BTW_GOT_IT)}</span>
- </button>
- );
-}
+import { GotItButton } from "./got-it-button";
export interface BtwMessagesProps {
conversationId: string | null | undefined;
diff --git a/src/components/features/chat/got-it-button.tsx b/src/components/features/chat/got-it-button.tsx
new file mode 100644
index 0000000000..524ab6f1e6
--- /dev/null
+++ b/src/components/features/chat/got-it-button.tsx
@@ -0,0 +1,17 @@
+import { useTranslation } from "react-i18next";
+import CheckCircle from "#/icons/check-circle-solid.svg?react";
+import { I18nKey } from "#/i18n/declaration";
+
+export function GotItButton({ onClick }: { onClick: () => void }) {
+ const { t } = useTranslation("openhands");
+ return (
+ <button
+ type="button"
+ onClick={onClick}
+ className="flex items-center gap-1.5 px-3 py-1 rounded-full text-xs font-normal text-success bg-success/10 hover:bg-success/20 border border-success/30 transition-colors"
+ >
+ <CheckCircle className="w-3.5 h-3.5 fill-success" />
+ <span>{t(I18nKey.CHAT_INTERFACE$BTW_GOT_IT)}</span>
+ </button>
+ );
+}
diff --git a/src/components/features/chat/workspace-mode-icon.tsx b/src/components/features/chat/workspace-mode-icon.tsx
new file mode 100644
index 0000000000..56bc9bc2f4
--- /dev/null
+++ b/src/components/features/chat/workspace-mode-icon.tsx
@@ -0,0 +1,11 @@
+import { GitBranch } from "lucide-react";
+import type { WorkspaceMode } from "#/api/conversation-metadata-store";
+import RepoForkedIcon from "#/icons/repo-forked.svg?react";
+
+export function WorkspaceModeIcon({ mode }: { mode: WorkspaceMode }) {
+ if (mode === "new_worktree") {
+ return <GitBranch className="size-3" strokeWidth={2} aria-hidden />;
+ }
+
+ return <RepoForkedIcon width={12} height={12} color="white" aria-hidden />;
+}
diff --git a/src/components/features/chat/workspace-mode-selector.tsx b/src/components/features/chat/workspace-mode-selector.tsx
index d6aa4120a8..694ccf1cc2 100644
--- a/src/components/features/chat/workspace-mode-selector.tsx
+++ b/src/components/features/chat/workspace-mode-selector.tsx
@@ -1,6 +1,6 @@
import { useEffect, useRef, useState } from "react";
import { useTranslation } from "react-i18next";
-import { ChevronDown, GitBranch } from "lucide-react";
+import { ChevronDown } from "lucide-react";
import type { BackendKind } from "#/api/backend-registry/types";
import type { WorkspaceMode } from "#/api/conversation-metadata-store";
import { getWorkspaceModeI18nKey } from "#/utils/workspace-mode";
@@ -10,7 +10,7 @@ import {
dropdownMenuRowClassName,
dropdownMenuRowIconWrapperClassName,
} from "#/utils/dropdown-classes";
-import RepoForkedIcon from "#/icons/repo-forked.svg?react";
+import { WorkspaceModeIcon } from "./workspace-mode-icon";
interface WorkspaceModeSelectorProps {
value: WorkspaceMode;
@@ -22,14 +22,6 @@ interface WorkspaceModeSelectorProps {
const WORKSPACE_MODE_OPTIONS: WorkspaceMode[] = ["local_repo", "new_worktree"];
-function WorkspaceModeIcon({ mode }: { mode: WorkspaceMode }) {
- if (mode === "new_worktree") {
- return <GitBranch className="size-3" strokeWidth={2} aria-hidden />;
- }
-
- return <RepoForkedIcon width={12} height={12} color="white" aria-hidden />;
-}
-
export function WorkspaceModeSelector({
value,
backendKind,