Skip to content

πŸ™Œ OpenHands: AI-Driven Development

feat: auto-enable 'Run on first message' when the first router is created (#17840)

Juan Pedro Michelini Jorgea6bba78ffd5a
diff --git a/__tests__/components/settings/meta-llm-profiles/meta-llm-settings-view.test.tsx b/__tests__/components/settings/meta-llm-profiles/meta-llm-settings-view.test.tsx
index 2be93b087a..92eae65577 100644
--- a/__tests__/components/settings/meta-llm-profiles/meta-llm-settings-view.test.tsx
+++ b/__tests__/components/settings/meta-llm-profiles/meta-llm-settings-view.test.tsx
@@ -21,6 +21,10 @@ import {
DEFAULT_ROUTER_FLASH_META_PROFILE_NAME,
} from "#/components/features/settings/meta-llm-profiles/default-meta-profile";
import { collectRequiredRouterModelNames } from "#/components/features/settings/meta-llm-profiles/router-profiles";
+import {
+ displayErrorToast,
+ displaySuccessToast,
+} from "#/utils/custom-toast-handlers";
vi.mock("#/hooks/query/use-meta-profiles");
vi.mock("#/hooks/query/use-llm-profiles");
@@ -32,7 +36,10 @@ vi.mock("#/hooks/query/use-settings");
vi.mock("#/hooks/mutation/use-save-settings");
vi.mock("#/api/meta-profiles-service/meta-profiles-service.api");
vi.mock("#/api/profiles-service/profiles-service.api");
-vi.mock("#/utils/custom-toast-handlers");
+vi.mock("#/utils/custom-toast-handlers", () => ({
+ displayErrorToast: vi.fn(),
+ displaySuccessToast: vi.fn(),
+}));
const mockMetaProfiles = [
{
@@ -68,7 +75,9 @@ const mockProviderConnections = [
function mockMutation<T>(mutateAsync: Mock, overrides: Partial<T> = {}): T {
return {
mutateAsync,
- mutate: vi.fn(),
+ // Component code uses `mutate` (fire-and-forget) for settings saves, so
+ // route it through the same mock as `mutateAsync` to stay observable.
+ mutate: mutateAsync,
isPending: false,
isError: false,
isSuccess: false,
@@ -84,6 +93,7 @@ function mockMutation<T>(mutateAsync: Mock, overrides: Partial<T> = {}): T {
describe("MetaLlmSettingsView", () => {
const activateMutateAsync = vi.fn();
const saveMutateAsync = vi.fn();
+ const saveSettingsMutate = vi.fn();
beforeEach(() => {
vi.clearAllMocks();
@@ -129,7 +139,7 @@ describe("MetaLlmSettingsView", () => {
error: null,
} as never);
vi.mocked(useSaveSettingsHook.useSaveSettings).mockReturnValue(
- mockMutation(vi.fn()),
+ mockMutation(saveSettingsMutate),
);
vi.mocked(ProfilesService.getProfile).mockResolvedValue({
name: "minimax",
@@ -372,6 +382,113 @@ describe("MetaLlmSettingsView", () => {
);
});
+ it("auto-enables 'Run on first message' when the first router is created", async () => {
+ const user = userEvent.setup();
+ vi.mocked(useMetaProfilesHook.useMetaProfiles).mockReturnValue({
+ data: { meta_profiles: [], active_meta_profile: null },
+ isLoading: false,
+ error: null,
+ } as unknown as ReturnType<typeof useMetaProfilesHook.useMetaProfiles>);
+ saveMutateAsync.mockResolvedValue({ name: "pareto" });
+ activateMutateAsync.mockResolvedValue({ name: "pareto" });
+ renderWithProviders(<MetaLlmSettingsView />);
+
+ await openRouterProTemplate(user);
+ await user.clear(screen.getByTestId("meta-profile-name-input"));
+ await user.type(screen.getByTestId("meta-profile-name-input"), "pareto");
+ fireEvent.change(screen.getByTestId("meta-profile-classifier-input"), {
+ target: { value: "minimax" },
+ });
+ fireEvent.change(screen.getByTestId("meta-profile-prompt-template"), {
+ target: { value: "Task:\n{{ instance_text }}" },
+ });
+ fireEvent.change(screen.getByTestId("meta-profile-model-table"), {
+ target: { value: "" },
+ });
+ await user.click(screen.getByTestId("meta-profile-save"));
+
+ await waitFor(() =>
+ expect(saveSettingsMutate).toHaveBeenCalledWith({
+ run_router_at_conversation_start: true,
+ }),
+ );
+ });
+
+ it("does not touch 'Run on first message' when creating a router while others exist", async () => {
+ const user = userEvent.setup();
+ // A router already exists (and is active), so this is not a 0 β†’ 1 create.
+ vi.mocked(useMetaProfilesHook.useMetaProfiles).mockReturnValue({
+ data: { meta_profiles: mockMetaProfiles, active_meta_profile: "balanced" },
+ isLoading: false,
+ error: null,
+ } as unknown as ReturnType<typeof useMetaProfilesHook.useMetaProfiles>);
+ saveMutateAsync.mockResolvedValue({ name: "pareto" });
+ renderWithProviders(<MetaLlmSettingsView />);
+
+ await openRouterProTemplate(user);
+ await user.clear(screen.getByTestId("meta-profile-name-input"));
+ await user.type(screen.getByTestId("meta-profile-name-input"), "pareto");
+ fireEvent.change(screen.getByTestId("meta-profile-classifier-input"), {
+ target: { value: "minimax" },
+ });
+ fireEvent.change(screen.getByTestId("meta-profile-prompt-template"), {
+ target: { value: "Task:\n{{ instance_text }}" },
+ });
+ fireEvent.change(screen.getByTestId("meta-profile-model-table"), {
+ target: { value: "" },
+ });
+ await user.click(screen.getByTestId("meta-profile-save"));
+
+ await waitFor(() => expect(saveMutateAsync).toHaveBeenCalled());
+ expect(saveSettingsMutate).not.toHaveBeenCalled();
+ });
+
+ it("surfaces a failed auto-enable write without aborting router creation", async () => {
+ const user = userEvent.setup();
+ vi.mocked(useMetaProfilesHook.useMetaProfiles).mockReturnValue({
+ data: { meta_profiles: [], active_meta_profile: null },
+ isLoading: false,
+ error: null,
+ } as unknown as ReturnType<typeof useMetaProfilesHook.useMetaProfiles>);
+ saveMutateAsync.mockResolvedValue({ name: "pareto" });
+ activateMutateAsync.mockResolvedValue({ name: "pareto" });
+ // The auto-enable preference write fails.
+ saveSettingsMutate.mockRejectedValueOnce(new Error("network"));
+ renderWithProviders(<MetaLlmSettingsView />);
+
+ await openRouterProTemplate(user);
+ await user.clear(screen.getByTestId("meta-profile-name-input"));
+ await user.type(screen.getByTestId("meta-profile-name-input"), "pareto");
+ fireEvent.change(screen.getByTestId("meta-profile-classifier-input"), {
+ target: { value: "minimax" },
+ });
+ fireEvent.change(screen.getByTestId("meta-profile-prompt-template"), {
+ target: { value: "Task:\n{{ instance_text }}" },
+ });
+ fireEvent.change(screen.getByTestId("meta-profile-model-table"), {
+ target: { value: "" },
+ });
+ await user.click(screen.getByTestId("meta-profile-save"));
+
+ // The preference write was attempted...
+ await waitFor(() =>
+ expect(saveSettingsMutate).toHaveBeenCalledWith({
+ run_router_at_conversation_start: true,
+ }),
+ );
+ // ...its failure is surfaced...
+ await waitFor(() =>
+ expect(vi.mocked(displayErrorToast)).toHaveBeenCalled(),
+ );
+ // ...and the primary create/activate flow still completes.
+ await waitFor(() =>
+ expect(activateMutateAsync).toHaveBeenCalledWith("pareto"),
+ );
+ // The success toast is suppressed on this path so the user sees a single
+ // unambiguous error rather than a success and an error for one action.
+ expect(vi.mocked(displaySuccessToast)).not.toHaveBeenCalled();
+ });
+
it("does not auto-activate a newly-created meta-profile when one is already active", async () => {
const user = userEvent.setup();
saveMutateAsync.mockResolvedValue({ name: "pareto" });
diff --git a/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx b/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx
index baf9d77d66..f7242ca321 100644
--- a/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx
+++ b/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx
@@ -61,7 +61,8 @@ export function MetaLlmSettingsView() {
const saveLlmProfile = useSaveLlmProfile();
const activateMetaProfile = useActivateMetaProfile();
const { data: settings } = useSettings();
- const { mutate: saveSettings } = useSaveSettings();
+ const { mutate: saveSettings, mutateAsync: saveSettingsAsync } =
+ useSaveSettings();
const [view, setView] = useState<ViewMode>("list");
const [editing, setEditing] = useState<EditingMetaProfile | null>(null);
@@ -203,16 +204,40 @@ export function MetaLlmSettingsView() {
providerConnectionId: string | null,
) => {
const shouldActivateAfterCreate = view === "create" && active === null;
+ // Creating the first router (0 β†’ 1) is the moment "Run on first message"
+ // becomes useful, so flip it on by default β€” but only if the user hasn't
+ // already enabled it. Subsequent router creations leave the preference
+ // untouched.
+ const isFirstRouter = view === "create" && metaProfiles.length === 0;
+ let autoEnableFailed = false;
try {
if (view === "create" && providerConnectionId) {
setIsCreatingRouterProfiles(true);
await createMissingRouterLlmProfiles(config, providerConnectionId);
}
await saveMetaProfile.mutateAsync({ name, config });
+ if (isFirstRouter && !settings?.run_router_at_conversation_start) {
+ // Await the preference write so we observe its outcome: on success
+ // `useSaveSettings`'s onSuccess invalidates the settings cache and the
+ // switch flips on (matching the server); on failure we surface an
+ // error but keep the router creation intact, and the switch stays off
+ // to match the unchanged server value. This must not abort the primary
+ // create/activate flow, so it has its own try/catch. The success toast
+ // is suppressed on this path so the user isn't shown both a success
+ // and an error for one action.
+ try {
+ await saveSettingsAsync({ run_router_at_conversation_start: true });
+ } catch {
+ autoEnableFailed = true;
+ displayErrorToast(t(I18nKey.ERROR$GENERIC));
+ }
+ }
if (shouldActivateAfterCreate) {
await activateMetaProfile.mutateAsync(name);
}
- displaySuccessToast(t(I18nKey.SETTINGS$META_PROFILE_SAVED, { name }));
+ if (!autoEnableFailed) {
+ displaySuccessToast(t(I18nKey.SETTINGS$META_PROFILE_SAVED, { name }));
+ }
setView("list");
setEditing(null);
setCreateInitial(null);