Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(i18n): use i18next placeholders in budget usage format (#16903)

Pranshul Soniab916bcdacef
diff --git a/__tests__/components/features/conversation-panel/budget-usage-text.test.tsx b/__tests__/components/features/conversation-panel/budget-usage-text.test.tsx
new file mode 100644
index 0000000000..56f0e33390
--- /dev/null
+++ b/__tests__/components/features/conversation-panel/budget-usage-text.test.tsx
@@ -0,0 +1,54 @@
+import { describe, expect, it } from "vitest";
+import i18next from "i18next";
+import { translationResources } from "#/i18n/resources";
+
+const FORMAT = translationResources.en.CONVERSATION$BUDGET_USAGE_FORMAT;
+
+// The exact parameters BudgetUsageText passes to t() (see
+// src/components/features/conversation-panel/budget-usage-text.tsx).
+const CONSUMER_PARAMS = {
+ currentCost: "$0.1234",
+ maxBudget: "$5.0000",
+ usagePercentage: "2.47",
+ used: translationResources.en.CONVERSATION$USED,
+};
+
+describe("CONVERSATION$BUDGET_USAGE_FORMAT", () => {
+ it("uses i18next placeholder syntax in the en locale string", () => {
+ // Regression guard for #16873: the key must use {{param}} placeholders so
+ // i18next substitutes values instead of printing the literal template.
+ expect(FORMAT).toBe(
+ "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ );
+ expect(FORMAT).not.toContain("${");
+ });
+
+ it("interpolates every named parameter the consumer passes", () => {
+ for (const param of Object.keys(CONSUMER_PARAMS)) {
+ expect(FORMAT).toContain(`{{${param}}}`);
+ }
+ });
+
+ it("renders a fully substituted usage line with i18next", () => {
+ // Drive a real i18next instance with the actual en resource to prove the
+ // template interpolates end-to-end (the app's interpolation config matches:
+ // default delimiters, escapeValue false).
+ const instance = i18next.createInstance();
+ instance.init({
+ lng: "en",
+ resources: { en: { openhands: translationResources.en } },
+ ns: ["openhands"],
+ defaultNS: "openhands",
+ interpolation: { escapeValue: false },
+ });
+
+ const rendered = instance.t(
+ "CONVERSATION$BUDGET_USAGE_FORMAT",
+ CONSUMER_PARAMS,
+ ) as string;
+
+ expect(rendered).toBe("$0.1234 / $5.0000 (2.47% used)");
+ expect(rendered).not.toContain("${");
+ expect(rendered).not.toContain("{{");
+ });
+});
diff --git a/src/i18n/translation.json b/src/i18n/translation.json
index 7eb5dd7a15..582179af75 100644
--- a/src/i18n/translation.json
+++ b/src/i18n/translation.json
@@ -22476,21 +22476,21 @@
"ca": "Claus d'API d'OpenHands"
},
"CONVERSATION$BUDGET_USAGE_FORMAT": {
- "en": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "ja": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "zh-CN": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "zh-TW": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "ko-KR": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "no": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "it": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "pt": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "es": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "ar": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "fr": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "tr": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "de": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "uk": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})",
- "ca": "${currentCost} / ${maxBudget} ({usagePercentage}% {used})"
+ "en": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "ja": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "zh-CN": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "zh-TW": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "ko-KR": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "no": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "it": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "pt": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "es": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "ar": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "fr": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "tr": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "de": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "uk": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})",
+ "ca": "{{currentCost}} / {{maxBudget}} ({{usagePercentage}}% {{used}})"
},
"CONVERSATION$CACHE_HIT": {
"en": "Cache Hit",