Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(settings): show the server's reason when an LLM profile save fails (#18549)

Engel Nystb0caa7ccef83
diff --git a/.pr/llmwindow/after-server-reason-1.png b/.pr/llmwindow/after-server-reason-1.png
new file mode 100644
index 0000000000..eeb93763dc
Binary files /dev/null and b/.pr/llmwindow/after-server-reason-1.png differ
diff --git a/.pr/llmwindow/after-server-reason-2.png b/.pr/llmwindow/after-server-reason-2.png
new file mode 100644
index 0000000000..d214c5227c
Binary files /dev/null and b/.pr/llmwindow/after-server-reason-2.png differ
diff --git a/.pr/llmwindow/before-generic-toast.png b/.pr/llmwindow/before-generic-toast.png
new file mode 100644
index 0000000000..1c837fbaad
Binary files /dev/null and b/.pr/llmwindow/before-generic-toast.png differ
diff --git a/__tests__/components/settings/llm-profiles/llm-settings-local-view.test.tsx b/__tests__/components/settings/llm-profiles/llm-settings-local-view.test.tsx
index bd2b523393..404ba9ae34 100644
--- a/__tests__/components/settings/llm-profiles/llm-settings-local-view.test.tsx
+++ b/__tests__/components/settings/llm-profiles/llm-settings-local-view.test.tsx
@@ -1,6 +1,7 @@
/* eslint-disable i18next/no-literal-string -- test mocks intentionally use literal labels */
import { describe, expect, it, vi, beforeEach, type Mock } from "vitest";
import { AxiosError } from "axios";
+import { HttpError } from "@openhands/typescript-client";
import { fireEvent, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { renderWithProviders } from "test-utils";
@@ -144,6 +145,10 @@ vi.mock("#/hooks/query/use-llm-profiles");
vi.mock("#/hooks/mutation/use-activate-llm-profile");
vi.mock("#/hooks/mutation/use-save-llm-profile");
vi.mock("#/api/profiles-service/profiles-service.api");
+vi.mock("#/utils/custom-toast-handlers", () => ({
+ displaySuccessToast: vi.fn(),
+ displayErrorToast: vi.fn(),
+}));
const mockProfiles = [
{
@@ -1128,6 +1133,47 @@ describe("LlmSettingsLocalView", () => {
expect(savedLlm.model).toBe("anthropic/claude-opus-4-5-20251101");
expect(savedLlm.api_key).toBe("gAAAA_encrypted_key");
});
+
+ it("shows the Agent Server's reason when the save is refused with a 500", async () => {
+ // Arrange β€” the Agent Server refuses a too-small max_input_tokens with a
+ // 500 whose `detail` is generic and whose reason is under `exception`;
+ // the shared client throws it as an HttpError.
+ const user = userEvent.setup();
+ const { displayErrorToast } =
+ await import("#/utils/custom-toast-handlers");
+ const reason =
+ "The configured model has a context window of 16,000 tokens, which is below the minimum of 16,384 tokens required for OpenHands to function properly.";
+ vi.mocked(ProfilesService.validateProfile).mockResolvedValue(null);
+ mockSaveMutateAsync.mockRejectedValueOnce(
+ new HttpError(
+ 500,
+ "Internal Server Error",
+ { detail: "Internal Server Error", exception: reason },
+ `HTTP request failed (500 Internal Server Error): {"detail":"Internal Server Error"}`,
+ ),
+ );
+ renderWithProviders(<LlmSettingsLocalView />);
+
+ // Act β€” edit a field on the All tab and save.
+ await user.click(screen.getAllByTestId("profile-menu-trigger")[0]);
+ await user.click(screen.getByTestId("profile-edit"));
+ await user.click(await screen.findByTestId("sdk-section-all-toggle"));
+ const temperatureInput = await screen.findByTestId(
+ "sdk-settings-llm.temperature",
+ );
+ await user.clear(temperatureInput);
+ await user.type(temperatureInput, "0.7");
+ await waitFor(() => {
+ expect(screen.getByTestId("save-profile-btn")).not.toBeDisabled();
+ });
+ await user.click(screen.getByTestId("save-profile-btn"));
+
+ // Assert β€” the toast carries the server's reason and the editor stays open.
+ await waitFor(() => {
+ expect(displayErrorToast).toHaveBeenCalledWith(reason);
+ });
+ expect(screen.getByTestId("save-profile-btn")).toBeInTheDocument();
+ });
});
});
diff --git a/src/components/features/settings/llm-profiles/llm-settings-local-view.tsx b/src/components/features/settings/llm-profiles/llm-settings-local-view.tsx
index c0a562a5b3..f43526044d 100644
--- a/src/components/features/settings/llm-profiles/llm-settings-local-view.tsx
+++ b/src/components/features/settings/llm-profiles/llm-settings-local-view.tsx
@@ -32,6 +32,7 @@ import {
displaySuccessToast,
} from "#/utils/custom-toast-handlers";
import { I18nKey } from "#/i18n/declaration";
+import { getApiErrorMessage } from "#/utils/api-error-message";
import {
deriveProfileNameFromModel,
isProfileNameValid,
@@ -420,7 +421,7 @@ export function LlmSettingsLocalView() {
handleBackToList();
} catch (error) {
console.error("Failed to save profile:", error);
- displayErrorToast(t(I18nKey.ERROR$GENERIC));
+ displayErrorToast(getApiErrorMessage(error, t(I18nKey.ERROR$GENERIC)));
} finally {
setIsValidating(false);
setIsSaving(false);