Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix: detect Dockerfile language from directory-qualified paths (#17152)

Jabrailb26f270ebf17
diff --git a/__tests__/utils/get-language-from-path.test.ts b/__tests__/utils/get-language-from-path.test.ts
index 1f4187ad9f..a2edfaec29 100644
--- a/__tests__/utils/get-language-from-path.test.ts
+++ b/__tests__/utils/get-language-from-path.test.ts
@@ -33,4 +33,25 @@ describe("getLanguageFromPath", () => {
])("maps %s to %s", (path, language) => {
expect(getLanguageFromPath(path)).toBe(language);
});
+
+ it.each([
+ "Dockerfile",
+ "deploy/Dockerfile",
+ "/workspace/project/Dockerfile",
+ "/workspace/project.v2/DOCKERFILE",
+ "C:\\workspace\\project\\Dockerfile",
+ ])("recognizes the Dockerfile basename in %s", (path) => {
+ expect(getLanguageFromPath(path)).toBe("dockerfile");
+ });
+
+ it.each([
+ ["src.v2/app.test.TSX", "typescript"],
+ ["C:\\project.v2\\src\\app.py", "python"],
+ ["deploy/build.dockerfile", "dockerfile"],
+ ["deploy/Dockerfile.bak", "text"],
+ ["deploy/Dockerfile/config.json", "json"],
+ ["/workspace/project.ts/README", "text"],
+ ])("uses the final filename to classify %s", (path, language) => {
+ expect(getLanguageFromPath(path)).toBe(language);
+ });
});
diff --git a/docs/pr-screenshots/dockerfile-language-after.jpg b/docs/pr-screenshots/dockerfile-language-after.jpg
new file mode 100644
index 0000000000..503defaaec
Binary files /dev/null and b/docs/pr-screenshots/dockerfile-language-after.jpg differ
diff --git a/docs/pr-screenshots/dockerfile-language-before.jpg b/docs/pr-screenshots/dockerfile-language-before.jpg
new file mode 100644
index 0000000000..3d5d7c5917
Binary files /dev/null and b/docs/pr-screenshots/dockerfile-language-before.jpg differ
diff --git a/src/utils/get-language-from-path.ts b/src/utils/get-language-from-path.ts
index 5d5b3c7163..ea4ca8eb6a 100644
--- a/src/utils/get-language-from-path.ts
+++ b/src/utils/get-language-from-path.ts
@@ -1,5 +1,9 @@
export const getLanguageFromPath = (path: string): string => {
- const extension = path.split(".").pop()?.toLowerCase();
+ const filename = path.split(/[\\/]/).pop();
+ if (filename?.toLowerCase() === "dockerfile") {
+ return "dockerfile";
+ }
+ const extension = filename?.split(".").pop()?.toLowerCase();
switch (extension) {
case "js":
case "jsx":