Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix: keep panel resize drag working over Files iframes (#729)

Neha Prasadb519dd0013e0
diff --git a/__tests__/hooks/use-resizable-panels.test.ts b/__tests__/hooks/use-resizable-panels.test.ts
index a0112d7e9e..505e16e1cc 100644
--- a/__tests__/hooks/use-resizable-panels.test.ts
+++ b/__tests__/hooks/use-resizable-panels.test.ts
@@ -1,4 +1,5 @@
-import { renderHook } from "@testing-library/react";
+import { act, renderHook } from "@testing-library/react";
+import type { MouseEvent as ReactMouseEvent } from "react";
import { describe, it, expect, beforeEach } from "vitest";
import { useResizablePanels } from "#/hooks/use-resizable-panels";
@@ -55,4 +56,33 @@ describe("useResizablePanels", () => {
expect(result.current.leftWidth).toBe(60);
expect(result.current.rightWidth).toBe(40);
});
+
+ it("mounts a full-viewport drag shield while dragging so iframe-heavy panes do not steal pointer events", () => {
+ const { result } = renderHook(() =>
+ useResizablePanels({
+ defaultLeftWidth: 50,
+ minLeftWidth: 30,
+ maxLeftWidth: 80,
+ storageKey: "test-panel-width",
+ }),
+ );
+
+ expect(document.querySelector("[data-panel-drag-shield]")).toBeNull();
+
+ act(() => {
+ result.current.handleMouseDown({
+ preventDefault: () => {},
+ } as unknown as ReactMouseEvent<HTMLDivElement>);
+ });
+
+ const shield = document.querySelector("[data-panel-drag-shield]");
+ expect(shield).not.toBeNull();
+ expect(shield).toBeInstanceOf(HTMLDivElement);
+
+ act(() => {
+ document.dispatchEvent(new MouseEvent("mouseup"));
+ });
+
+ expect(document.querySelector("[data-panel-drag-shield]")).toBeNull();
+ });
});
diff --git a/src/hooks/use-resizable-panels.ts b/src/hooks/use-resizable-panels.ts
index 0c11923e2d..56d0f891c2 100644
--- a/src/hooks/use-resizable-panels.ts
+++ b/src/hooks/use-resizable-panels.ts
@@ -1,6 +1,9 @@
-import { useState, useRef, useCallback, useEffect } from "react";
+import { useState, useRef, useCallback, useLayoutEffect } from "react";
import { useLocalStorage } from "@uidotdev/usehooks";
+/** Full-screen layer above iframes so parent `document` keeps receiving drag events. */
+const PANEL_DRAG_SHIELD_Z_INDEX = 200;
+
interface UseResizablePanelsOptions {
defaultLeftWidth?: number;
minLeftWidth?: number;
@@ -57,21 +60,31 @@ export function useResizablePanels({
}
}, [isDragging, leftWidth, setPersistedWidth]);
- useEffect(() => {
- if (isDragging) {
- document.addEventListener("mousemove", handleMouseMove);
- document.addEventListener("mouseup", handleMouseUp);
- document.body.style.cursor = "ew-resize";
- document.body.style.userSelect = "none";
- }
+ useLayoutEffect(() => {
+ if (!isDragging) return;
+
+ const shield = document.createElement("div");
+ shield.setAttribute("aria-hidden", "true");
+ shield.dataset.panelDragShield = "";
+ Object.assign(shield.style, {
+ position: "fixed",
+ inset: "0",
+ zIndex: String(PANEL_DRAG_SHIELD_Z_INDEX),
+ cursor: "ew-resize",
+ });
+ document.body.appendChild(shield);
+
+ document.addEventListener("mousemove", handleMouseMove);
+ document.addEventListener("mouseup", handleMouseUp);
+ document.body.style.cursor = "ew-resize";
+ document.body.style.userSelect = "none";
return () => {
- if (isDragging) {
- document.removeEventListener("mousemove", handleMouseMove);
- document.removeEventListener("mouseup", handleMouseUp);
- document.body.style.cursor = "";
- document.body.style.userSelect = "";
- }
+ document.removeEventListener("mousemove", handleMouseMove);
+ document.removeEventListener("mouseup", handleMouseUp);
+ document.body.style.cursor = "";
+ document.body.style.userSelect = "";
+ shield.remove();
};
}, [isDragging, handleMouseMove, handleMouseUp]);