π OpenHands: AI-Driven Development
fix: crash when request.client is None in InMemoryRateLimiter (#15119)
rakshith1928b526578e8d0e
diff --git a/openhands/app_server/middleware.py b/openhands/app_server/middleware.pyindex 2ff6d325cc..1d521fde84 100644--- a/openhands/app_server/middleware.py+++ b/openhands/app_server/middleware.py@@ -93,7 +93,7 @@ class InMemoryRateLimiter:self.history[key] = [ts for ts in self.history[key] if ts > cutoff]async def __call__(self, request: Request) -> bool:- key = request.client.host+ key = request.client.host if request.client else 'unknown'now = datetime.now()self._clean_old_requests(key)diff --git a/tests/unit/server/test_middleware.py b/tests/unit/server/test_middleware.pyindex 69c297fbe2..22b9a34500 100644--- a/tests/unit/server/test_middleware.py+++ b/tests/unit/server/test_middleware.py@@ -4,6 +4,7 @@ import pytestfrom fastapi import FastAPIfrom fastapi.testclient import TestClientfrom starlette.middleware.cors import CORSMiddleware+from starlette.requests import Requestfrom openhands.app_server.middleware import (InMemoryRateLimiter,@@ -190,3 +191,11 @@ def test_rate_limit_middleware_exempts_sandbox_resume():assert rate_limited_response.status_code == 429assert resume_response.status_code == 200assert resume_response.json() == {'sandbox_id': 'sandbox-123'}+++async def test_in_memory_rate_limiter_client_none():+ """Test that InMemoryRateLimiter handles a request with client=None."""+ request = Request({'type': 'http', 'client': None})+ rate_limiter = InMemoryRateLimiter()+ result = await rate_limiter(request)+ assert result is True