π OpenHands: AI-Driven Development
Hotfix: rm max condenser size override (#11713)
Rohit Malhotrab605c96796cd
diff --git a/enterprise/experiments/experiment_manager.py b/enterprise/experiments/experiment_manager.pyindex 7c53f27414..1c212a0391 100644--- a/enterprise/experiments/experiment_manager.py+++ b/enterprise/experiments/experiment_manager.py@@ -5,12 +5,8 @@ from experiments.constants import (EXPERIMENT_SYSTEM_PROMPT_EXPERIMENT,)from experiments.experiment_versions import (- handle_condenser_max_step_experiment,handle_system_prompt_experiment,)-from experiments.experiment_versions._004_condenser_max_step_experiment import (- handle_condenser_max_step_experiment__v1,-)from openhands.core.config.openhands_config import OpenHandsConfigfrom openhands.core.logger import openhands_logger as logger@@ -31,10 +27,6 @@ class SaaSExperimentManager(ExperimentManager):)return agent- agent = handle_condenser_max_step_experiment__v1(- user_id, conversation_id, agent- )-if EXPERIMENT_SYSTEM_PROMPT_EXPERIMENT:agent = agent.model_copy(update={'system_prompt_filename': 'system_prompt_long_horizon.j2'}@@ -60,20 +52,7 @@ class SaaSExperimentManager(ExperimentManager):"""logger.debug('experiment_manager:run_conversation_variant_test:started',- extra={'user_id': user_id},- )-- # Skip all experiment processing if the experiment manager is disabled- if not ENABLE_EXPERIMENT_MANAGER:- logger.info(- 'experiment_manager:run_conversation_variant_test:skipped',- extra={'reason': 'experiment_manager_disabled'},- )- return conversation_settings-- # Apply conversation-scoped experiments- conversation_settings = handle_condenser_max_step_experiment(- user_id, conversation_id, conversation_settings+ extra={'user_id': user_id, 'conversation_id': conversation_id},)return conversation_settingsdiff --git a/enterprise/tests/unit/experiments/test_saas_experiment_manager.py b/enterprise/tests/unit/experiments/test_saas_experiment_manager.pyindex ec67c7479f..4f1eab2a92 100644--- a/enterprise/tests/unit/experiments/test_saas_experiment_manager.py+++ b/enterprise/tests/unit/experiments/test_saas_experiment_manager.py@@ -92,11 +92,8 @@ def test_unknown_variant_returns_original_agent_without_changes(monkeypatch):assert getattr(result, 'condenser', None) is None-@patch('experiments.experiment_manager.handle_condenser_max_step_experiment__v1')@patch('experiments.experiment_manager.ENABLE_EXPERIMENT_MANAGER', False)-def test_run_agent_variant_tests_v1_noop_when_manager_disabled(- mock_handle_condenser,-):+def test_run_agent_variant_tests_v1_noop_when_manager_disabled():"""If ENABLE_EXPERIMENT_MANAGER is False, the method returns the exact same agent and does not call the handler."""agent = make_agent()conv_id = uuid4()@@ -109,8 +106,6 @@ def test_run_agent_variant_tests_v1_noop_when_manager_disabled(# Same object returned (no copy)assert result is agent- # Handler should not have been called- mock_handle_condenser.assert_not_called()@patch('experiments.experiment_manager.ENABLE_EXPERIMENT_MANAGER', True)@@ -131,7 +126,3 @@ def test_run_agent_variant_tests_v1_calls_handler_and_sets_system_prompt(monkeyp# Should be a different instance than the original (copied after handler runs)assert result is not agentassert result.system_prompt_filename == 'system_prompt_long_horizon.j2'-- # The condenser returned by the handler must be preserved after the system-prompt override copy- assert isinstance(result.condenser, LLMSummarizingCondenser)- assert result.condenser.max_size == 80