π OpenHands: AI-Driven Development
fix(frontend): treat managed openhands base URLs as provider defaults in view inference (#14783)
Alonab658182957a2
diff --git a/frontend/__tests__/routes/llm-settings.test.tsx b/frontend/__tests__/routes/llm-settings.test.tsxindex c8af568cab..8558dc0779 100644--- a/frontend/__tests__/routes/llm-settings.test.tsx+++ b/frontend/__tests__/routes/llm-settings.test.tsx@@ -396,7 +396,60 @@ describe("LlmSettingsScreen", () => {).not.toBeInTheDocument();});- it("opens advanced view when an OpenHands model has a custom base URL", async () => {+ it("opens basic view when an OpenHands managed model has a server-filled base URL", async () => {+ // Managed openhands/* profiles always come back with a base_url β the+ // backend fills it with the managed LiteLLM endpoint on save. That must+ // not be mistaken for a user customization that opens advanced/all.+ vi.spyOn(SettingsService, "getSettings").mockResolvedValue(+ buildSettingsWithAdvancedToggle({+ llm_model: "openhands/claude-opus-4-5-20251101",+ llm_base_url: "http://openhands-litellm:4000",+ agent_settings: {+ llm: {+ model: "openhands/claude-opus-4-5-20251101",+ base_url: "http://openhands-litellm:4000",+ },+ },+ }),+ );++ await renderLlmSettingsScreen({ appMode: "oss" });++ await screen.findByTestId("llm-settings-form-basic");+ expect(+ screen.queryByTestId("llm-settings-form-advanced"),+ ).not.toBeInTheDocument();+ });++ it("opens basic view when editing an org-scope OpenHands managed profile with a server-filled base URL", async () => {+ // Org scope is not covered by the personal-SaaS first-mount-basic rule,+ // so this exercises the base-URL inference path directly.+ vi.spyOn(organizationService, "getOrganizationSettings").mockResolvedValue(+ buildSettingsWithAdvancedToggle({+ llm_model: "openhands/claude-opus-4-5-20251101",+ llm_base_url: "http://openhands-litellm:4000",+ agent_settings: {+ llm: {+ model: "openhands/claude-opus-4-5-20251101",+ base_url: "http://openhands-litellm:4000",+ },+ },+ }),+ );++ await renderLlmSettingsScreen({ appMode: "saas", scope: "org" });++ await screen.findByTestId("llm-settings-form-basic");+ expect(+ screen.queryByTestId("llm-settings-form-advanced"),+ ).not.toBeInTheDocument();+ });++ it("opens basic view even when an OpenHands model has a non-managed base URL", async () => {+ // Accepted edge case: the server owns base_url for openhands/* models,+ // so editing always starts on basic β even if the stored URL was set+ // deliberately in advanced mode. The value is preserved and the+ // advanced view remains one click away.vi.spyOn(SettingsService, "getSettings").mockResolvedValue(buildSettingsWithAdvancedToggle({llm_model: "openhands/claude-opus-4-5-20251101",@@ -412,10 +465,10 @@ describe("LlmSettingsScreen", () => {await renderLlmSettingsScreen({ appMode: "oss" });- await screen.findByTestId("llm-settings-form-advanced");- expect(screen.getByTestId("base-url-input")).toHaveValue(- "https://custom.example/v1",- );+ await screen.findByTestId("llm-settings-form-basic");+ expect(+ screen.queryByTestId("llm-settings-form-advanced"),+ ).not.toBeInTheDocument();});it("treats a litellm_proxy model with the managed proxy URL as an explicit custom endpoint", async () => {@@ -1360,10 +1413,14 @@ describe("LlmSettingsScreen", () => {});it("keeps an existing custom base URL when saving basic view without a model change", async () => {+ // Use a non-managed model: openhands/* models treat any base_url as+ // server-owned, which would keep this scenario from opening advanced.let persistedSettings = buildSettingsWithAdvancedToggle({+ llm_model: "openai/gpt-4o",llm_base_url: "https://stale.example/v1",agent_settings: {llm: {+ model: "openai/gpt-4o",base_url: "https://stale.example/v1",},},diff --git a/frontend/src/routes/llm-settings.tsx b/frontend/src/routes/llm-settings.tsxindex 1fb94d6b1b..ad0aac2f3f 100644--- a/frontend/src/routes/llm-settings.tsx+++ b/frontend/src/routes/llm-settings.tsx@@ -78,6 +78,14 @@ const normalizeBaseUrl = (baseUrl: string) => {};const isProviderDefaultBaseUrl = (model: string, baseUrl: string) => {+ // For openhands/* models, base_url is server-owned (auto-filled on save) β+ // never treat it as user customization that warrants the advanced view.+ // Accepted edge case: a deliberately customized base_url on an openhands/*+ // model also lands on basic; values are preserved, Advanced is a click away.+ if (model.startsWith("openhands/")) {+ return true;+ }+const normalizedBaseUrl = normalizeBaseUrl(baseUrl);const { provider } = extractModelAndProvider(model);