π OpenHands: AI-Driven Development
Always enable logout button regardless of GitHub connection status (#8529)
Robert Brennanb8d3027cfe8e
diff --git a/frontend/__tests__/components/context-menu/account-settings-context-menu.test.tsx b/frontend/__tests__/components/context-menu/account-settings-context-menu.test.tsxindex 00ac105322..8f80a1b238 100644--- a/frontend/__tests__/components/context-menu/account-settings-context-menu.test.tsx+++ b/frontend/__tests__/components/context-menu/account-settings-context-menu.test.tsx@@ -20,7 +20,6 @@ describe("AccountSettingsContextMenu", () => {<AccountSettingsContextMenuonLogout={onLogoutMock}onClose={onCloseMock}- isLoggedIn/>,);@@ -35,7 +34,6 @@ describe("AccountSettingsContextMenu", () => {<AccountSettingsContextMenuonLogout={onLogoutMock}onClose={onCloseMock}- isLoggedIn/>,);@@ -45,19 +43,18 @@ describe("AccountSettingsContextMenu", () => {expect(onLogoutMock).toHaveBeenCalledOnce();});- test("onLogout should be disabled if the user is not logged in", async () => {+ test("logout button is always enabled", async () => {render(<AccountSettingsContextMenuonLogout={onLogoutMock}onClose={onCloseMock}- isLoggedIn={false}/>,);const logoutOption = screen.getByText("ACCOUNT_SETTINGS$LOGOUT");await user.click(logoutOption);- expect(onLogoutMock).not.toHaveBeenCalled();+ expect(onLogoutMock).toHaveBeenCalledOnce();});it("should call onClose when clicking outside of the element", async () => {@@ -65,7 +62,6 @@ describe("AccountSettingsContextMenu", () => {<AccountSettingsContextMenuonLogout={onLogoutMock}onClose={onCloseMock}- isLoggedIn/>,);diff --git a/frontend/__tests__/components/user-actions.test.tsx b/frontend/__tests__/components/user-actions.test.tsxindex 3ce7e308d5..3d37f42acb 100644--- a/frontend/__tests__/components/user-actions.test.tsx+++ b/frontend/__tests__/components/user-actions.test.tsx@@ -57,7 +57,7 @@ describe("UserActions", () => {).not.toBeInTheDocument();});- test("onLogout should not be called when the user is not logged in", async () => {+ test("logout button is always enabled", async () => {render(<UserActions onLogout={onLogoutMock} />);const userAvatar = screen.getByTestId("user-avatar");@@ -66,6 +66,6 @@ describe("UserActions", () => {const logoutOption = screen.getByText("ACCOUNT_SETTINGS$LOGOUT");await user.click(logoutOption);- expect(onLogoutMock).not.toHaveBeenCalled();+ expect(onLogoutMock).toHaveBeenCalledOnce();});});diff --git a/frontend/__tests__/i18n/translations.test.tsx b/frontend/__tests__/i18n/translations.test.tsxindex 01a0bebffe..a19d263f74 100644--- a/frontend/__tests__/i18n/translations.test.tsx+++ b/frontend/__tests__/i18n/translations.test.tsx@@ -11,7 +11,6 @@ describe("Translations", () => {<AccountSettingsContextMenuonLogout={() => {}}onClose={() => {}}- isLoggedIn/>,);expect(diff --git a/frontend/src/components/features/context-menu/account-settings-context-menu.tsx b/frontend/src/components/features/context-menu/account-settings-context-menu.tsxindex f524119a61..71829ef903 100644--- a/frontend/src/components/features/context-menu/account-settings-context-menu.tsx+++ b/frontend/src/components/features/context-menu/account-settings-context-menu.tsx@@ -7,13 +7,11 @@ import { I18nKey } from "#/i18n/declaration";interface AccountSettingsContextMenuProps {onLogout: () => void;onClose: () => void;- isLoggedIn: boolean;}export function AccountSettingsContextMenu({onLogout,onClose,- isLoggedIn,}: AccountSettingsContextMenuProps) {const ref = useClickOutsideElement<HTMLUListElement>(onClose);const { t } = useTranslation();@@ -24,7 +22,7 @@ export function AccountSettingsContextMenu({ref={ref}className="absolute right-full md:left-full -top-1 z-10 w-fit">- <ContextMenuListItem onClick={onLogout} isDisabled={!isLoggedIn}>+ <ContextMenuListItem onClick={onLogout}>{t(I18nKey.ACCOUNT_SETTINGS$LOGOUT)}</ContextMenuListItem></ContextMenu>diff --git a/frontend/src/components/features/sidebar/user-actions.tsx b/frontend/src/components/features/sidebar/user-actions.tsxindex b34544d36a..ed35e5f21e 100644--- a/frontend/src/components/features/sidebar/user-actions.tsx+++ b/frontend/src/components/features/sidebar/user-actions.tsx@@ -35,7 +35,6 @@ export function UserActions({ onLogout, user, isLoading }: UserActionsProps) {{accountContextMenuIsVisible && (<AccountSettingsContextMenu- isLoggedIn={!!user}onLogout={handleLogout}onClose={closeAccountMenu}/>