π OpenHands: AI-Driven Development
fix(config-api): show 'openhands' provider first in providers list (#14297)
Juan Micheliniba6b072d708e
diff --git a/openhands/app_server/config_api/default_llm_model_service.py b/openhands/app_server/config_api/default_llm_model_service.pyindex 1bf22bc4b6..ef90317605 100644--- a/openhands/app_server/config_api/default_llm_model_service.py+++ b/openhands/app_server/config_api/default_llm_model_service.py@@ -61,7 +61,9 @@ def _to_llm_models(models_response: ModelsResponse) -> list[LLMModel]:def _to_providers(models_response: ModelsResponse) -> list[Provider]:- """Extract unique providers, sorted verified-first then alphabetically."""+ """Extract unique providers, sorted with ``openhands`` first, then other+ verified providers alphabetically, then unverified providers alphabetically.+ """verified_set = set(models_response.verified_providers)seen: set[str] = set()providers: list[Provider] = []@@ -73,7 +75,10 @@ def _to_providers(models_response: ModelsResponse) -> list[Provider]:if name not in seen:seen.add(name)providers.append(Provider(name=name, verified=name in verified_set))- providers.sort(key=lambda p: (not p.verified, p.name))+ # ``openhands`` is the managed provider and should always appear first,+ # followed by other verified providers (alphabetical), then unverified+ # providers (alphabetical).+ providers.sort(key=lambda p: (not p.verified, p.name != 'openhands', p.name))return providersdiff --git a/tests/unit/app_server/test_config_router.py b/tests/unit/app_server/test_config_router.pyindex 5ce4e48101..4a4672269f 100644--- a/tests/unit/app_server/test_config_router.py+++ b/tests/unit/app_server/test_config_router.py@@ -125,6 +125,14 @@ class TestToProviders:if found_unverified and p.verified:pytest.fail('Verified provider found after unverified provider')+ def test_openhands_provider_appears_first(self):+ """The ``openhands`` managed provider must always be first in the list."""+ providers = _to_providers(get_supported_llm_models())++ assert providers, 'expected at least one provider'+ assert providers[0].name == 'openhands'+ assert providers[0].verified is True+def test_contains_verified_and_unverified(self):providers = _to_providers(get_supported_llm_models())