Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(telemetry): never initialize PostHog under Do Not Track (#18086)

Engel Nystbaf1cbef090f
diff --git a/__tests__/services/telemetry.test.ts b/__tests__/services/telemetry.test.ts
index 814536328f..7db2229f39 100644
--- a/__tests__/services/telemetry.test.ts
+++ b/__tests__/services/telemetry.test.ts
@@ -515,6 +515,25 @@ describe("Telemetry Service", () => {
});
});
+ describe("build-time do-not-track", () => {
+ afterEach(() => {
+ vi.unstubAllEnvs();
+ });
+
+ it("never initializes PostHog, even when the provider asks", async () => {
+ vi.stubEnv("VITE_DO_NOT_TRACK", "1");
+ vi.resetModules();
+ const telemetry = await import("#/services/telemetry");
+
+ await expect(telemetry.initializePostHogClient()).resolves.toBeNull();
+ await telemetry.trackInstall();
+ await telemetry.setTelemetryConsent("granted");
+
+ expect(telemetry.getTelemetryConsent()).toBe("denied");
+ expect(mockPosthog.init).not.toHaveBeenCalled();
+ });
+ });
+
describe("getTelemetryDistinctId", () => {
it("returns null when consent is not granted", async () => {
await expect(getTelemetryDistinctId()).resolves.toBeNull();
diff --git a/src/services/telemetry.ts b/src/services/telemetry.ts
index d026e225db..6085ff843f 100644
--- a/src/services/telemetry.ts
+++ b/src/services/telemetry.ts
@@ -27,8 +27,9 @@
* - Injecting window.__AGENT_CANVAS_DO_NOT_TRACK__ = true at runtime, which the
* static server does from AGENT_CANVAS_DISABLE_TELEMETRY=1 (or the equivalent
* --disable-telemetry flag) so a precompiled bundle can opt out without
- * VITE_DO_NOT_TRACK baked into the image. Under this flag the PostHog client
- * is never initialized, so consent mirrored from a backend cannot opt it in.
+ * VITE_DO_NOT_TRACK baked into the image.
+ * Under any of these the PostHog client is never initialized, so it makes no
+ * network requests and consent mirrored from a backend cannot opt it in.
*/
import type { BootstrapConfig, CaptureResult, PostHog } from "posthog-js";
@@ -308,7 +309,9 @@ export function configureTelemetry(config: TelemetryConfiguration): void {
}
function getResolvedTelemetryConfig(): Required<TelemetryConfig> | null {
- if (isTelemetryHardDisabled()) return null;
+ // Do Not Track pins consent to "denied", so a client could never capture;
+ // initializing one anyway would still fetch remote config and flags.
+ if (isDoNotTrackEnabled()) return null;
return {
apiKey: telemetryConfig.apiKey || DEFAULT_POSTHOG_API_KEY,