π OpenHands: AI-Driven Development
docs: refresh AGENTS.md guidance (#16310)
OpenHands Botc146a9e75a94
diff --git a/AGENTS.md b/AGENTS.mdindex 1255f08445..acf56028a7 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -350,7 +350,8 @@ Ensure each test is meaningful, concise, and covers a unique aspect of user inte- Direct `dependencies` and `devDependencies` in `package.json` are exact-pinned (no caret ranges); reproducible installs should use the committed `package-lock.json` plus `npm ci`, and targeted transitive fixes still belong in `overrides`.- Current `overrides` in `package.json` and the advisories they address (keep this list in sync when adding/removing overrides):- `@vercel/static-config > ajv: 8.20.0` β **GHSA-2g4f-4pwh-qvx6** (ReDoS in ajv's `$data` option, affects 7.0.0-alpha.0β8.17.1, reaches us through `@vercel/react-router` β `@vercel/static-config` β `[email protected]`). The override is intentionally **scoped** to `@vercel/static-config`: a top-level `ajv` override forces ajv 8.x everywhere and breaks ESLint's `@eslint/eslintrc`, which requires ajv ^6.x (incompatible API). Scoping lets ESLint keep its nested `[email protected]` while only the vulnerable consumer is bumped.- - `dompurify: 3.4.7` β **GHSA-39q2-94rc-95cp** and related XSS bypasses (affects `dompurify <= 3.3.3`).+ - `dompurify: 3.4.12` β keeps Monaco's exact-pinned `[email protected]` on a patched release for **GHSA-39q2-94rc-95cp** and related XSS bypasses.+ - `typed-rest-client > qs: 6.15.3` β overrides the vulnerable `[email protected]` exact-pinned by every published `typed-rest-client` release in the `@stryker-mutator/core` dependency tree.- When bumping pinned versions, use npm to update `package.json` and `package-lock.json` together; do not hand-edit only one of them.- `npm test` now runs `npm run make-i18n` first so clean environments generate `src/i18n/declaration.ts` before Vitest loads aliased imports.- `__tests__/vite-config.test.ts` should import `vite.config` directly under `// @vitest-environment node`; spawning plain `node -e 'import ./vite.config.ts'` is not portable across Node patch releases in CI.@@ -643,7 +644,7 @@ When adding code that needs a new string, decide up front which rule it falls un- `ManageWorkspacesModal` should require a confirmation step before removing either a saved workspace or a workspace parent; parent removals should mention the child-workspace impact, and tests should assert both the confirmation flow and that removing the selected workspace clears the launch selection.- In `useWorkspacesStore`, keep `clearWorkspaces()` scoped to literal workspaces only; use explicit helpers like `clearWorkspaceParents()` / `clearAll()` for broader resets so future callers do not accidentally wipe parent registrations.-- Default LLM model β `DEFAULT_SETTINGS.llm_model` (`"openhands/minimax-m2.7"`, defined in `src/services/settings.ts`) is the canonical frontend default. `buildConfiguredOpenHandsAgentSettings` in `src/api/agent-server-adapter.ts` **always** sends this value explicitly when the resolved `llm.model` is absent, empty, or whitespace-only β the frontend never relies on the agent-server SDK's own default (`gpt-5.5`). If you change the default model, update `DEFAULT_SETTINGS.llm_model` in `src/services/settings.ts` **and** the checklist in `specs/llm-defaults.md`. Spec: `@spec LLD-001`.+- Default LLM model β `DEFAULT_SETTINGS.llm_model` (`"openhands/glm-5.2"`, defined in `src/services/settings.ts`) is the canonical frontend default. `buildConfiguredOpenHandsAgentSettings` in `src/api/agent-server-adapter.ts` **always** sends this value explicitly when the resolved `llm.model` is absent, empty, or whitespace-only β the frontend never relies on the agent-server SDK's own default (`gpt-5.5`). If you change the default model, update `DEFAULT_SETTINGS.llm_model` in `src/services/settings.ts` **and** the checklist in `specs/llm-defaults.md`. Spec: `@spec LLD-001`.- Custom secrets are NOT auto-attached by the agent-server. `POST /api/conversations` only persists what the client sends in `request.secrets`; the persisted secrets store (`/api/settings/secrets`) is never read at conversation start. `buildStartConversationRequestWithEncryptedSettings` enumerates `SecretsService.getSecrets()` and turns each entry into a `LookupSecret` whose `url` points back at `/api/settings/secrets/{name}` and whose `headers` carry `X-Session-API-Key` for auth.