π OpenHands: AI-Driven Development
Fix failing unit test on main (#7909)
Rohit Malhotrac2e1babd762e
diff --git a/tests/unit/test_agent_controller.py b/tests/unit/test_agent_controller.pyindex 67c870c7bd..23c8792738 100644--- a/tests/unit/test_agent_controller.py+++ b/tests/unit/test_agent_controller.py@@ -877,7 +877,7 @@ async def test_context_window_exceeded_error_handling(async def test_run_controller_with_context_window_exceeded_with_truncation(mock_agent, mock_runtime, mock_memory, test_event_stream):- """Tests that the controller can make progress after handling context window exceeded errors, as long as enable_history_truncation is ON"""+ """Tests that the controller can make progress after handling context window exceeded errors, as long as enable_history_truncation is ON."""class StepState:def __init__(self):@@ -1236,6 +1236,12 @@ async def test_condenser_metrics_included():# Attach the condenser to the agentagent.condenser = condenser+ # Mock the system message to avoid ID issues+ system_message = SystemMessageAction(content='Test system message')+ system_message._source = EventSource.AGENT+ system_message._id = -1+ agent.get_system_message.return_value = system_message+# Mock agent step to return a CondensationActionaction = CondensationAction(forgotten_events_start_id=1,@@ -1296,10 +1302,10 @@ async def test_condenser_metrics_included():@pytest.mark.asyncioasync def test_first_user_message_with_identical_content(test_event_stream, mock_agent):- """- Test that _first_user_message correctly identifies the first user message- even when multiple messages have identical content but different IDs.- Also verifies that the result is properly cached.+ """Test that _first_user_message correctly identifies the first user message.++ This test verifies that messages with identical content but different IDs are properly+ distinguished, and that the result is correctly cached.The issue we're checking is that the comparison (action == self._first_user_message())should correctly differentiate between messages with the same content but different IDs.diff --git a/tests/unit/test_memory.py b/tests/unit/test_memory.pyindex 94010057b4..1c5776c621 100644--- a/tests/unit/test_memory.py+++ b/tests/unit/test_memory.py@@ -11,7 +11,7 @@ from openhands.core.config import AppConfigfrom openhands.core.main import run_controllerfrom openhands.core.schema.agent import AgentStatefrom openhands.events.action.agent import RecallAction-from openhands.events.action.message import MessageAction+from openhands.events.action.message import MessageAction, SystemMessageActionfrom openhands.events.event import EventSourcefrom openhands.events.observation.agent import (RecallObservation,@@ -67,8 +67,6 @@ def mock_agent():agent.llm.config = AppConfig().get_llm_config()# Add a proper system message mock- from openhands.events.action.message import SystemMessageAction-system_message = SystemMessageAction(content='Test system message')system_message._source = EventSource.AGENTsystem_message._id = -1 # Set invalid ID to avoid the ID check@@ -78,7 +76,6 @@ def mock_agent():@pytest.mark.asyncioasync def test_memory_on_event_exception_handling(memory, event_stream, mock_agent):"""Test that exceptions in Memory.on_event are properly handled via status callback."""-# Create a mock runtimeruntime = MagicMock(spec=Runtime)runtime.event_stream = event_stream@@ -108,7 +105,6 @@ async def test_memory_on_workspace_context_recall_exception_handling(memory, event_stream, mock_agent):"""Test that exceptions in Memory._on_workspace_context_recall are properly handled via status callback."""-# Create a mock runtimeruntime = MagicMock(spec=Runtime)runtime.event_stream = event_stream@@ -270,9 +266,7 @@ REPOSITORY INSTRUCTIONS: This is a test repository.@pytest.mark.asyncioasync def test_memory_with_agent_microagents():- """- Test that Memory processes microagent based on trigger words from agent messages.- """+ """Test that Memory processes microagent based on trigger words from agent messages."""# Create a mock event streamevent_stream = MagicMock(spec=EventStream)