π OpenHands: AI-Driven Development
refactor: extract ConversationMobilePanelPage from conversation-main (#1376)
Hiep Led09346f8efdb
diff --git a/__tests__/components/features/conversation/conversation-mobile-panel-page.test.tsx b/__tests__/components/features/conversation/conversation-mobile-panel-page.test.tsxnew file mode 100644index 0000000000..b5220b2ab0--- /dev/null+++ b/__tests__/components/features/conversation/conversation-mobile-panel-page.test.tsx@@ -0,0 +1,32 @@+import { render, screen, fireEvent } from "@testing-library/react";+import { describe, it, expect, vi } from "vitest";+import { useConversationStore } from "#/stores/conversation-store";++// Stub the heavy tab subtree so the test focuses on this page's own behavior.+vi.mock(+ "#/components/features/conversation/conversation-tabs/conversation-tabs",+ () => ({ ConversationTabs: () => <div data-testid="conversation-tabs" /> }),+);+vi.mock(+ "#/components/features/conversation/conversation-tabs/conversation-tab-content/conversation-tab-content",+ () => ({ ConversationTabContent: () => <div data-testid="tab-content" /> }),+);++import { ConversationMobilePanelPage } from "#/components/features/conversation/conversation-main/conversation-mobile-panel-page";++describe("ConversationMobilePanelPage", () => {+ it("opens the right panel on mount", () => {+ render(<ConversationMobilePanelPage onNavigateBack={vi.fn()} />);++ expect(useConversationStore.getState().isRightPanelShown).toBe(true);+ });++ it("calls onNavigateBack when the back button is clicked", () => {+ const onNavigateBack = vi.fn();+ render(<ConversationMobilePanelPage onNavigateBack={onNavigateBack} />);++ fireEvent.click(screen.getByTestId("conversation-mobile-panel-back"));++ expect(onNavigateBack).toHaveBeenCalledTimes(1);+ });+});diff --git a/__tests__/routes/conversation-backend-switch.test.tsx b/__tests__/routes/conversation-backend-switch.test.tsxindex e9b385293d..331ffba72b 100644--- a/__tests__/routes/conversation-backend-switch.test.tsx+++ b/__tests__/routes/conversation-backend-switch.test.tsx@@ -30,6 +30,11 @@ vi.mock("#/components/features/conversation/conversation-main/conversation-main",() => ({ConversationMain: () => <div data-testid="conversation-main" />,+ }),+);+vi.mock(+ "#/components/features/conversation/conversation-main/conversation-mobile-panel-page",+ () => ({ConversationMobilePanelPage: () => <div data-testid="conversation-panel" />,}),);diff --git a/src/components/features/conversation/conversation-main/conversation-main.tsx b/src/components/features/conversation/conversation-main/conversation-main.tsxindex 889daa13d7..d3fb189351 100644--- a/src/components/features/conversation/conversation-main/conversation-main.tsx+++ b/src/components/features/conversation/conversation-main/conversation-main.tsx@@ -1,12 +1,4 @@-import React from "react";-import { ChevronLeft } from "lucide-react";-import { useTranslation } from "react-i18next";-import { I18nKey } from "#/i18n/declaration";import { cn } from "#/utils/utils";-import {- mobileTopBarIconButtonClassName,- mobileTopBarIconClassName,-} from "#/utils/mobile-top-bar-icon-button-classes";import { ChatInterfaceWrapper } from "./chat-interface-wrapper";import { ConversationTabContent } from "../conversation-tabs/conversation-tab-content/conversation-tab-content";import { ConversationNameWithStatus } from "../conversation-name-with-status";@@ -133,65 +125,3 @@ export function ConversationMain() {</div>);}--export function ConversationMobilePanelPage({- onNavigateBack,-}: {- onNavigateBack: () => void;-}) {- const { t } = useTranslation("openhands");- const { setIsRightPanelShown, setHasRightPanelToggled, setSelectedTab } =- useConversationStore();-- React.useLayoutEffect(() => {- setIsRightPanelShown(true);- setHasRightPanelToggled(true);- const st = useConversationStore.getState();- if (!st.selectedTab) {- setSelectedTab("files");- }- return () => {- setIsRightPanelShown(false);- setHasRightPanelToggled(false);- };- }, [setIsRightPanelShown, setHasRightPanelToggled, setSelectedTab]);-- const handleBack = () => {- onNavigateBack();- };-- return (- <div className="flex h-full min-h-0 flex-col bg-[var(--oh-surface)]">- <div- data-testid="conversation-mobile-panel-top"- className="flex h-10 min-h-10 shrink-0 items-center gap-1.5 border-b border-[var(--oh-border)] pl-2.5"- >- <button- type="button"- data-testid="conversation-mobile-panel-back"- onClick={handleBack}- aria-label={t(I18nKey.COMMON$BACK)}- className={mobileTopBarIconButtonClassName}- >- <ChevronLeft- size={20}- className={mobileTopBarIconClassName}- aria-hidden- strokeWidth={2}- />- </button>- <div className="flex min-h-0 min-w-0 flex-1 items-center self-stretch">- <div- data-testid="tabs-pane-header"- className="flex h-full min-h-0 w-full min-w-0 flex-col justify-center"- >- <ConversationTabs variant="compact" />- </div>- </div>- </div>- <div className="flex min-h-0 flex-1 flex-col bg-[var(--oh-surface)]">- <ConversationTabContent />- </div>- </div>- );-}diff --git a/src/components/features/conversation/conversation-main/conversation-mobile-panel-page.tsx b/src/components/features/conversation/conversation-main/conversation-mobile-panel-page.tsxnew file mode 100644index 0000000000..e13705ed97--- /dev/null+++ b/src/components/features/conversation/conversation-main/conversation-mobile-panel-page.tsx@@ -0,0 +1,73 @@+import React from "react";+import { ChevronLeft } from "lucide-react";+import { useTranslation } from "react-i18next";+import { I18nKey } from "#/i18n/declaration";+import {+ mobileTopBarIconButtonClassName,+ mobileTopBarIconClassName,+} from "#/utils/mobile-top-bar-icon-button-classes";+import { useConversationStore } from "#/stores/conversation-store";+import { ConversationTabContent } from "../conversation-tabs/conversation-tab-content/conversation-tab-content";+import { ConversationTabs } from "../conversation-tabs/conversation-tabs";++export function ConversationMobilePanelPage({+ onNavigateBack,+}: {+ onNavigateBack: () => void;+}) {+ const { t } = useTranslation("openhands");+ const { setIsRightPanelShown, setHasRightPanelToggled, setSelectedTab } =+ useConversationStore();++ React.useLayoutEffect(() => {+ setIsRightPanelShown(true);+ setHasRightPanelToggled(true);+ const st = useConversationStore.getState();+ if (!st.selectedTab) {+ setSelectedTab("files");+ }+ return () => {+ setIsRightPanelShown(false);+ setHasRightPanelToggled(false);+ };+ }, [setIsRightPanelShown, setHasRightPanelToggled, setSelectedTab]);++ const handleBack = () => {+ onNavigateBack();+ };++ return (+ <div className="flex h-full min-h-0 flex-col bg-[var(--oh-surface)]">+ <div+ data-testid="conversation-mobile-panel-top"+ className="flex h-10 min-h-10 shrink-0 items-center gap-1.5 border-b border-[var(--oh-border)] pl-2.5"+ >+ <button+ type="button"+ data-testid="conversation-mobile-panel-back"+ onClick={handleBack}+ aria-label={t(I18nKey.COMMON$BACK)}+ className={mobileTopBarIconButtonClassName}+ >+ <ChevronLeft+ size={20}+ className={mobileTopBarIconClassName}+ aria-hidden+ strokeWidth={2}+ />+ </button>+ <div className="flex min-h-0 min-w-0 flex-1 items-center self-stretch">+ <div+ data-testid="tabs-pane-header"+ className="flex h-full min-h-0 w-full min-w-0 flex-col justify-center"+ >+ <ConversationTabs variant="compact" />+ </div>+ </div>+ </div>+ <div className="flex min-h-0 flex-1 flex-col bg-[var(--oh-surface)]">+ <ConversationTabContent />+ </div>+ </div>+ );+}diff --git a/src/routes/conversation.tsx b/src/routes/conversation.tsxindex 9aa4115c4f..ed0a150999 100644--- a/src/routes/conversation.tsx+++ b/src/routes/conversation.tsx@@ -21,10 +21,8 @@ import { useTaskPolling } from "#/hooks/query/use-task-polling";import { displayErrorToast } from "#/utils/custom-toast-handlers";import { useIsAuthed } from "#/hooks/query/use-is-authed";-import {- ConversationMain,- ConversationMobilePanelPage,-} from "#/components/features/conversation/conversation-main/conversation-main";+import { ConversationMain } from "#/components/features/conversation/conversation-main/conversation-main";+import { ConversationMobilePanelPage } from "#/components/features/conversation/conversation-main/conversation-mobile-panel-page";import { WebSocketProviderWrapper } from "#/contexts/websocket-provider-wrapper";import { useErrorMessageStore } from "#/stores/error-message-store";