Skip to content

πŸ™Œ OpenHands: AI-Driven Development

refactor(frontend): migration of event-message-slice.ts to zustand (#11080)

Hiep Ledf1c5bbf85b9
diff --git a/frontend/src/components/shared/buttons/confirmation-buttons.tsx b/frontend/src/components/shared/buttons/confirmation-buttons.tsx
index 5c9e2612de..5fe7daec60 100644
--- a/frontend/src/components/shared/buttons/confirmation-buttons.tsx
+++ b/frontend/src/components/shared/buttons/confirmation-buttons.tsx
@@ -1,4 +1,3 @@
-import { useDispatch, useSelector } from "react-redux";
import { useCallback, useEffect } from "react";
import { useTranslation } from "react-i18next";
import { I18nKey } from "#/i18n/declaration";
@@ -10,15 +9,15 @@ import { isOpenHandsAction } from "#/types/core/guards";
import { ActionSecurityRisk } from "#/stores/security-analyzer-store";
import { RiskAlert } from "#/components/shared/risk-alert";
import WarningIcon from "#/icons/u-warning.svg?react";
-import { RootState } from "#/store";
-import { addSubmittedEventId } from "#/state/event-message-slice";
+import { useEventMessageStore } from "#/stores/event-message-store";
export function ConfirmationButtons() {
- const submittedEventIds = useSelector(
- (state: RootState) => state.eventMessage.submittedEventIds,
+ const submittedEventIds = useEventMessageStore(
+ (state) => state.submittedEventIds,
+ );
+ const addSubmittedEventId = useEventMessageStore(
+ (state) => state.addSubmittedEventId,
);
-
- const dispatch = useDispatch();
const { t } = useTranslation();
@@ -40,10 +39,10 @@ export function ConfirmationButtons() {
return;
}
- dispatch(addSubmittedEventId(awaitingAction.id));
+ addSubmittedEventId(awaitingAction.id);
send(generateAgentStateChangeEvent(state));
},
- [send],
+ [send, addSubmittedEventId],
);
// Handle keyboard shortcuts
diff --git a/frontend/src/state/event-message-slice.tsx b/frontend/src/state/event-message-slice.tsx
deleted file mode 100644
index 086ca0a876..0000000000
--- a/frontend/src/state/event-message-slice.tsx
+++ /dev/null
@@ -1,23 +0,0 @@
-import { createSlice } from "@reduxjs/toolkit";
-
-export const eventMessageSlice = createSlice({
- name: "eventMessage",
- initialState: {
- submittedEventIds: [] as number[], // Avoid the flashing issue of the confirmation buttons
- },
- reducers: {
- addSubmittedEventId: (state, action) => {
- state.submittedEventIds.push(action.payload);
- },
- removeSubmittedEventId: (state, action) => {
- state.submittedEventIds = state.submittedEventIds.filter(
- (id) => id !== action.payload,
- );
- },
- },
-});
-
-export const { addSubmittedEventId, removeSubmittedEventId } =
- eventMessageSlice.actions;
-
-export default eventMessageSlice.reducer;
diff --git a/frontend/src/store.ts b/frontend/src/store.ts
index 37723a5e8f..30e1bca9d9 100644
--- a/frontend/src/store.ts
+++ b/frontend/src/store.ts
@@ -2,13 +2,11 @@ import { combineReducers, configureStore } from "@reduxjs/toolkit";
import agentReducer from "./state/agent-slice";
import { jupyterReducer } from "./state/jupyter-slice";
import microagentManagementReducer from "./state/microagent-management-slice";
-import eventMessageReducer from "./state/event-message-slice";
export const rootReducer = combineReducers({
agent: agentReducer,
jupyter: jupyterReducer,
microagentManagement: microagentManagementReducer,
- eventMessage: eventMessageReducer,
});
const store = configureStore({
diff --git a/frontend/src/stores/event-message-store.ts b/frontend/src/stores/event-message-store.ts
new file mode 100644
index 0000000000..09315b7e5e
--- /dev/null
+++ b/frontend/src/stores/event-message-store.ts
@@ -0,0 +1,24 @@
+import { create } from "zustand";
+
+interface EventMessageState {
+ submittedEventIds: number[]; // Avoid the flashing issue of the confirmation buttons
+}
+
+interface EventMessageStore extends EventMessageState {
+ addSubmittedEventId: (id: number) => void;
+ removeSubmittedEventId: (id: number) => void;
+}
+
+export const useEventMessageStore = create<EventMessageStore>((set) => ({
+ submittedEventIds: [],
+ addSubmittedEventId: (id: number) =>
+ set((state) => ({
+ submittedEventIds: [...state.submittedEventIds, id],
+ })),
+ removeSubmittedEventId: (id: number) =>
+ set((state) => ({
+ submittedEventIds: state.submittedEventIds.filter(
+ (eventId) => eventId !== id,
+ ),
+ })),
+}));