π OpenHands: AI-Driven Development
test(snapshot): onboarding modal steps + sidebar new-conversation popover (#449)
Rohit Malhotrae20fd0c1052f
diff --git a/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-0-choose-agent.png b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-0-choose-agent.pngnew file mode 100644index 0000000000..43916f54deBinary files /dev/null and b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-0-choose-agent.png differdiff --git a/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-1-check-backend.png b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-1-check-backend.pngnew file mode 100644index 0000000000..e19a4dd311Binary files /dev/null and b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-1-check-backend.png differdiff --git a/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-2-setup-llm.png b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-2-setup-llm.pngnew file mode 100644index 0000000000..b08ea821baBinary files /dev/null and b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-2-setup-llm.png differdiff --git a/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-3-say-hello.png b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-3-say-hello.pngnew file mode 100644index 0000000000..2e3ef1ae5dBinary files /dev/null and b/tests/e2e/__snapshots__/snapshots/onboarding.snapshot.spec.ts/chromium/onboarding-step-3-say-hello.png differdiff --git a/tests/e2e/snapshots/onboarding.snapshot.spec.ts b/tests/e2e/snapshots/onboarding.snapshot.spec.tsnew file mode 100644index 0000000000..762ef2e20c--- /dev/null+++ b/tests/e2e/snapshots/onboarding.snapshot.spec.ts@@ -0,0 +1,177 @@+import { test, expect, Page } from "@playwright/test";++/**+ * Visual snapshot tests for the 4-step onboarding modal.+ *+ * The modal is shown automatically on first visit when the+ * `openhands-onboarded` key is absent from localStorage.+ * It lives on the home route (`routes/home.tsx` β `OnboardingHost`).+ *+ * Steps:+ * 0. Choose agent β agent cards; OpenHands selected, others "coming soon"+ * 1. Check backend β backend form + connection status banner+ * 2. Setup LLM β LLM settings form (pre-filled with Anthropic/Claude Opus)+ * 3. Say hello β pre-filled message input to start a conversation+ *+ * All four slides are mounted at once; inactive slides are translated+ * off-screen and clipped by `overflow: clip`. We wait for the+ * `data-current-step` attribute on the slide rail instead of relying on+ * `toBeVisible()` for the step container elements, which can be unreliable+ * for absolutely-positioned off-screen slides.+ *+ * In MSW mock mode `/server_info` returns HTTP 200 so the backend health+ * probe in step 1 resolves to "connected", enabling the Next button.+ */++test.describe.configure({ mode: "serial" });++async function setupMocks(page: Page) {+ // Intentionally do NOT set openhands-onboarded so the modal appears+ await page.addInitScript(() => {+ window.localStorage.removeItem("openhands-onboarded");+ });+}++async function dismissConsentModal(page: Page) {+ await page+ .getByRole("button", { name: "Confirm preferences" })+ .click({ timeout: 3_000 })+ .catch(() => undefined);+}++/**+ * Wait for the slide rail to display the given step index as current.+ * More reliable than checking child visibility since inactive slides remain+ * in the DOM (absolute-positioned, clipped by overflow:clip).+ */+async function waitForStep(page: Page, step: number) {+ await expect(page.getByTestId("onboarding-slide-rail")).toHaveAttribute(+ "data-current-step",+ String(step),+ { timeout: 15_000 },+ );+}++test.describe("Onboarding Modal Visual Snapshots", () => {+ test.setTimeout(60_000);++ test("onboarding step 0 shows agent selection cards", async ({ page }) => {+ await setupMocks(page);+ await page.goto("/conversations");+ await dismissConsentModal(page);++ // Modal appears because openhands-onboarded is absent+ await expect(page.getByTestId("onboarding-modal")).toBeVisible({+ timeout: 10_000,+ });+ await waitForStep(page, 0);++ const modal = page.getByTestId("onboarding-modal");+ await expect(modal).toHaveScreenshot("onboarding-step-0-choose-agent.png", {+ animations: "disabled",+ maxDiffPixelRatio: 0.01,+ });+ });++ test("onboarding step 1 shows backend connection form", async ({ page }) => {+ await setupMocks(page);+ await page.goto("/conversations");+ await dismissConsentModal(page);++ await expect(page.getByTestId("onboarding-modal")).toBeVisible({+ timeout: 10_000,+ });+ await waitForStep(page, 0);++ // Advance to step 1+ await page.getByTestId("onboarding-agent-next").click();+ await waitForStep(page, 1);++ // Wait for the backend connection banner to settle.+ // In MSW mode /server_info returns 200, so the health probe should+ // quickly resolve to "connected".+ await expect(page.getByTestId("onboarding-backend-connected")).toBeVisible({+ timeout: 10_000,+ });++ const modal = page.getByTestId("onboarding-modal");+ await expect(modal).toHaveScreenshot(+ "onboarding-step-1-check-backend.png",+ { animations: "disabled", maxDiffPixelRatio: 0.01 },+ );+ });++ test("onboarding step 2 shows LLM settings form", async ({ page }) => {+ await setupMocks(page);+ await page.goto("/conversations");+ await dismissConsentModal(page);++ await expect(page.getByTestId("onboarding-modal")).toBeVisible({+ timeout: 10_000,+ });+ await waitForStep(page, 0);++ // Step 0 β 1+ await page.getByTestId("onboarding-agent-next").click();+ await waitForStep(page, 1);++ // Wait for backend connected banner then advance+ await expect(page.getByTestId("onboarding-backend-connected")).toBeVisible({+ timeout: 10_000,+ });+ await page.getByTestId("onboarding-backend-next").click();+ await waitForStep(page, 2);++ // Wait for LLM settings to load (MSW settings + schema endpoints)+ await page.waitForLoadState("networkidle");++ const modal = page.getByTestId("onboarding-modal");+ await expect(modal).toHaveScreenshot("onboarding-step-2-setup-llm.png", {+ animations: "disabled",+ maxDiffPixelRatio: 0.01,+ });+ });++ test("onboarding step 3 shows pre-filled message input", async ({ page }) => {+ await setupMocks(page);+ await page.goto("/conversations");+ await dismissConsentModal(page);++ await expect(page.getByTestId("onboarding-modal")).toBeVisible({+ timeout: 10_000,+ });+ await waitForStep(page, 0);++ // Step 0 β 1+ await page.getByTestId("onboarding-agent-next").click();+ await waitForStep(page, 1);++ // Step 1 β 2 (requires backend connected)+ await expect(page.getByTestId("onboarding-backend-connected")).toBeVisible({+ timeout: 10_000,+ });+ await page.getByTestId("onboarding-backend-next").click();+ await waitForStep(page, 2);++ // Allow LLM settings to finish loading so the save control is registered+ await page.waitForLoadState("networkidle");++ // Step 2 β 3:+ // If the LLM form is dirty (it is, because ONBOARDING_LLM_OVERRIDES differs+ // from the mock default model), clicking Next will trigger a PATCH settings+ // mutation. MSW handles the PATCH and resolves onSaveSuccess β onNext.+ await page.getByTestId("onboarding-llm-next").click();+ await waitForStep(page, 3);++ // Wait for the say-hello input to be ready+ await expect(page.getByTestId("onboarding-hello-input")).toBeVisible({+ timeout: 10_000,+ });++ const modal = page.getByTestId("onboarding-modal");+ await expect(modal).toHaveScreenshot("onboarding-step-3-say-hello.png", {+ animations: "disabled",+ maxDiffPixelRatio: 0.01,+ });+ });+});diff --git a/tests/e2e/snapshots/sidebar.snapshot.spec.ts b/tests/e2e/snapshots/sidebar.snapshot.spec.tsindex de06d3d6bc..395a59a12f 100644--- a/tests/e2e/snapshots/sidebar.snapshot.spec.ts+++ b/tests/e2e/snapshots/sidebar.snapshot.spec.ts@@ -113,4 +113,45 @@ test.describe("Sidebar Visual Snapshots", () => {{ animations: "disabled", maxDiffPixelRatio: 0.01 },);});++ test("new conversation popover opens with no-workspace entry", async ({+ page,+ }) => {+ // The `NewConversationButton` component (and its `new-conversation-button`+ // testid) is temporarily removed from the sidebar. The component lives at+ // src/components/features/conversation-panel/new-conversation-button-local.tsx+ // but is commented out in sidebar.tsx (lines 241-244). This test documents+ // the intended snapshot once the button is re-wired. Mark as fixme so CI+ // stays green while the implementation is pending.+ // eslint-disable-next-line playwright/no-skipped-test+ test.fixme(+ true,+ "NewConversationButton is temporarily hidden from the sidebar (sidebar.tsx:241-244)",+ );++ await setupMocks(page);+ await page.goto("/");+ await dismissConsentModal(page);+ await page.waitForLoadState("networkidle");++ // Find and click the new-conversation trigger in the sidebar+ const newConvButton = page.getByTestId("new-conversation-button");+ await expect(newConvButton).toBeVisible({ timeout: 10_000 });+ await newConvButton.click();++ // Popover should appear+ await expect(page.getByTestId("new-conversation-popover")).toBeVisible({+ timeout: 5_000,+ });++ // "No workspace" entry is always present (no workspaces stored in+ // localStorage in this mock setup)+ await expect(page.getByTestId("launch-no-workspace")).toBeVisible();++ const rootLayout = page.getByTestId("root-layout");+ await expect(rootLayout).toHaveScreenshot(+ "sidebar-new-conversation-popover.png",+ { animations: "disabled", maxDiffPixelRatio: 0.01 },+ );+ });});