Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(ui): increase settings page spacing (#10202)

Mislav Lukache311f3e70f24
diff --git a/frontend/src/components/features/settings/git-settings/bitbucket-token-input.tsx b/frontend/src/components/features/settings/git-settings/bitbucket-token-input.tsx
index 99e27d325f..f205ba2ded 100644
--- a/frontend/src/components/features/settings/git-settings/bitbucket-token-input.tsx
+++ b/frontend/src/components/features/settings/git-settings/bitbucket-token-input.tsx
@@ -3,6 +3,7 @@ import { I18nKey } from "#/i18n/declaration";
import { SettingsInput } from "../settings-input";
import { BitbucketTokenHelpAnchor } from "./bitbucket-token-help-anchor";
import { KeyStatusIcon } from "../key-status-icon";
+import { cn } from "#/utils/utils";
interface BitbucketTokenInputProps {
onChange: (value: string) => void;
@@ -10,6 +11,7 @@ interface BitbucketTokenInputProps {
isBitbucketTokenSet: boolean;
name: string;
bitbucketHostSet: string | null | undefined;
+ className?: string;
}
export function BitbucketTokenInput({
@@ -18,11 +20,12 @@ export function BitbucketTokenInput({
isBitbucketTokenSet,
name,
bitbucketHostSet,
+ className,
}: BitbucketTokenInputProps) {
const { t } = useTranslation();
return (
- <div className="flex flex-col gap-6">
+ <div className={cn("flex flex-col gap-6", className)}>
<SettingsInput
testId={name}
name={name}
diff --git a/frontend/src/components/features/settings/git-settings/github-token-input.tsx b/frontend/src/components/features/settings/git-settings/github-token-input.tsx
index 15b51b5ef5..805c60ebd3 100644
--- a/frontend/src/components/features/settings/git-settings/github-token-input.tsx
+++ b/frontend/src/components/features/settings/git-settings/github-token-input.tsx
@@ -3,6 +3,7 @@ import { I18nKey } from "#/i18n/declaration";
import { SettingsInput } from "../settings-input";
import { GitHubTokenHelpAnchor } from "./github-token-help-anchor";
import { KeyStatusIcon } from "../key-status-icon";
+import { cn } from "#/utils/utils";
interface GitHubTokenInputProps {
onChange: (value: string) => void;
@@ -10,6 +11,7 @@ interface GitHubTokenInputProps {
isGitHubTokenSet: boolean;
name: string;
githubHostSet: string | null | undefined;
+ className?: string;
}
export function GitHubTokenInput({
@@ -18,11 +20,12 @@ export function GitHubTokenInput({
isGitHubTokenSet,
name,
githubHostSet,
+ className,
}: GitHubTokenInputProps) {
const { t } = useTranslation();
return (
- <div className="flex flex-col gap-6">
+ <div className={cn("flex flex-col gap-6", className)}>
<SettingsInput
testId={name}
name={name}
diff --git a/frontend/src/components/features/settings/git-settings/gitlab-token-input.tsx b/frontend/src/components/features/settings/git-settings/gitlab-token-input.tsx
index fa0e1e77e3..18fbb4eded 100644
--- a/frontend/src/components/features/settings/git-settings/gitlab-token-input.tsx
+++ b/frontend/src/components/features/settings/git-settings/gitlab-token-input.tsx
@@ -3,6 +3,7 @@ import { I18nKey } from "#/i18n/declaration";
import { SettingsInput } from "../settings-input";
import { GitLabTokenHelpAnchor } from "./gitlab-token-help-anchor";
import { KeyStatusIcon } from "../key-status-icon";
+import { cn } from "#/utils/utils";
interface GitLabTokenInputProps {
onChange: (value: string) => void;
@@ -10,6 +11,7 @@ interface GitLabTokenInputProps {
isGitLabTokenSet: boolean;
name: string;
gitlabHostSet: string | null | undefined;
+ className?: string;
}
export function GitLabTokenInput({
@@ -18,11 +20,12 @@ export function GitLabTokenInput({
isGitLabTokenSet,
name,
gitlabHostSet,
+ className,
}: GitLabTokenInputProps) {
const { t } = useTranslation();
return (
- <div className="flex flex-col gap-6">
+ <div className={cn("flex flex-col gap-6", className)}>
<SettingsInput
testId={name}
name={name}
diff --git a/frontend/src/routes/git-settings.tsx b/frontend/src/routes/git-settings.tsx
index 66a94a7343..e4a8a6f231 100644
--- a/frontend/src/routes/git-settings.tsx
+++ b/frontend/src/routes/git-settings.tsx
@@ -154,47 +154,49 @@ function GitSettingsScreen() {
</div>
)}
- {!isSaas && (
- <GitHubTokenInput
- name="github-token-input"
- isGitHubTokenSet={isGitHubTokenSet}
- onChange={(value) => {
- setGithubTokenInputHasValue(!!value);
- }}
- onGitHubHostChange={(value) => {
- setGithubHostInputHasValue(!!value);
- }}
- githubHostSet={existingGithubHost}
- />
- )}
-
- {!isSaas && (
- <GitLabTokenInput
- name="gitlab-token-input"
- isGitLabTokenSet={isGitLabTokenSet}
- onChange={(value) => {
- setGitlabTokenInputHasValue(!!value);
- }}
- onGitLabHostChange={(value) => {
- setGitlabHostInputHasValue(!!value);
- }}
- gitlabHostSet={existingGitlabHost}
- />
- )}
-
- {!isSaas && (
- <BitbucketTokenInput
- name="bitbucket-token-input"
- isBitbucketTokenSet={isBitbucketTokenSet}
- onChange={(value) => {
- setBitbucketTokenInputHasValue(!!value);
- }}
- onBitbucketHostChange={(value) => {
- setBitbucketHostInputHasValue(!!value);
- }}
- bitbucketHostSet={existingBitbucketHost}
- />
- )}
+ <div className="flex flex-col gap-4">
+ {!isSaas && (
+ <GitHubTokenInput
+ name="github-token-input"
+ isGitHubTokenSet={isGitHubTokenSet}
+ onChange={(value) => {
+ setGithubTokenInputHasValue(!!value);
+ }}
+ onGitHubHostChange={(value) => {
+ setGithubHostInputHasValue(!!value);
+ }}
+ githubHostSet={existingGithubHost}
+ />
+ )}
+
+ {!isSaas && (
+ <GitLabTokenInput
+ name="gitlab-token-input"
+ isGitLabTokenSet={isGitLabTokenSet}
+ onChange={(value) => {
+ setGitlabTokenInputHasValue(!!value);
+ }}
+ onGitLabHostChange={(value) => {
+ setGitlabHostInputHasValue(!!value);
+ }}
+ gitlabHostSet={existingGitlabHost}
+ />
+ )}
+
+ {!isSaas && (
+ <BitbucketTokenInput
+ name="bitbucket-token-input"
+ isBitbucketTokenSet={isBitbucketTokenSet}
+ onChange={(value) => {
+ setBitbucketTokenInputHasValue(!!value);
+ }}
+ onBitbucketHostChange={(value) => {
+ setBitbucketHostInputHasValue(!!value);
+ }}
+ bitbucketHostSet={existingBitbucketHost}
+ />
+ )}
+ </div>
</div>
)}