🙌 OpenHands: AI-Driven Development
feat(settings): configurable condenser max history size (FE+BE) (#10591)
Engel Nyste41f8f5215d5
diff --git a/frontend/src/hooks/mutation/use-save-settings.ts b/frontend/src/hooks/mutation/use-save-settings.tsindex ba4b41f5d0..68ecd6fb56 100644--- a/frontend/src/hooks/mutation/use-save-settings.ts+++ b/frontend/src/hooks/mutation/use-save-settings.ts@@ -19,6 +19,8 @@ const saveSettingsMutationFn = async (settings: Partial<PostSettings>) => {: settings.llm_api_key?.trim() || undefined,remote_runtime_resource_factor: settings.REMOTE_RUNTIME_RESOURCE_FACTOR,enable_default_condenser: settings.ENABLE_DEFAULT_CONDENSER,+ condenser_max_size:+ settings.CONDENSER_MAX_SIZE ?? DEFAULT_SETTINGS.CONDENSER_MAX_SIZE,enable_sound_notifications: settings.ENABLE_SOUND_NOTIFICATIONS,user_consents_to_analytics: settings.user_consents_to_analytics,provider_tokens_set: settings.PROVIDER_TOKENS_SET,diff --git a/frontend/src/hooks/query/use-settings.ts b/frontend/src/hooks/query/use-settings.tsindex b7002f16d8..65467ac46b 100644--- a/frontend/src/hooks/query/use-settings.ts+++ b/frontend/src/hooks/query/use-settings.ts@@ -22,6 +22,8 @@ const getSettingsQueryFn = async (): Promise<Settings> => {REMOTE_RUNTIME_RESOURCE_FACTOR: apiSettings.remote_runtime_resource_factor,PROVIDER_TOKENS_SET: apiSettings.provider_tokens_set,ENABLE_DEFAULT_CONDENSER: apiSettings.enable_default_condenser,+ CONDENSER_MAX_SIZE:+ apiSettings.condenser_max_size ?? DEFAULT_SETTINGS.CONDENSER_MAX_SIZE,ENABLE_SOUND_NOTIFICATIONS: apiSettings.enable_sound_notifications,ENABLE_PROACTIVE_CONVERSATION_STARTERS:apiSettings.enable_proactive_conversation_starters,diff --git a/frontend/src/i18n/declaration.ts b/frontend/src/i18n/declaration.tsindex 182274cade..2b535e0fc1 100644--- a/frontend/src/i18n/declaration.ts+++ b/frontend/src/i18n/declaration.ts@@ -97,6 +97,8 @@ export enum I18nKey {SETTINGS$BASE_URL = "SETTINGS$BASE_URL",SETTINGS$AGENT = "SETTINGS$AGENT",SETTINGS$ENABLE_MEMORY_CONDENSATION = "SETTINGS$ENABLE_MEMORY_CONDENSATION",+ SETTINGS$CONDENSER_MAX_SIZE = "SETTINGS$CONDENSER_MAX_SIZE",+ SETTINGS$CONDENSER_MAX_SIZE_TOOLTIP = "SETTINGS$CONDENSER_MAX_SIZE_TOOLTIP",SETTINGS$LANGUAGE = "SETTINGS$LANGUAGE",ACTION$PUSH_TO_BRANCH = "ACTION$PUSH_TO_BRANCH",ACTION$PUSH_CREATE_PR = "ACTION$PUSH_CREATE_PR",diff --git a/frontend/src/i18n/translation.json b/frontend/src/i18n/translation.jsonindex 4cc9a7cab0..bd8727df27 100644--- a/frontend/src/i18n/translation.json+++ b/frontend/src/i18n/translation.json@@ -1551,6 +1551,38 @@"de": "Speicherkondensation aktivieren","uk": "Увімкнути конденсацію пам'яті"},+ "SETTINGS$CONDENSER_MAX_SIZE": {+ "en": "Memory condenser max history size",+ "ja": "メモリ凝縮の最大履歴サイズ",+ "zh-CN": "内存凝缩最大历史大小",+ "zh-TW": "記憶體凝縮最大歷史大小",+ "ko-KR": "메모리 응축 최대 기록 크기",+ "no": "Maks historikkstørrelse for minnekondenser",+ "it": "Dimensione massima cronologia condensatore di memoria",+ "pt": "Tamanho máximo do histórico do condensador de memória",+ "es": "Tamaño máximo del historial del condensador de memoria",+ "ar": "الحد الأقصى لحجم سجل مكثف الذاكرة",+ "fr": "Taille maximale de l'historique du condenseur de mémoire",+ "tr": "Bellek yoğunlaştırıcı maksimum geçmiş boyutu",+ "de": "Maximale Verlaufgröße des Speicherkondensators",+ "uk": "Максимальний розмір історії конденсатора пам'яті"+ },+ "SETTINGS$CONDENSER_MAX_SIZE_TOOLTIP": {+ "en": "After this many events, the condenser will summarize history. Minimum 10.",+ "ja": "このイベント数を超えると、凝縮器が履歴を要約します。最小 10。",+ "zh-CN": "达到此事件数量后,凝缩器将汇总历史。最小 10。",+ "zh-TW": "超過此事件數後,凝縮器會摘要歷史。最小 10。",+ "ko-KR": "이 이벤트 수 이후 응축기가 기록을 요약합니다. 최소 10.",+ "no": "Etter så mange hendelser vil kondenseren oppsummere historikken. Minimum 10.",+ "it": "Dopo questo numero di eventi, il condensatore riassumerà la cronologia. Minimo 10.",+ "pt": "Após esse número de eventos, o condensador irá resumir o histórico. Mínimo 10.",+ "es": "Después de este número de eventos, el condensador resumirá el historial. Mínimo 10.",+ "ar": "بعد هذا العدد من الأحداث، سيقوم المكثف بتلخيص السجل. الحد الأدنى 10.",+ "fr": "Après ce nombre d'événements, le condenseur résumera l'historique. Minimum 10.",+ "tr": "Bu kadar olaydan sonra yoğunlaştırıcı geçmişi özetler. En az 10.",+ "de": "Nach so vielen Ereignissen fasst der Kondensator die Historie zusammen. Minimum 10.",+ "uk": "Після цієї кількості подій конденсатор узагальнить історію. Мінімум 10."+ },"SETTINGS$LANGUAGE": {"en": "Language","ja": "言語",diff --git a/frontend/src/mocks/handlers.ts b/frontend/src/mocks/handlers.tsindex 3914809160..66863d4149 100644--- a/frontend/src/mocks/handlers.ts+++ b/frontend/src/mocks/handlers.ts@@ -27,6 +27,7 @@ export const MOCK_DEFAULT_USER_SETTINGS: ApiSettings | PostApiSettings = {DEFAULT_SETTINGS.REMOTE_RUNTIME_RESOURCE_FACTOR,provider_tokens_set: {},enable_default_condenser: DEFAULT_SETTINGS.ENABLE_DEFAULT_CONDENSER,+ condenser_max_size: DEFAULT_SETTINGS.CONDENSER_MAX_SIZE,enable_sound_notifications: DEFAULT_SETTINGS.ENABLE_SOUND_NOTIFICATIONS,enable_proactive_conversation_starters:DEFAULT_SETTINGS.ENABLE_PROACTIVE_CONVERSATION_STARTERS,@@ -198,7 +199,14 @@ export const handlers = [const body = await request.json();if (body) {- MOCK_USER_PREFERENCES.settings = MOCK_DEFAULT_USER_SETTINGS;+ const current = MOCK_USER_PREFERENCES.settings || {+ ...MOCK_DEFAULT_USER_SETTINGS,+ };+ // Persist new values over current/mock defaults+ MOCK_USER_PREFERENCES.settings = {+ ...current,+ ...(body as Partial<ApiSettings>),+ };return HttpResponse.json(null, { status: 200 });}diff --git a/frontend/src/routes/llm-settings.tsx b/frontend/src/routes/llm-settings.tsxindex 8397b9b38e..f388a53724 100644--- a/frontend/src/routes/llm-settings.tsx+++ b/frontend/src/routes/llm-settings.tsx@@ -48,6 +48,7 @@ function LlmSettingsScreen() {confirmationMode: false,enableDefaultCondenser: false,securityAnalyzer: false,+ condenserMaxSize: false,});// Track the currently selected model to show help text@@ -124,6 +125,7 @@ function LlmSettingsScreen() {confirmationMode: false,enableDefaultCondenser: false,securityAnalyzer: false,+ condenserMaxSize: false,});};@@ -181,6 +183,13 @@ function LlmSettingsScreen() {formData.get("enable-confirmation-mode-switch")?.toString() === "on";const enableDefaultCondenser =formData.get("enable-memory-condenser-switch")?.toString() === "on";+ const condenserMaxSizeStr = formData+ .get("condenser-max-size-input")+ ?.toString();+ const condenserMaxSize = condenserMaxSizeStr+ ? Number.parseInt(condenserMaxSizeStr, 10)+ : undefined;+const securityAnalyzer = formData.get("security-analyzer-input")?.toString();@@ -194,6 +203,8 @@ function LlmSettingsScreen() {AGENT: agent,CONFIRMATION_MODE: confirmationMode,ENABLE_DEFAULT_CONDENSER: enableDefaultCondenser,+ CONDENSER_MAX_SIZE:+ condenserMaxSize ?? DEFAULT_SETTINGS.CONDENSER_MAX_SIZE,SECURITY_ANALYZER:securityAnalyzer === "none"? null@@ -222,6 +233,7 @@ function LlmSettingsScreen() {confirmationMode: false,enableDefaultCondenser: false,securityAnalyzer: false,+ condenserMaxSize: false,});};@@ -308,6 +320,17 @@ function LlmSettingsScreen() {}));};+ const handleCondenserMaxSizeIsDirty = (value: string) => {+ const parsed = value ? Number.parseInt(value, 10) : undefined;+ const condenserMaxSizeIsDirty =+ (parsed ?? DEFAULT_SETTINGS.CONDENSER_MAX_SIZE) !==+ (settings?.CONDENSER_MAX_SIZE ?? DEFAULT_SETTINGS.CONDENSER_MAX_SIZE);+ setDirtyInputs((prev) => ({+ ...prev,+ condenserMaxSize: condenserMaxSizeIsDirty,+ }));+ };+const handleSecurityAnalyzerIsDirty = (securityAnalyzer: string) => {const securityAnalyzerIsDirty =securityAnalyzer !== settings?.SECURITY_ANALYZER;@@ -565,6 +588,26 @@ function LlmSettingsScreen() {/>)}+ <div className="w-full max-w-[680px]">+ <SettingsInput+ testId="condenser-max-size-input"+ name="condenser-max-size-input"+ type="number"+ min={10}+ step={1}+ label={t(I18nKey.SETTINGS$CONDENSER_MAX_SIZE)}+ defaultValue={(+ settings.CONDENSER_MAX_SIZE ??+ DEFAULT_SETTINGS.CONDENSER_MAX_SIZE+ )?.toString()}+ onChange={(value) => handleCondenserMaxSizeIsDirty(value)}+ isDisabled={!settings.ENABLE_DEFAULT_CONDENSER}+ />+ <p className="text-xs text-tertiary-alt mt-1">+ {t(I18nKey.SETTINGS$CONDENSER_MAX_SIZE_TOOLTIP)}+ </p>+ </div>+<SettingsSwitchtestId="enable-memory-condenser-switch"name="enable-memory-condenser-switch"diff --git a/frontend/src/services/settings.ts b/frontend/src/services/settings.tsindex e268f5fae9..f7cad15b43 100644--- a/frontend/src/services/settings.ts+++ b/frontend/src/services/settings.ts@@ -14,6 +14,7 @@ export const DEFAULT_SETTINGS: Settings = {REMOTE_RUNTIME_RESOURCE_FACTOR: 1,PROVIDER_TOKENS_SET: {},ENABLE_DEFAULT_CONDENSER: true,+ CONDENSER_MAX_SIZE: 120,ENABLE_SOUND_NOTIFICATIONS: false,USER_CONSENTS_TO_ANALYTICS: false,ENABLE_PROACTIVE_CONVERSATION_STARTERS: false,diff --git a/frontend/src/types/settings.ts b/frontend/src/types/settings.tsindex 7995b21b4c..67460fec13 100644--- a/frontend/src/types/settings.ts+++ b/frontend/src/types/settings.ts@@ -47,6 +47,8 @@ export type Settings = {REMOTE_RUNTIME_RESOURCE_FACTOR: number | null;PROVIDER_TOKENS_SET: Partial<Record<Provider, string | null>>;ENABLE_DEFAULT_CONDENSER: boolean;+ // Maximum number of events before the condenser runs+ CONDENSER_MAX_SIZE: number | null;ENABLE_SOUND_NOTIFICATIONS: boolean;ENABLE_PROACTIVE_CONVERSATION_STARTERS: boolean;ENABLE_SOLVABILITY_ANALYSIS: boolean;@@ -73,6 +75,8 @@ export type ApiSettings = {security_analyzer: string | null;remote_runtime_resource_factor: number | null;enable_default_condenser: boolean;+ // Max size for condenser in backend settings+ condenser_max_size: number | null;enable_sound_notifications: boolean;enable_proactive_conversation_starters: boolean;enable_solvability_analysis: boolean;diff --git a/openhands/server/session/session.py b/openhands/server/session/session.pyindex c45f11e9d4..2b830e4ca5 100644--- a/openhands/server/session/session.py+++ b/openhands/server/session/session.py@@ -203,12 +203,15 @@ class Session:# The order matters: with the browser output first, the summarizer# will only see the most recent browser output, which should keep# the summarization cost down.+ max_events_for_condenser = settings.condenser_max_size or 120default_condenser_config = CondenserPipelineConfig(condensers=[ConversationWindowCondenserConfig(),BrowserOutputCondenserConfig(attention_window=2),LLMSummarizingCondenserConfig(- llm_config=llm_config, keep_first=4, max_size=120+ llm_config=llm_config,+ keep_first=4,+ max_size=max_events_for_condenser,),])@@ -218,7 +221,7 @@ class Session:f' browser_output_masking(attention_window=2), 'f' llm(model="{llm_config.model}", 'f' base_url="{llm_config.base_url}", '- f' keep_first=4, max_size=80)'+ f' keep_first=4, max_size={max_events_for_condenser})')agent_config.condenser = default_condenser_configagent = Agent.get_cls(agent_cls)(agent_config, self.llm_registry)diff --git a/openhands/storage/data_models/settings.py b/openhands/storage/data_models/settings.pyindex 8d67387356..2f2e303464 100644--- a/openhands/storage/data_models/settings.py+++ b/openhands/storage/data_models/settings.py@@ -7,6 +7,7 @@ from pydantic import (SecretStr,SerializationInfo,field_serializer,+ field_validator,model_validator,)from pydantic.json import pydantic_encoder@@ -42,6 +43,8 @@ class Settings(BaseModel):search_api_key: SecretStr | None = Nonesandbox_api_key: SecretStr | None = Nonemax_budget_per_task: float | None = None+ # Maximum number of events in the conversation view before condensation runs+ condenser_max_size: int | None = Noneemail: str | None = Noneemail_verified: bool | None = Nonegit_user_name: str | None = None@@ -102,6 +105,15 @@ class Settings(BaseModel):data['secret_store'] = secret_storereturn data+ @field_validator('condenser_max_size')+ @classmethod+ def validate_condenser_max_size(cls, v: int | None) -> int | None:+ if v is None:+ return v+ if v < 10:+ raise ValueError('condenser_max_size must be at least 10')+ return v+@field_serializer('secrets_store')def secrets_store_serializer(self, secrets: UserSecrets, info: SerializationInfo):"""Custom serializer for secrets store."""