π OpenHands: AI-Driven Development
fix(frontend): Fix empty state showing alongside error in `RecentConversations` (#11993)
sp.wackf4dd5384d0d1
diff --git a/frontend/__tests__/components/features/home/recent-conversations.test.tsx b/frontend/__tests__/components/features/home/recent-conversations.test.tsxnew file mode 100644index 0000000000..8e979c99d2--- /dev/null+++ b/frontend/__tests__/components/features/home/recent-conversations.test.tsx@@ -0,0 +1,56 @@+import { render, screen, waitFor } from "@testing-library/react";+import { describe, it, expect, vi } from "vitest";+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";+import { createRoutesStub } from "react-router";+import { RecentConversations } from "#/components/features/home/recent-conversations/recent-conversations";+import ConversationService from "#/api/conversation-service/conversation-service.api";++const renderRecentConversations = () => {+ const RouterStub = createRoutesStub([+ {+ Component: () => <RecentConversations />,+ path: "/",+ },+ ]);++ const queryClient = new QueryClient({+ defaultOptions: {+ queries: {+ retry: false,+ },+ },+ });++ return render(<RouterStub />, {+ wrapper: ({ children }) => (+ <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>+ ),+ });+};++describe("RecentConversations", () => {+ const getUserConversationsSpy = vi.spyOn(+ ConversationService,+ "getUserConversations",+ );++ it("should not show empty state when there is an error", async () => {+ getUserConversationsSpy.mockRejectedValue(+ new Error("Failed to fetch conversations"),+ );++ renderRecentConversations();++ // Wait for the error to be displayed+ await waitFor(() => {+ expect(+ screen.getByText("Failed to fetch conversations"),+ ).toBeInTheDocument();+ });++ // The empty state should NOT be displayed when there's an error+ expect(+ screen.queryByText("HOME$NO_RECENT_CONVERSATIONS"),+ ).not.toBeInTheDocument();+ });+});diff --git a/frontend/src/components/features/home/recent-conversations/recent-conversations.tsx b/frontend/src/components/features/home/recent-conversations/recent-conversations.tsxindex 3d6bc64410..d0bd560c7d 100644--- a/frontend/src/components/features/home/recent-conversations/recent-conversations.tsx+++ b/frontend/src/components/features/home/recent-conversations/recent-conversations.tsx@@ -78,7 +78,7 @@ export function RecentConversations() {)}</div>- {!isInitialLoading && displayedConversations?.length === 0 && (+ {!isInitialLoading && !error && displayedConversations?.length === 0 && (<span className="text-xs leading-4 text-white font-medium pl-4">{t(I18nKey.HOME$NO_RECENT_CONVERSATIONS)}</span>