Skip to content

πŸ™Œ OpenHands: AI-Driven Development

feat(acp): add switch_acp_model proxy endpoint for cloud conversations (#14744)

simonrosenbergfa2cafa2517c
diff --git a/openhands/app_server/app_conversation/app_conversation_models.py b/openhands/app_server/app_conversation/app_conversation_models.py
index 406c52b0e3..37830b2b3f 100644
--- a/openhands/app_server/app_conversation/app_conversation_models.py
+++ b/openhands/app_server/app_conversation/app_conversation_models.py
@@ -341,6 +341,16 @@ class SwitchProfileRequest(BaseModel):
)
+class SwitchAcpModelRequest(BaseModel):
+ """Request to switch a running ACP conversation's model in place."""
+
+ model: str = Field(
+ ...,
+ description='Model identifier to switch to (must be supported by the provider).',
+ min_length=1,
+ )
+
+
class AppSendMessageResponse(BaseModel):
"""Response from sending a message to a conversation."""
diff --git a/openhands/app_server/app_conversation/app_conversation_router.py b/openhands/app_server/app_conversation/app_conversation_router.py
index fe24994c56..cda91c7f3c 100644
--- a/openhands/app_server/app_conversation/app_conversation_router.py
+++ b/openhands/app_server/app_conversation/app_conversation_router.py
@@ -38,6 +38,7 @@ from openhands.app_server.app_conversation.app_conversation_models import (
HookEventResponse,
HookMatcherResponse,
SkillResponse,
+ SwitchAcpModelRequest,
SwitchProfileRequest,
)
from openhands.app_server.app_conversation.app_conversation_service import (
@@ -752,6 +753,113 @@ async def switch_conversation_profile(
return Success()
+ '/{conversation_id}/switch_acp_model',
+ responses={
+ 400: {
+ 'description': 'Agent is not ACP, or provider does not support model switching'
+ },
+ 404: {'description': 'Conversation or sandbox not found'},
+ 409: {
+ 'description': 'ACP session not initialised yet; send the first message first'
+ },
+ 502: {'description': 'Agent server returned an error'},
+ 504: {'description': 'ACP server did not respond to the model switch in time'},
+ },
+)
+async def switch_conversation_acp_model(
+ conversation_id: UUID,
+ request: SwitchAcpModelRequest,
+ app_conversation_service: AppConversationService = (
+ app_conversation_service_dependency
+ ),
+ app_conversation_info_service: AppConversationInfoService = (
+ app_conversation_info_service_dependency
+ ),
+ sandbox_service: SandboxService = sandbox_service_dependency,
+ sandbox_spec_service: SandboxSpecService = sandbox_spec_service_dependency,
+ httpx_client: httpx.AsyncClient = httpx_client_dependency,
+) -> Success:
+ """Switch the model of a running ACP conversation in place.
+
+ Proxies to the agent-server's ``switch_acp_model`` endpoint, which issues
+ a protocol-level ``session/set_model`` call to the ACP subprocess so the
+ new model applies to subsequent turns without losing context. Persists the
+ new model on the conversation record so the UI chip stays current.
+ """
+ ctx = await _get_agent_server_context(
+ conversation_id,
+ app_conversation_service,
+ sandbox_service,
+ sandbox_spec_service,
+ )
+ if isinstance(ctx, JSONResponse):
+ raise HTTPException(
+ status_code=ctx.status_code,
+ detail=f'Conversation {conversation_id} is not reachable',
+ )
+ if ctx is None:
+ raise HTTPException(
+ status_code=status.HTTP_409_CONFLICT,
+ detail='Sandbox is paused; resume it before switching models.',
+ )
+
+ headers = {'X-Session-API-Key': ctx.session_api_key} if ctx.session_api_key else {}
+
+ try:
+ switch_response = await httpx_client.post(
+ f'{ctx.agent_server_url}/api/conversations/{conversation_id}/switch_acp_model',
+ json={'model': request.model},
+ headers=headers,
+ timeout=30.0,
+ )
+ switch_response.raise_for_status()
+ logger.info(
+ 'Switched ACP conversation %s to model %r',
+ conversation_id,
+ request.model,
+ )
+ except httpx.HTTPStatusError as e:
+ logger.error(
+ 'Agent server returned error during switch_acp_model: '
+ f'{e.response.status_code} - {e.response.text}'
+ )
+ # Surface agent-server's 400/409/504 directly β€” they carry semantics
+ # (not-ACP, no-session, timeout) that the client can act on.
+ if e.response.status_code in (400, 409, 504):
+ raise HTTPException(
+ status_code=e.response.status_code,
+ detail=e.response.text,
+ )
+ raise HTTPException(
+ status_code=status.HTTP_502_BAD_GATEWAY,
+ detail=f'Agent server error: {e.response.status_code}',
+ )
+ except httpx.RequestError as e:
+ logger.error(f'Failed to reach agent server during switch_acp_model: {e}')
+ raise HTTPException(
+ status_code=status.HTTP_502_BAD_GATEWAY,
+ detail='Failed to reach agent server.',
+ )
+
+ # Persist so the conversation's model chip reflects the switch on next load.
+ try:
+ info = await app_conversation_info_service.get_app_conversation_info(
+ conversation_id,
+ )
+ if info is not None and info.llm_model != request.model:
+ info.llm_model = request.model
+ await app_conversation_info_service.save_app_conversation_info(info)
+ except Exception:
+ logger.exception(
+ 'Failed to persist new llm_model on conversation %s after ACP model '
+ 'switch β€” chip may be stale until the next refresh.',
+ conversation_id,
+ )
+
+ return Success()
+
+
async def _finalize_sandbox_delete(
sandbox_service: SandboxService,
app_conversation_info_service: AppConversationInfoService,