Skip to content

πŸ™Œ OpenHands: AI-Driven Development

Remove obsolete task.py file (#8517)

Emmanuel Ferdmanfb516dfa0f8d
diff --git a/openhands/controller/state/state.py b/openhands/controller/state/state.py
index 403dcc050e..84a75928a6 100644
--- a/openhands/controller/state/state.py
+++ b/openhands/controller/state/state.py
@@ -8,7 +8,6 @@ from enum import Enum
from typing import Any
import openhands
-from openhands.controller.state.task import RootTask
from openhands.core.logger import openhands_logger as logger
from openhands.core.schema import AgentState
from openhands.events.action import (
@@ -75,7 +74,6 @@ class State:
- additional task-specific data
"""
- root_task: RootTask = field(default_factory=RootTask)
session_id: str = ''
# global iteration for the current task
iteration: int = 0
diff --git a/openhands/controller/state/task.py b/openhands/controller/state/task.py
deleted file mode 100644
index e866c15a4b..0000000000
--- a/openhands/controller/state/task.py
+++ /dev/null
@@ -1,234 +0,0 @@
-from __future__ import annotations
-
-from openhands.core.exceptions import (
- LLMMalformedActionError,
- TaskInvalidStateError,
-)
-from openhands.core.logger import openhands_logger as logger
-
-OPEN_STATE = 'open'
-COMPLETED_STATE = 'completed'
-ABANDONED_STATE = 'abandoned'
-IN_PROGRESS_STATE = 'in_progress'
-VERIFIED_STATE = 'verified'
-STATES = [
- OPEN_STATE,
- COMPLETED_STATE,
- ABANDONED_STATE,
- IN_PROGRESS_STATE,
- VERIFIED_STATE,
-]
-
-
-class Task:
- id: str
- goal: str
- parent: 'Task' | None
- subtasks: list['Task']
-
- def __init__(
- self,
- parent: 'Task',
- goal: str,
- state: str = OPEN_STATE,
- subtasks: list[dict | 'Task'] | None = None, # noqa: B006
- ) -> None:
- """Initializes a new instance of the Task class.
-
- Args:
- parent: The parent task, or None if it is the root task.
- goal: The goal of the task.
- state: The initial state of the task.
- subtasks: A list of subtasks associated with this task.
- """
- if subtasks is None:
- subtasks = []
- if parent.id:
- self.id = parent.id + '.' + str(len(parent.subtasks))
- else:
- self.id = str(len(parent.subtasks))
- self.parent = parent
- self.goal = goal
- logger.debug(f'Creating task {self.id} with parent={parent.id}, goal={goal}')
- self.subtasks = []
- for subtask in subtasks or []:
- if isinstance(subtask, Task):
- self.subtasks.append(subtask)
- else:
- goal = str(subtask.get('goal', ''))
- state = str(subtask.get('state', OPEN_STATE))
- subtasks = subtask.get('subtasks')
- logger.debug(f'Reading: {goal}, {state}, {subtasks}')
- self.subtasks.append(Task(self, goal, state, subtasks))
-
- self.state = OPEN_STATE
-
- def to_string(self, indent: str = '') -> str:
- """Returns a string representation of the task and its subtasks.
-
- Args:
- indent: The indentation string for formatting the output.
-
- Returns:
- A string representation of the task and its subtasks.
- """
- emoji = ''
- if self.state == VERIFIED_STATE:
- emoji = 'βœ…'
- elif self.state == COMPLETED_STATE:
- emoji = '🟒'
- elif self.state == ABANDONED_STATE:
- emoji = '❌'
- elif self.state == IN_PROGRESS_STATE:
- emoji = 'πŸ’ͺ'
- elif self.state == OPEN_STATE:
- emoji = 'πŸ”΅'
- result = indent + emoji + ' ' + self.id + ' ' + self.goal + '\n'
- for subtask in self.subtasks:
- result += subtask.to_string(indent + ' ')
- return result
-
- def to_dict(self) -> dict:
- """Returns a dictionary representation of the task.
-
- Returns:
- A dictionary containing the task's attributes.
- """
- return {
- 'id': self.id,
- 'goal': self.goal,
- 'state': self.state,
- 'subtasks': [t.to_dict() for t in self.subtasks],
- }
-
- def set_state(self, state: str) -> None:
- """Sets the state of the task and its subtasks.
-
- Args:
- state: The new state of the task.
-
- Raises:
- TaskInvalidStateError: If the provided state is invalid.
- """
- if state not in STATES:
- logger.error('Invalid state: %s', state)
- raise TaskInvalidStateError(state)
- self.state = state
- if (
- state == COMPLETED_STATE
- or state == ABANDONED_STATE
- or state == VERIFIED_STATE
- ):
- for subtask in self.subtasks:
- if subtask.state != ABANDONED_STATE:
- subtask.set_state(state)
- elif state == IN_PROGRESS_STATE:
- if self.parent is not None:
- self.parent.set_state(state)
-
- def get_current_task(self) -> 'Task' | None:
- """Retrieves the current task in progress.
-
- Returns:
- The current task in progress, or None if no task is in progress.
- """
- for subtask in self.subtasks:
- if subtask.state == IN_PROGRESS_STATE:
- return subtask.get_current_task()
- if self.state == IN_PROGRESS_STATE:
- return self
- return None
-
-
-class RootTask(Task):
- """Serves as the root node in a tree of tasks.
- Because we want the top-level of the root_task to be a list of tasks (1, 2, 3, etc.),
- the "root node" of the data structure is kind of invisible--it just
- holds references to the top-level tasks.
-
- Attributes:
- id: Kept blank for root_task
- goal: Kept blank for root_task
- parent: None for root_task
- subtasks: The top-level list of tasks associated with the root_task.
- state: The state of the root_task.
- """
-
- id: str = ''
- goal: str = ''
- parent: None = None
-
- def __init__(self) -> None:
- self.subtasks = []
- self.state = OPEN_STATE
-
- def __str__(self) -> str:
- """Returns a string representation of the root_task.
-
- Returns:
- A string representation of the root_task.
- """
- return self.to_string()
-
- def get_task_by_id(self, id: str) -> Task:
- """Retrieves a task by its ID.
-
- Args:
- id: The ID of the task.
-
- Returns:
- The task with the specified ID.
-
- Raises:
- AgentMalformedActionError: If the provided task ID is invalid or does not exist.
- """
- if id == '':
- return self
- if len(self.subtasks) == 0:
- raise LLMMalformedActionError('Task does not exist:' + id)
- try:
- parts = [int(p) for p in id.split('.')]
- except ValueError:
- raise LLMMalformedActionError('Invalid task id:' + id)
- task: Task = self
- for part in parts:
- if part >= len(task.subtasks):
- raise LLMMalformedActionError('Task does not exist:' + id)
- task = task.subtasks[part]
- return task
-
- def add_subtask(
- self,
- parent_id: str,
- goal: str,
- subtasks: list[dict | Task] | None = None,
- ) -> None:
- """Adds a subtask to a parent task.
-
- Args:
- parent_id: The ID of the parent task.
- goal: The goal of the subtask.
- subtasks: A list of subtasks associated with the new subtask.
- """
- subtasks = subtasks or []
- parent = self.get_task_by_id(parent_id)
- child = Task(parent=parent, goal=goal, subtasks=subtasks)
- parent.subtasks.append(child)
-
- def set_subtask_state(self, id: str, state: str) -> None:
- """Sets the state of a subtask.
-
- Args:
- id: The ID of the subtask.
- state: The new state of the subtask.
- """
- task = self.get_task_by_id(id)
- logger.debug('Setting task {task.id} from state {task.state} to {state}')
- task.set_state(state)
- unfinished_tasks = [
- t
- for t in self.subtasks
- if t.state not in [COMPLETED_STATE, VERIFIED_STATE, ABANDONED_STATE]
- ]
- if len(unfinished_tasks) == 0:
- self.set_state(COMPLETED_STATE)