Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix: stop calling agent-server /generate_title (#13093)

Engel Nystfb7333aa62ae
diff --git a/openhands/app_server/event_callback/set_title_callback_processor.py b/openhands/app_server/event_callback/set_title_callback_processor.py
index 071d28b5f9..37d70370b0 100644
--- a/openhands/app_server/event_callback/set_title_callback_processor.py
+++ b/openhands/app_server/event_callback/set_title_callback_processor.py
@@ -1,6 +1,9 @@
+import asyncio
import logging
from uuid import UUID
+import httpx
+
from openhands.app_server.app_conversation.app_conversation_models import (
AppConversationInfo,
)
@@ -22,6 +25,9 @@ from openhands.sdk import Event, MessageEvent
_logger = logging.getLogger(__name__)
+# Poll with ~3.75s total wait per message event before retrying later.
+_TITLE_POLL_DELAYS_S = (0.25, 0.5, 1.0, 2.0)
+
class SetTitleCallbackProcessor(EventCallbackProcessor):
"""Callback processor which sets conversation titles."""
@@ -51,7 +57,6 @@ class SetTitleCallbackProcessor(EventCallbackProcessor):
get_app_conversation_info_service(state) as app_conversation_info_service,
get_httpx_client(state) as httpx_client,
):
- # Generate a title for the conversation
app_conversation = await app_conversation_service.get_app_conversation(
conversation_id
)
@@ -61,15 +66,38 @@ class SetTitleCallbackProcessor(EventCallbackProcessor):
app_conversation_url = replace_localhost_hostname_for_docker(
app_conversation_url
)
- response = await httpx_client.post(
- f'{app_conversation_url}/generate_title',
- headers={
- 'X-Session-API-Key': app_conversation.session_api_key,
- },
- content='{}',
- )
- response.raise_for_status()
- title = response.json()['title']
+
+ title = None
+ for delay_s in _TITLE_POLL_DELAYS_S:
+ try:
+ response = await httpx_client.get(
+ app_conversation_url,
+ headers={
+ 'X-Session-API-Key': app_conversation.session_api_key,
+ },
+ )
+ response.raise_for_status()
+ except httpx.HTTPError as exc:
+ # Transient agent-server failures are acceptable; retry later.
+ _logger.debug(
+ 'Title poll failed for conversation %s: %s',
+ conversation_id,
+ exc,
+ )
+ else:
+ title = response.json().get('title')
+ if title:
+ break
+ # Backoff applies to both missing-title responses and transient errors.
+ await asyncio.sleep(delay_s)
+
+ if not title:
+ # Keep the callback active so later message events can retry.
+ _logger.info(
+ f'Conversation {conversation_id} title not available yet; '
+ 'will retry on a future message event.'
+ )
+ return None
# Save the conversation info
info = AppConversationInfo(
diff --git a/tests/unit/app_server/test_set_title_callback_processor.py b/tests/unit/app_server/test_set_title_callback_processor.py
new file mode 100644
index 0000000000..2c992be3f9
--- /dev/null
+++ b/tests/unit/app_server/test_set_title_callback_processor.py
@@ -0,0 +1,294 @@
+from __future__ import annotations
+
+from contextlib import asynccontextmanager
+from unittest.mock import AsyncMock, patch
+from uuid import uuid4
+
+import httpx
+import pytest
+
+from openhands.app_server.app_conversation.app_conversation_models import (
+ AppConversation,
+)
+from openhands.app_server.event_callback.event_callback_models import (
+ EventCallback,
+ EventCallbackStatus,
+)
+from openhands.app_server.event_callback.set_title_callback_processor import (
+ SetTitleCallbackProcessor,
+)
+from openhands.app_server.utils.docker_utils import (
+ replace_localhost_hostname_for_docker,
+)
+from openhands.sdk import Message, MessageEvent, TextContent
+
+
+class _FakeHttpxClient:
+ def __init__(self, titles: list[str | None]):
+ self._titles = titles
+ self.calls: list[tuple[str, dict[str, str] | None]] = []
+
+ async def get(self, url: str, headers: dict[str, str] | None = None):
+ self.calls.append((url, headers))
+ idx = min(len(self.calls) - 1, len(self._titles) - 1)
+ request = httpx.Request('GET', url)
+ return httpx.Response(200, json={'title': self._titles[idx]}, request=request)
+
+
+class _FailingHttpxClient:
+ def __init__(self, error: httpx.HTTPError):
+ self._error = error
+ self.calls: list[tuple[str, dict[str, str] | None]] = []
+
+ async def get(self, url: str, headers: dict[str, str] | None = None):
+ self.calls.append((url, headers))
+ raise self._error
+
+
+@asynccontextmanager
+async def _ctx(obj):
+ yield obj
+
+
+async def test_set_title_callback_processor_fetches_title_from_conversation():
+ conversation_id = uuid4()
+ session_api_key = 'test-session-key'
+ conversation_url = f'http://localhost:8000/api/conversations/{conversation_id.hex}'
+
+ app_conversation = AppConversation(
+ id=conversation_id,
+ created_by_user_id='user',
+ sandbox_id='sandbox',
+ title=f'Conversation {conversation_id.hex[:5]}',
+ conversation_url=conversation_url,
+ session_api_key=session_api_key,
+ )
+
+ app_conversation_service = AsyncMock()
+ app_conversation_service.get_app_conversation.return_value = app_conversation
+
+ app_conversation_info_service = AsyncMock()
+ event_callback_service = AsyncMock()
+
+ httpx_client = _FakeHttpxClient(titles=[None, None, None, 'Generated Title'])
+
+ def get_app_conversation_service(_state):
+ return _ctx(app_conversation_service)
+
+ def get_app_conversation_info_service(_state):
+ return _ctx(app_conversation_info_service)
+
+ def get_event_callback_service(_state):
+ return _ctx(event_callback_service)
+
+ def get_httpx_client(_state):
+ return _ctx(httpx_client)
+
+ callback = EventCallback(
+ conversation_id=conversation_id, processor=SetTitleCallbackProcessor()
+ )
+ event = MessageEvent(
+ source='user',
+ llm_message=Message(role='user', content=[TextContent(text='hi')]),
+ )
+
+ processor = SetTitleCallbackProcessor()
+
+ with (
+ patch(
+ 'openhands.app_server.config.get_app_conversation_service',
+ get_app_conversation_service,
+ ),
+ patch(
+ 'openhands.app_server.config.get_app_conversation_info_service',
+ get_app_conversation_info_service,
+ ),
+ patch(
+ 'openhands.app_server.config.get_event_callback_service',
+ get_event_callback_service,
+ ),
+ patch('openhands.app_server.config.get_httpx_client', get_httpx_client),
+ patch(
+ 'openhands.app_server.event_callback.'
+ 'set_title_callback_processor.asyncio.sleep',
+ new=AsyncMock(),
+ ),
+ ):
+ result = await processor(conversation_id, callback, event)
+
+ assert result is not None
+
+ assert len(httpx_client.calls) == 4
+ expected_url = replace_localhost_hostname_for_docker(conversation_url)
+ assert httpx_client.calls[0][0] == expected_url
+ assert httpx_client.calls[0][1] == {'X-Session-API-Key': session_api_key}
+
+ app_conversation_info_service.save_app_conversation_info.assert_called_once()
+ saved_info = app_conversation_info_service.save_app_conversation_info.call_args[0][
+ 0
+ ]
+ assert saved_info.title == 'Generated Title'
+
+ assert callback.status == EventCallbackStatus.DISABLED
+ event_callback_service.save_event_callback.assert_called_once()
+
+
+async def test_set_title_callback_processor_no_title_yet_returns_none():
+ conversation_id = uuid4()
+ session_api_key = 'test-session-key'
+ conversation_url = f'http://localhost:8000/api/conversations/{conversation_id.hex}'
+
+ app_conversation = AppConversation(
+ id=conversation_id,
+ created_by_user_id='user',
+ sandbox_id='sandbox',
+ title=f'Conversation {conversation_id.hex[:5]}',
+ conversation_url=conversation_url,
+ session_api_key=session_api_key,
+ )
+
+ app_conversation_service = AsyncMock()
+ app_conversation_service.get_app_conversation.return_value = app_conversation
+
+ app_conversation_info_service = AsyncMock()
+ event_callback_service = AsyncMock()
+
+ httpx_client = _FakeHttpxClient(titles=[None])
+
+ def get_app_conversation_service(_state):
+ return _ctx(app_conversation_service)
+
+ def get_app_conversation_info_service(_state):
+ return _ctx(app_conversation_info_service)
+
+ def get_event_callback_service(_state):
+ return _ctx(event_callback_service)
+
+ def get_httpx_client(_state):
+ return _ctx(httpx_client)
+
+ callback = EventCallback(
+ conversation_id=conversation_id, processor=SetTitleCallbackProcessor()
+ )
+ event = MessageEvent(
+ source='user',
+ llm_message=Message(role='user', content=[TextContent(text='hi')]),
+ )
+
+ processor = SetTitleCallbackProcessor()
+
+ with (
+ patch(
+ 'openhands.app_server.config.get_app_conversation_service',
+ get_app_conversation_service,
+ ),
+ patch(
+ 'openhands.app_server.config.get_app_conversation_info_service',
+ get_app_conversation_info_service,
+ ),
+ patch(
+ 'openhands.app_server.config.get_event_callback_service',
+ get_event_callback_service,
+ ),
+ patch('openhands.app_server.config.get_httpx_client', get_httpx_client),
+ patch(
+ 'openhands.app_server.event_callback.'
+ 'set_title_callback_processor.asyncio.sleep',
+ new=AsyncMock(),
+ ),
+ ):
+ result = await processor(conversation_id, callback, event)
+
+ assert result is None
+
+ app_conversation_info_service.save_app_conversation_info.assert_not_called()
+ event_callback_service.save_event_callback.assert_not_called()
+ assert callback.status == EventCallbackStatus.ACTIVE
+
+
+async def test_set_title_callback_processor_request_errors_return_none():
+ conversation_id = uuid4()
+ session_api_key = 'test-session-key'
+ conversation_url = f'http://localhost:8000/api/conversations/{conversation_id.hex}'
+
+ app_conversation = AppConversation(
+ id=conversation_id,
+ created_by_user_id='user',
+ sandbox_id='sandbox',
+ title=f'Conversation {conversation_id.hex[:5]}',
+ conversation_url=conversation_url,
+ session_api_key=session_api_key,
+ )
+
+ app_conversation_service = AsyncMock()
+ app_conversation_service.get_app_conversation.return_value = app_conversation
+
+ app_conversation_info_service = AsyncMock()
+ event_callback_service = AsyncMock()
+
+ httpx_client = _FailingHttpxClient(
+ httpx.RequestError(
+ 'boom',
+ request=httpx.Request(
+ 'GET', replace_localhost_hostname_for_docker(conversation_url)
+ ),
+ )
+ )
+
+ def get_app_conversation_service(_state):
+ return _ctx(app_conversation_service)
+
+ def get_app_conversation_info_service(_state):
+ return _ctx(app_conversation_info_service)
+
+ def get_event_callback_service(_state):
+ return _ctx(event_callback_service)
+
+ def get_httpx_client(_state):
+ return _ctx(httpx_client)
+
+ callback = EventCallback(
+ conversation_id=conversation_id, processor=SetTitleCallbackProcessor()
+ )
+ event = MessageEvent(
+ source='user',
+ llm_message=Message(role='user', content=[TextContent(text='hi')]),
+ )
+
+ processor = SetTitleCallbackProcessor()
+
+ with (
+ patch(
+ 'openhands.app_server.config.get_app_conversation_service',
+ get_app_conversation_service,
+ ),
+ patch(
+ 'openhands.app_server.config.get_app_conversation_info_service',
+ get_app_conversation_info_service,
+ ),
+ patch(
+ 'openhands.app_server.config.get_event_callback_service',
+ get_event_callback_service,
+ ),
+ patch('openhands.app_server.config.get_httpx_client', get_httpx_client),
+ patch(
+ 'openhands.app_server.event_callback.'
+ 'set_title_callback_processor.asyncio.sleep',
+ new=AsyncMock(),
+ ),
+ patch(
+ 'openhands.app_server.event_callback.'
+ 'set_title_callback_processor._logger.debug'
+ ) as logger_debug,
+ ):
+ result = await processor(conversation_id, callback, event)
+
+ assert result is None
+ assert len(httpx_client.calls) == 4
+ assert logger_debug.call_count == 4
+ app_conversation_info_service.save_app_conversation_info.assert_not_called()
+ event_callback_service.save_event_callback.assert_not_called()
+ assert callback.status == EventCallbackStatus.ACTIVE