π OpenHands: AI-Driven Development
fix: align nav link default text color with settings page nav (#261)
Hiep Lefdaf3873fefd
diff --git a/__tests__/components/features/sidebar/sidebar.test.tsx b/__tests__/components/features/sidebar/sidebar.test.tsxindex a7ec2814ac..cf5c2d0d60 100644--- a/__tests__/components/features/sidebar/sidebar.test.tsx+++ b/__tests__/components/features/sidebar/sidebar.test.tsx@@ -115,4 +115,14 @@ describe("Sidebar", () => {expect(sidebar?.className).not.toMatch(/(^|\s)md:pt-6\.5(\s|$)/);expect(sidebar?.className).not.toMatch(/(^|\s)md:pb-3(\s|$)/);});++ it("renders sidebar nav links and the settings toggle with the default text color shared by the settings page nav (text-[#8C8C8C])", () => {+ renderSidebar("/skills");++ const conversationsLink = screen.getByTestId("sidebar-conversations-link");+ expect(conversationsLink.className).toMatch(/(^|\s)text-\[#8C8C8C\](\s|$)/);++ const settingsToggle = screen.getByTestId("sidebar-settings-toggle");+ expect(settingsToggle.className).toMatch(/(^|\s)text-\[#8C8C8C\](\s|$)/);+ });});diff --git a/src/components/features/sidebar/sidebar-nav-link.tsx b/src/components/features/sidebar/sidebar-nav-link.tsxindex 71827aa776..ae2e59b11f 100644--- a/src/components/features/sidebar/sidebar-nav-link.tsx+++ b/src/components/features/sidebar/sidebar-nav-link.tsx@@ -39,7 +39,7 @@ export function SidebarNavLink({indent ? "pl-7 pr-3 py-1.5" : "px-3 py-2",isActive? "bg-[#1f1f1f99] text-white font-medium"- : "text-[#B1B9D3] hover:text-white hover:bg-[#1f1f1f99]",+ : "text-[#8C8C8C] hover:text-white hover:bg-[#1f1f1f99]",disabled && "pointer-events-none opacity-50",)}diff --git a/src/components/features/sidebar/sidebar.tsx b/src/components/features/sidebar/sidebar.tsxindex bc52ce5352..a03d351663 100644--- a/src/components/features/sidebar/sidebar.tsx+++ b/src/components/features/sidebar/sidebar.tsx@@ -142,7 +142,7 @@ export function Sidebar() {"flex items-center justify-between w-full text-sm leading-5 px-3 py-2 rounded-md transition-colors cursor-pointer",isSettingsActive? "bg-[#1f1f1f99] text-white font-medium"- : "text-[#B1B9D3] hover:text-white hover:bg-[#1f1f1f99]",+ : "text-[#8C8C8C] hover:text-white hover:bg-[#1f1f1f99]",)}><span>{t(I18nKey.SIDEBAR$SETTINGS)}</span>