Personal AI, On Personal Devices
Python
"""Tests for #380 per-invocation persona scope (_resolve_persona)."""
import pytest
from openjarvis.core.config import MemoryFilesConfig
from openjarvis.core.paths import get_config_dir
from openjarvis.prompt.builder import SystemPromptBuilder
def test_empty_persona_passes_through_global_defaults():
mf = MemoryFilesConfig()
out = SystemPromptBuilder._resolve_persona(mf)
assert out.soul_path == mf.soul_path # unchanged = backward compatible
def test_none_persona_disables_all_files():
out = SystemPromptBuilder._resolve_persona(MemoryFilesConfig(persona_name="none"))
assert out.soul_path == "" and out.memory_path == "" and out.user_path == ""
def test_named_persona_resolves_to_personas_dir():
out = SystemPromptBuilder._resolve_persona(MemoryFilesConfig(persona_name="coder"))
base = str(get_config_dir() / "personas" / "coder")
assert out.soul_path == f"{base}/SOUL.md"
assert out.memory_path == f"{base}/MEMORY.md"
assert out.user_path == f"{base}/USER.md"
@pytest.mark.parametrize("bad", ["../etc", "a/b", "..\\win", "/abs", "x/../y"])
def test_path_traversal_rejected(bad):
with pytest.raises(ValueError):
SystemPromptBuilder._resolve_persona(MemoryFilesConfig(persona_name=bad))
def test_none_persona_build_does_not_raise(tmp_path, monkeypatch):
"""Regression (#497): `--persona none` resolves to empty file paths; building
the prompt must not raise IsADirectoryError when those empty paths are read
(Path("") is "." — reading a directory raised before the empty-path guard).
"""
import dataclasses
from openjarvis.core.config import load_config
monkeypatch.setenv("OPENJARVIS_HOME", str(tmp_path / "home"))
cfg = load_config(tmp_path / "missing-config.toml")
mf = dataclasses.replace(cfg.memory_files, persona_name="none")
builder = SystemPromptBuilder(
agent_template=cfg.agent.default_system_prompt or "",
memory_files_config=mf,
system_prompt_config=cfg.system_prompt,
)
out = builder.build()
assert isinstance(out, str)