Skip to content

Personal AI, On Personal Devices

Python

fix(security): treat plain-text password files and shadow/credentials as sensitive (#1144)

Wagner Gadea Lorenz637c0b4fbc9c
diff --git a/rust/crates/openjarvis-security/src/file_policy.rs b/rust/crates/openjarvis-security/src/file_policy.rs
index 811042d0..d0e8c605 100644
--- a/rust/crates/openjarvis-security/src/file_policy.rs
+++ b/rust/crates/openjarvis-security/src/file_policy.rs
@@ -13,6 +13,14 @@ static SENSITIVE_PATTERNS: Lazy<HashSet<&'static str>> = Lazy::new(|| {
".htpasswd",
".pgpass",
".netrc",
+ ".git-credentials",
+ "credentials",
+ "shadow",
+ "gshadow",
+ // Plain-text password files
+ "pass.txt",
+ "password.txt",
+ "passwords.txt",
])
});
@@ -104,6 +112,22 @@ mod tests {
true
}
+ #[test]
+ fn test_plaintext_password_files() {
+ for name in [
+ "pass.txt",
+ "password.txt",
+ "passwords.txt",
+ "shadow",
+ "gshadow",
+ "credentials",
+ ".git-credentials",
+ ] {
+ assert!(is_sensitive_file(Path::new(&format!("/srv/app/{name}"))));
+ }
+ assert!(!is_sensitive_file(Path::new("/home/user/notes.txt")));
+ }
+
#[test]
fn test_sensitive_symlink_name_to_ordinary_target() {
for sensitive_name in [".env", "credentials.json", "server.pem"] {
diff --git a/src/openjarvis/security/file_policy.py b/src/openjarvis/security/file_policy.py
index 9e547dc4..a1ca0079 100644
--- a/src/openjarvis/security/file_policy.py
+++ b/src/openjarvis/security/file_policy.py
@@ -23,6 +23,13 @@ DEFAULT_SENSITIVE_PATTERNS: frozenset[str] = frozenset(
".htpasswd",
".pgpass",
".netrc",
+ ".git-credentials",
+ "credentials",
+ "shadow",
+ "gshadow",
+ "pass.txt",
+ "password.txt",
+ "passwords.txt",
}
)
diff --git a/tests/security/test_file_policy.py b/tests/security/test_file_policy.py
index 39b6973c..f4177e4f 100644
--- a/tests/security/test_file_policy.py
+++ b/tests/security/test_file_policy.py
@@ -65,6 +65,23 @@ class TestIsSensitiveFile:
def test_sensitive_env_in_path(self) -> None:
assert is_sensitive_file(Path("/some/dir/.env")) is True
+ @pytest.mark.parametrize(
+ "name",
+ [
+ "pass.txt",
+ "password.txt",
+ "passwords.txt",
+ "shadow",
+ "gshadow",
+ "credentials",
+ ".git-credentials",
+ ],
+ )
+ def test_sensitive_plaintext_credential_files(
+ self, name: str, policy_backend: None
+ ) -> None:
+ assert is_sensitive_file(Path("/srv/app") / name) is True
+
def test_not_sensitive_py(self) -> None:
assert is_sensitive_file("main.py") is False