Personal AI, On Personal Devices
Python
fix(engine): recognize unsupported parameter wording in temperature retry (fixes #1019) (#1028)
Arush Wadhawan63eb96045538
diff --git a/src/openjarvis/engine/cloud.py b/src/openjarvis/engine/cloud.pyindex 85a55387..6c8392af 100644--- a/src/openjarvis/engine/cloud.py+++ b/src/openjarvis/engine/cloud.py@@ -188,7 +188,7 @@ def _is_unsupported_temperature_error(exc: Exception) -> bool:"""True if an OpenAI 400 says the model rejects a non-default temperature.Some models (e.g. gpt-5) only accept the default temperature and return- ``code: unsupported_value`` for ``param: temperature`` (see #426). We+ ``code: unsupported_value`` for ``param: temperature`` (see #426, #1019). Wecan't enumerate every such model up front, so detect the error and retrywithout temperature — mirroring the tools-400 retry in the local engines."""@@ -200,6 +200,8 @@ def _is_unsupported_temperature_error(exc: Exception) -> bool:or "unsupported value" in messageor "only the default" in messageor "does not support" in message+ or "unsupported parameter" in message+ or "is not supported" in message)diff --git a/tests/engine/test_cloud.py b/tests/engine/test_cloud.pyindex 01fb280a..f1b360af 100644--- a/tests/engine/test_cloud.py+++ b/tests/engine/test_cloud.py@@ -231,6 +231,73 @@ class TestOpenAIUnsupportedTemperatureRetry:assert "temperature" in calls[0]assert "temperature" not in calls[1]+ def test_retries_without_temperature_on_unsupported_parameter_message(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ """Regression for #1019: OpenAI-compatible endpoint returns+ 'Unsupported parameter: 'temperature' is not supported with this model.'+ """+ monkeypatch.setenv("OPENAI_API_KEY", "sk-test")+ monkeypatch.delenv("ANTHROPIC_API_KEY", raising=False)++ calls: list[dict] = []+ err = Exception(+ "Error code: 400 - {'error': {'message': 'litellm.BadRequestError: "+ 'OpenAIException - {\\n "error": {\\n "message": "Unsupported '+ "parameter: \\'temperature\\' is not supported with this model.\",\\n "+ '"type": "invalid_request_error",\\n "param": "temperature",\\n '+ '"code": null\\n}\\n}. Received Model Group=gpt-5.6-luna\', '+ "'type': None, 'param': None, 'code': '400'}}"+ )++ def create(**kwargs):+ calls.append(kwargs)+ if "temperature" in kwargs:+ raise err+ return self._fake_resp()++ fake_client = mock.MagicMock()+ fake_client.chat.completions.create.side_effect = create++ EngineRegistry.register_value("cloud", CloudEngine)+ engine = CloudEngine()+ engine._openai_client = fake_client++ result = engine.generate(+ [Message(role=Role.USER, content="Hi")],+ model="gpt-5.6-luna",+ temperature=0.7,+ )+ assert result["content"] == "ok"+ assert len(calls) == 2+ assert "temperature" in calls[0]+ assert "temperature" not in calls[1]++ def test_is_unsupported_temperature_error_variations(self) -> None:+ from openjarvis.engine.cloud import _is_unsupported_temperature_error++ # Standard OpenAI 400 (#426)+ assert _is_unsupported_temperature_error(+ Exception("Unsupported value: 'temperature' does not support 0.7")+ )+ assert _is_unsupported_temperature_error(+ Exception("param: temperature, code: unsupported_value")+ )+ assert _is_unsupported_temperature_error(+ Exception("Only the default (1) value is supported for temperature")+ )+ # OpenAI-compatible / LiteLLM proxy (#1019)+ assert _is_unsupported_temperature_error(+ Exception(+ "Unsupported parameter: 'temperature' is not supported with this model."+ )+ )+ # Not temperature related+ assert not _is_unsupported_temperature_error(+ Exception("Unsupported parameter: 'max_tokens' is not supported")+ )+ assert not _is_unsupported_temperature_error(Exception("Rate limit exceeded"))+def test_unrelated_400_is_not_retried(self, monkeypatch: pytest.MonkeyPatch) -> None: