Personal AI, On Personal Devices
Python
fix(engine): omit unsupported Anthropic temperature
Huanyi Xie8d0b9d15db79
diff --git a/src/openjarvis/engine/cloud.py b/src/openjarvis/engine/cloud.pyindex f8837d22..9188f7af 100644--- a/src/openjarvis/engine/cloud.py+++ b/src/openjarvis/engine/cloud.py@@ -91,6 +91,13 @@ _ANTHROPIC_MODELS = ["claude-haiku-4-5","claude-haiku-4-5-20251001",]+_ANTHROPIC_FIXED_SAMPLING_PREFIXES = (+ "claude-opus-4-7",+ "claude-opus-4-8",+ "claude-opus-5",+ "claude-sonnet-5",+ "claude-fable-5",+)_GOOGLE_MODELS = ["gemini-2.5-pro","gemini-2.5-flash",@@ -757,10 +764,11 @@ class CloudEngine(InferenceEngine):create_kwargs: Dict[str, Any] = {"model": model,"messages": chat_msgs,- # Anthropic SDK v1 moved legacy sampling parameters to extra_body.- "extra_body": {"temperature": temperature},"max_tokens": max_tokens,}+ if not model.startswith(_ANTHROPIC_FIXED_SAMPLING_PREFIXES):+ # Anthropic SDK v1 moved legacy sampling parameters to extra_body.+ create_kwargs["extra_body"] = {"temperature": temperature}if system_text:create_kwargs["system"] = system_text@@ -1437,10 +1445,11 @@ class CloudEngine(InferenceEngine):create_kwargs: Dict[str, Any] = {"model": model,"messages": chat_msgs,- # Anthropic SDK v1 moved legacy sampling parameters to extra_body.- "extra_body": {"temperature": temperature},"max_tokens": max_tokens,}+ if not model.startswith(_ANTHROPIC_FIXED_SAMPLING_PREFIXES):+ # Anthropic SDK v1 moved legacy sampling parameters to extra_body.+ create_kwargs["extra_body"] = {"temperature": temperature}if system_text:create_kwargs["system"] = system_textwith self._anthropic_client.messages.stream(**create_kwargs) as stream:@@ -1897,10 +1906,11 @@ class CloudEngine(InferenceEngine):create_kwargs: Dict[str, Any] = {"model": model,"messages": chat_msgs,- # Anthropic SDK v1 moved legacy sampling parameters to extra_body.- "extra_body": {"temperature": temperature},"max_tokens": max_tokens,}+ if not model.startswith(_ANTHROPIC_FIXED_SAMPLING_PREFIXES):+ # Anthropic SDK v1 moved legacy sampling parameters to extra_body.+ create_kwargs["extra_body"] = {"temperature": temperature}if system_text:create_kwargs["system"] = system_textraw_tools = kwargs.pop("tools", None)diff --git a/tests/engine/test_anthropic_sampling.py b/tests/engine/test_anthropic_sampling.pynew file mode 100644index 00000000..5d426822--- /dev/null+++ b/tests/engine/test_anthropic_sampling.py@@ -0,0 +1,101 @@+"""Anthropic's fixed-sampling models reject the legacy temperature field."""++from types import SimpleNamespace+from unittest.mock import MagicMock++import pytest++from openjarvis.core.types import Message, Role+from openjarvis.engine.cloud import CloudEngine+++class _Stream:+ text_stream = ("ok",)++ def __init__(self, response):+ self.response = response++ def __enter__(self):+ return self++ def __exit__(self, *args):+ return False++ def __iter__(self):+ return iter(())++ def get_final_message(self):+ return self.response+++ "method", ["_generate_anthropic", "_stream_anthropic", "_stream_full_anthropic"]+)+ "model",+ ["claude-opus-5-5", "claude-sonnet-5-5", "claude-opus-4-7", "claude-sonnet-5"],+)+async def test_fixed_sampling_models_omit_temperature(method, model):+ response = SimpleNamespace(+ content=[SimpleNamespace(type="text", text="ok")],+ usage=SimpleNamespace(input_tokens=2, output_tokens=1),+ model=model,+ stop_reason="end_turn",+ )+ client = MagicMock()+ client.messages.create.return_value = response+ client.messages.stream.return_value = _Stream(response)+ engine = CloudEngine.__new__(CloudEngine)+ engine._anthropic_client = client+ messages = [Message(role=Role.USER, content="Hi")]++ if method == "_generate_anthropic":+ result = engine._generate_anthropic(+ messages, model=model, temperature=0.4, max_tokens=32+ )+ assert result["content"] == "ok"+ sent = client.messages.create.call_args.kwargs+ else:+ _ = [+ chunk+ async for chunk in getattr(engine, method)(+ messages, model=model, temperature=0.4, max_tokens=32+ )+ ]+ sent = client.messages.stream.call_args.kwargs++ assert "temperature" not in sent+ assert "temperature" not in sent.get("extra_body", {})+ assert sent["model"] == model+ assert sent["max_tokens"] == 32+++ "method", ["_generate_anthropic", "_stream_anthropic", "_stream_full_anthropic"]+)+async def test_legacy_models_keep_requested_temperature(method):+ response = SimpleNamespace(+ content=[SimpleNamespace(type="text", text="ok")],+ usage=SimpleNamespace(input_tokens=2, output_tokens=1),+ model="claude-sonnet-4-6",+ stop_reason="end_turn",+ )+ client = MagicMock()+ client.messages.create.return_value = response+ client.messages.stream.return_value = _Stream(response)+ engine = CloudEngine.__new__(CloudEngine)+ engine._anthropic_client = client+ messages = [Message(role=Role.USER, content="Hi")]+ kwargs = {"model": response.model, "temperature": 0.4, "max_tokens": 32}++ if method == "_generate_anthropic":+ engine._generate_anthropic(messages, **kwargs)+ sent = client.messages.create.call_args.kwargs+ else:+ _ = [chunk async for chunk in getattr(engine, method)(messages, **kwargs)]+ sent = client.messages.stream.call_args.kwargs++ assert "temperature" not in sent+ assert sent["extra_body"]["temperature"] == 0.4diff --git a/tests/engine/test_anthropic_sdk_compat.py b/tests/engine/test_anthropic_sdk_compat.pyindex 75b7e74f..9a6e826c 100644--- a/tests/engine/test_anthropic_sdk_compat.py+++ b/tests/engine/test_anthropic_sdk_compat.py@@ -12,7 +12,8 @@ from openjarvis.engine.cloud import CloudEngine@pytest.mark.asyncio@pytest.mark.parametrize("mode", ["generate", "stream", "stream_full"])-async def test_anthropic_sdk_sampling_parameters(mode: str) -> None:[email protected]("model", ["test-model", "claude-opus-4-7"])+async def test_anthropic_sdk_sampling_parameters(mode: str, model: str) -> None:anthropic = pytest.importorskip("anthropic")http = pytest.importorskip("httpx2")requests = []@@ -20,7 +21,7 @@ async def test_anthropic_sdk_sampling_parameters(mode: str) -> None:"id": "msg_test","type": "message","role": "assistant",- "model": "test-model",+ "model": model,"content": [{"type": "text", "text": "Hello"}],"stop_reason": "end_turn","stop_sequence": None,@@ -89,6 +90,9 @@ async def test_anthropic_sdk_sampling_parameters(mode: str) -> None:assert "".join(chunk.content or "" for chunk in chunks) == "Hello"assert len(requests) == 1- assert requests[0]["temperature"] == 0.35+ if model == "test-model":+ assert requests[0]["temperature"] == 0.35+ else:+ assert "temperature" not in requests[0]assert requests[0]["max_tokens"] == 42assert requests[0]["model"] == message["model"]