Personal AI, On Personal Devices
Python
fix(desktop): publish versioned signed edge artifacts (#1043)
Elliot Sluskya34d497a3306
diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.ymlindex 9aeb86af..10d55ad6 100644--- a/.github/workflows/desktop.yml+++ b/.github/workflows/desktop.yml@@ -18,7 +18,9 @@ on:type: stringconcurrency:- group: desktop-${{ inputs.tag || github.ref }}+ # All rolling builds publish to the same desktop-edge release. Serialize+ # them even when their v* tags (or dispatch inputs) differ.+ group: desktop-${{ (github.event_name == 'pull_request' || startsWith(github.ref, 'refs/tags/desktop-v')) && github.ref || 'edge' }}cancel-in-progress: truepermissions:@@ -86,22 +88,43 @@ jobs:runs-on: ubuntu-lateststeps:- name: Delete old assets from desktop-edge- if: "!startsWith(github.ref, 'refs/tags/')"+ if: "!startsWith(github.ref, 'refs/tags/desktop-v')"env:GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}run: |- TAG="desktop-edge"- # List all asset IDs on the release and delete them- ASSET_IDS=$(gh api "repos/${{ github.repository }}/releases/tags/${TAG}" \- --jq '.assets[].id' 2>/dev/null || true)- for id in $ASSET_IDS; do+ set -euo pipefail+ response="$RUNNER_TEMP/desktop-edge-release.json"+ if ! status=$(curl -sSL -o "$response" -w '%{http_code}' \+ -H "Authorization: Bearer $GH_TOKEN" \+ -H 'Accept: application/vnd.github+json' \+ "$GITHUB_API_URL/repos/$GITHUB_REPOSITORY/releases/tags/desktop-edge"); then+ echo "::error::Could not list desktop-edge release assets"+ exit 1+ fi+ if [[ "$status" == 404 ]]; then+ echo "desktop-edge release does not exist yet"+ exit 0+ fi+ if [[ "$status" != 200 ]]; then+ echo "::error::Listing desktop-edge release assets returned HTTP $status"+ exit 1+ fi+ release_id=$(jq -er '.id' "$response")+ assets="$RUNNER_TEMP/desktop-edge-assets.json"+ gh api "repos/$GITHUB_REPOSITORY/releases/$release_id/assets?per_page=100" \+ --paginate --slurp > "$assets"+ jq -e 'type == "array" and all(.[]; type == "array")' "$assets" > /dev/null+ for id in $(jq -r '.[].[] | .id' "$assets"); doecho "Deleting asset $id"- gh api -X DELETE "repos/${{ github.repository }}/releases/assets/$id" || true+ gh api -X DELETE "repos/$GITHUB_REPOSITORY/releases/assets/$id"donebuild-and-release:needs: [validate, clean-release]if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'+ outputs:+ tag: ${{ steps.release-info.outputs.tag }}+ tauri_version: ${{ steps.release-info.outputs.tauri_version }}strategy:fail-fast: false@@ -323,6 +346,28 @@ jobs:TAURI_VERSION="${VERSION/.dev/-dev.}"echo "tauri_version=${TAURI_VERSION}" >> "$GITHUB_OUTPUT"+ - name: Write Tauri release config+ shell: bash+ env:+ TAURI_VERSION: ${{ steps.release-info.outputs.tauri_version }}+ run: |+ # The CLI and tauri-action both read --config. An environment-only+ # TAURI_CONFIG override leaves the action's version at tauri.conf.json.+ node <<'NODE'+ const assert = require('node:assert/strict');+ const { writeFileSync } = require('node:fs');+ assert.match(process.env.TAURI_VERSION,+ /^\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?(?:\+[0-9A-Za-z.-]+)?$/,+ 'Tauri release version must be SemVer');+ writeFileSync('frontend/src-tauri/tauri.release.conf.json', JSON.stringify({+ version: process.env.TAURI_VERSION,+ bundle: {+ createUpdaterArtifacts: true,+ externalBin: ['binaries/ollama'],+ },+ }));+ NODE+- name: Configure Apple signingif: runner.os == 'macOS'env:@@ -351,13 +396,13 @@ jobs:fi- name: Build and release+ id: tauri-buildtimeout-minutes: 120uses: tauri-apps/tauri-action@v1env:GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}- TAURI_CONFIG: '{"version":"${{ steps.release-info.outputs.tauri_version }}","bundle":{"createUpdaterArtifacts":true,"externalBin":["binaries/ollama"]}}'# tauri-action runs beforeBuildCommand (npm run build:tauri -> vite# build), which requires this at build time (#587). Strict for# releases: a missing/empty secret fails the build by design.@@ -371,7 +416,88 @@ jobs:releaseDraft: falseprerelease: ${{ steps.release-info.outputs.prerelease }}uploadUpdaterJson: true- args: ${{ matrix.args }}+ args: ${{ matrix.args }} --config src-tauri/tauri.release.conf.json++ - name: Verify release metadata and updater signature+ shell: bash+ env:+ EXPECTED_VERSION: ${{ steps.release-info.outputs.tauri_version }}+ BUILT_VERSION: ${{ steps.tauri-build.outputs.appVersion }}+ ARTIFACT_PATHS: ${{ steps.tauri-build.outputs.artifactPaths }}+ run: |+ node <<'NODE'+ const assert = require('node:assert/strict');+ const { existsSync, readFileSync, statSync } = require('node:fs');+ const { basename } = require('node:path');++ const expected = process.env.EXPECTED_VERSION;+ assert.equal(process.env.BUILT_VERSION, expected, 'tauri-action version');++ const artifacts = JSON.parse(process.env.ARTIFACT_PATHS);+ assert.ok(artifacts.some(path => basename(path).includes(expected)),+ `No versioned bundle for ${expected}`);+ assert.ok(artifacts.some(path => path.endsWith('.sig') && statSync(path).size > 0),+ 'No updater signature artifact');++ assert.ok(existsSync('latest.json'), 'tauri-action did not generate latest.json');+ const latest = JSON.parse(readFileSync('latest.json', 'utf8'));+ assert.equal(latest.version, expected, 'latest.json version');+ const prefix = { Linux: 'linux-', macOS: 'darwin-', Windows: 'windows-' }[process.env.RUNNER_OS];+ assert.ok(Object.entries(latest.platforms || {}).some(([platform, entry]) =>+ platform.startsWith(prefix) && entry.signature?.trim() && entry.url),+ `No signed ${process.env.RUNNER_OS} updater in latest.json`);+ NODE++ verify-release:+ needs: [build-and-release]+ runs-on: ubuntu-latest+ steps:+ - name: Verify published updater manifest+ env:+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}+ RELEASE_TAG: ${{ needs.build-and-release.outputs.tag }}+ EXPECTED_VERSION: ${{ needs.build-and-release.outputs.tauri_version }}+ run: |+ mkdir -p "$RUNNER_TEMP/desktop-release-check"+ for attempt in 1 2 3 4 5; do+ if gh release download "$RELEASE_TAG" --repo "$GITHUB_REPOSITORY" \+ --pattern latest.json --dir "$RUNNER_TEMP/desktop-release-check" --clobber; then+ break+ fi+ echo "latest.json unavailable (attempt $attempt); retrying"+ sleep 3+ done+ test -s "$RUNNER_TEMP/desktop-release-check/latest.json"+ release_id=$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$RELEASE_TAG" --jq '.id')+ gh api "repos/$GITHUB_REPOSITORY/releases/$release_id/assets?per_page=100" \+ --paginate --slurp > "$RUNNER_TEMP/desktop-release-check/assets.json"+ gh release download "$RELEASE_TAG" --repo "$GITHUB_REPOSITORY" \+ --pattern '*.sig' --dir "$RUNNER_TEMP/desktop-release-check" --clobber+ node <<'NODE'+ const assert = require('node:assert/strict');+ const { readFileSync } = require('node:fs');+ const { basename, join } = require('node:path');+ const checkDir = join(process.env.RUNNER_TEMP, 'desktop-release-check');+ const latest = JSON.parse(readFileSync(join(checkDir, 'latest.json'), 'utf8'));+ const assets = JSON.parse(readFileSync(join(checkDir, 'assets.json'), 'utf8')).flat();+ const assetsByUrl = new Map(assets.map(asset => [asset.url, asset]));+ const assetsByName = new Map(assets.map(asset => [asset.name, asset]));+ assert.equal(latest.version, process.env.EXPECTED_VERSION);+ for (const platform of ['darwin-aarch64', 'darwin-x86_64', 'linux-x86_64', 'windows-x86_64']) {+ const entry = latest.platforms?.[platform];+ assert.ok(entry?.signature?.trim() && entry?.url, `Missing signed updater for ${platform}`);+ const asset = assetsByUrl.get(entry.url);+ assert.ok(asset, `Updater URL for ${platform} is not an asset in this release`);+ const filename = basename(decodeURIComponent(new URL(asset.browser_download_url).pathname));+ assert.equal(filename, asset.name, `Unexpected updater asset name for ${platform}`);+ assert.ok(filename.includes(process.env.EXPECTED_VERSION),+ `Updater asset for ${platform} has an old version: ${filename}`);+ const signatureName = `${asset.name}.sig`;+ assert.ok(assetsByName.has(signatureName), `Missing uploaded ${signatureName}`);+ assert.equal(readFileSync(join(checkDir, signatureName), 'utf8').trim(),+ entry.signature.trim(), `Signature mismatch for ${platform}`);+ }+ NODE# When a stable `desktop-v*` release is published, repoint the# `desktop-latest` auto-update channel (the endpoint the installed app@@ -379,7 +505,7 @@ jobs:# this release's signed assets, so we copy it verbatim — installed apps are# only ever offered vetted stable builds, never `desktop-edge` dev builds.refresh-stable-channel:- needs: [build-and-release]+ needs: [verify-release]if: startsWith(github.ref, 'refs/tags/desktop-v')runs-on: ubuntu-lateststeps:diff --git a/tests/deployment/test_desktop_network_policy.py b/tests/deployment/test_desktop_network_policy.pyindex e4891da3..154a724c 100644--- a/tests/deployment/test_desktop_network_policy.py+++ b/tests/deployment/test_desktop_network_policy.py@@ -42,9 +42,15 @@ def test_local_build_does_not_require_updater_signing_key() -> None:assert config["bundle"]["createUpdaterArtifacts"] is False-def test_release_workflow_explicitly_enables_updater_artifacts() -> None:- """Signed releases must still publish updater signatures and latest.json."""+def test_release_workflow_passes_updater_config_to_tauri() -> None:+ """The CLI and action must read the release override to sign updater artifacts."""workflow = DESKTOP_WORKFLOW.read_text(encoding="utf-8")- assert '"createUpdaterArtifacts":true' in workflow+ assert "createUpdaterArtifacts: true" in workflow+ assert "externalBin: ['binaries/ollama']" in workflow+ assert (+ "args: ${{ matrix.args }} --config src-tauri/tauri.release.conf.json"+ in workflow+ )+ assert "TAURI_CONFIG:" not in workflowassert "uploadUpdaterJson: true" in workflow