Skip to content

Personal AI, On Personal Devices

Python

fix: CI benchmark crash, dependabot config, and Tauri local build (#197)

Akhilcd8650716c32
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
new file mode 100644
index 00000000..3183182e
--- /dev/null
+++ b/.github/dependabot.yml
@@ -0,0 +1,26 @@
+version: 2
+updates:
+ - package-ecosystem: "npm"
+ directory: "/frontend"
+ schedule:
+ interval: "weekly"
+
+ - package-ecosystem: "cargo"
+ directory: "/frontend/src-tauri"
+ schedule:
+ interval: "weekly"
+
+ - package-ecosystem: "cargo"
+ directory: "/rust"
+ schedule:
+ interval: "weekly"
+
+ - package-ecosystem: "uv"
+ directory: "/"
+ schedule:
+ interval: "weekly"
+
+ - package-ecosystem: "github-actions"
+ directory: "/"
+ schedule:
+ interval: "weekly"
diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml
index a3b5c64d..45ead7f7 100644
--- a/.github/workflows/desktop.yml
+++ b/.github/workflows/desktop.yml
@@ -351,7 +351,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
- TAURI_CONFIG: '{"version":"${{ steps.release-info.outputs.tauri_version }}","bundle":{"externalBin":["binaries/ollama"]}}'
+ TAURI_CONFIG: '{"version":"${{ steps.release-info.outputs.tauri_version }}","bundle":{"createUpdaterArtifacts":true,"externalBin":["binaries/ollama"]}}'
# tauri-action runs beforeBuildCommand (npm run build:tauri -> vite
# build), which requires this at build time (#587). Strict for
# releases: a missing/empty secret fails the build by design.
diff --git a/frontend/src-tauri/tauri.conf.json b/frontend/src-tauri/tauri.conf.json
index 824204b5..beee9018 100644
--- a/frontend/src-tauri/tauri.conf.json
+++ b/frontend/src-tauri/tauri.conf.json
@@ -30,7 +30,7 @@
"bundle": {
"active": true,
"targets": "all",
- "createUpdaterArtifacts": true,
+ "createUpdaterArtifacts": false,
"icon": [
"icons/32x32.png",
"icons/128x128.png",
diff --git a/src/openjarvis/evals/core/dataset.py b/src/openjarvis/evals/core/dataset.py
index 12f95baa..7d1c040f 100644
--- a/src/openjarvis/evals/core/dataset.py
+++ b/src/openjarvis/evals/core/dataset.py
@@ -33,6 +33,10 @@ class DatasetProvider(ABC):
def size(self) -> int:
"""Return the number of loaded records."""
+ def __len__(self) -> int:
+ """Return the number of loaded records."""
+ return self.size()
+
def create_task_env(
self,
record: EvalRecord,
diff --git a/tests/deployment/test_desktop_network_policy.py b/tests/deployment/test_desktop_network_policy.py
index e68b1de3..3c8505d9 100644
--- a/tests/deployment/test_desktop_network_policy.py
+++ b/tests/deployment/test_desktop_network_policy.py
@@ -9,6 +9,7 @@ from pathlib import Path
ROOT = Path(__file__).resolve().parent.parent.parent
TAURI_CONFIG = ROOT / "frontend" / "src-tauri" / "tauri.conf.json"
MACOS_INFO_PLIST = ROOT / "frontend" / "src-tauri" / "Info.plist"
+DESKTOP_WORKFLOW = ROOT / ".github" / "workflows" / "desktop.yml"
def _csp_sources(directive: str) -> set[str]:
@@ -32,3 +33,18 @@ def test_macos_webview_allows_user_configured_http_servers() -> None:
info = plistlib.loads(MACOS_INFO_PLIST.read_bytes())
assert info["NSAppTransportSecurity"]["NSAllowsArbitraryLoadsInWebContent"] is True
+
+
+def test_local_build_does_not_require_updater_signing_key() -> None:
+ """Updater artifacts are a release concern, not a local-build default."""
+ config = json.loads(TAURI_CONFIG.read_text(encoding="utf-8"))
+
+ assert config["bundle"]["createUpdaterArtifacts"] is False
+
+
+def test_release_workflow_explicitly_enables_updater_artifacts() -> None:
+ """Signed releases must still publish updater signatures and latest.json."""
+ workflow = DESKTOP_WORKFLOW.read_text(encoding="utf-8")
+
+ assert '"createUpdaterArtifacts":true' in workflow
+ assert "includeUpdaterJson: true" in workflow
diff --git a/tests/evals/test_episode_mode.py b/tests/evals/test_episode_mode.py
index c4d1214d..43c5f38d 100644
--- a/tests/evals/test_episode_mode.py
+++ b/tests/evals/test_episode_mode.py
@@ -28,6 +28,7 @@ class TestDatasetProviderEpisodes:
return len(self._records)
ds = SimpleDataset()
+ assert len(ds) == ds.size() == 2
episodes = list(ds.iter_episodes())
assert len(episodes) == 2
assert len(episodes[0]) == 1