Skip to content

Personal AI, On Personal Devices

Python

fix(engine): cover Haiku fixed sampling with real SDK requests

Elliot Sluskydfebfe2aa67d
diff --git a/src/openjarvis/engine/cloud.py b/src/openjarvis/engine/cloud.py
index 9188f7af..a68bff28 100644
--- a/src/openjarvis/engine/cloud.py
+++ b/src/openjarvis/engine/cloud.py
@@ -97,6 +97,7 @@ _ANTHROPIC_FIXED_SAMPLING_PREFIXES = (
"claude-opus-5",
"claude-sonnet-5",
"claude-fable-5",
+ "claude-haiku-5",
)
_GOOGLE_MODELS = [
"gemini-2.5-pro",
diff --git a/tests/engine/test_anthropic_sampling.py b/tests/engine/test_anthropic_sampling.py
index 5d426822..c7b1af9c 100644
--- a/tests/engine/test_anthropic_sampling.py
+++ b/tests/engine/test_anthropic_sampling.py
@@ -34,7 +34,15 @@ class _Stream:
)
@pytest.mark.parametrize(
"model",
- ["claude-opus-5-5", "claude-sonnet-5-5", "claude-opus-4-7", "claude-sonnet-5"],
+ [
+ "claude-opus-4-7",
+ "claude-opus-4-8",
+ "claude-opus-5-5",
+ "claude-sonnet-5",
+ "claude-sonnet-5-5",
+ "claude-fable-5-1",
+ "claude-haiku-5-5",
+ ],
)
async def test_fixed_sampling_models_omit_temperature(method, model):
response = SimpleNamespace(
@@ -75,11 +83,14 @@ async def test_fixed_sampling_models_omit_temperature(method, model):
@pytest.mark.parametrize(
"method", ["_generate_anthropic", "_stream_anthropic", "_stream_full_anthropic"]
)
-async def test_legacy_models_keep_requested_temperature(method):
+ "model", ["claude-sonnet-4-6", "claude-haiku-4-5", "claude-haiku-4-5-20251001"]
+)
+async def test_legacy_models_keep_requested_temperature(method, model):
response = SimpleNamespace(
content=[SimpleNamespace(type="text", text="ok")],
usage=SimpleNamespace(input_tokens=2, output_tokens=1),
- model="claude-sonnet-4-6",
+ model=model,
stop_reason="end_turn",
)
client = MagicMock()
diff --git a/tests/engine/test_anthropic_sdk_compat.py b/tests/engine/test_anthropic_sdk_compat.py
index 9a6e826c..f4b0fb2e 100644
--- a/tests/engine/test_anthropic_sdk_compat.py
+++ b/tests/engine/test_anthropic_sdk_compat.py
@@ -12,8 +12,22 @@ from openjarvis.engine.cloud import CloudEngine
@pytest.mark.asyncio
@pytest.mark.parametrize("mode", ["generate", "stream", "stream_full"])
[email protected]("model", ["test-model", "claude-opus-4-7"])
-async def test_anthropic_sdk_sampling_parameters(mode: str, model: str) -> None:
+ "model,supports_temperature",
+ [
+ ("claude-sonnet-4-6", True),
+ ("claude-haiku-4-5-20251001", True),
+ ("claude-opus-4-7", False),
+ ("claude-opus-4-8", False),
+ ("claude-opus-5-5", False),
+ ("claude-sonnet-5-5", False),
+ ("claude-fable-5-1", False),
+ ("claude-haiku-5-5", False),
+ ],
+)
+async def test_anthropic_sdk_sampling_parameters(
+ mode: str, model: str, supports_temperature: bool
+) -> None:
anthropic = pytest.importorskip("anthropic")
http = pytest.importorskip("httpx2")
requests = []
@@ -90,7 +104,7 @@ async def test_anthropic_sdk_sampling_parameters(mode: str, model: str) -> None:
assert "".join(chunk.content or "" for chunk in chunks) == "Hello"
assert len(requests) == 1
- if model == "test-model":
+ if supports_temperature:
assert requests[0]["temperature"] == 0.35
else:
assert "temperature" not in requests[0]