Skip to content

Personal AI, On Personal Devices

Python

fix: tests work without Rust extension and server extras

Jon Saad-Falconf122f5a69961
diff --git a/src/openjarvis/security/boundary.py b/src/openjarvis/security/boundary.py
index 8b5572cf..57c564fc 100644
--- a/src/openjarvis/security/boundary.py
+++ b/src/openjarvis/security/boundary.py
@@ -58,9 +58,18 @@ class BoundaryGuard:
@staticmethod
def _default_scanners() -> List["BaseScanner"]:
- from openjarvis.security.scanner import PIIScanner, SecretScanner
-
- return [SecretScanner(), PIIScanner()]
+ try:
+ from openjarvis.security.scanner import PIIScanner, SecretScanner
+
+ return [SecretScanner(), PIIScanner()]
+ except (ImportError, Exception) as exc:
+ logger.warning(
+ "Rust-backed scanners unavailable (%s); "
+ "BoundaryGuard running without scanners. "
+ "Build the Rust extension: uv run maturin develop",
+ exc,
+ )
+ return []
def scan_outbound(self, content: str, destination: str) -> str:
"""Scan text before it leaves the device.
diff --git a/tests/security/test_boundary_guard.py b/tests/security/test_boundary_guard.py
index bdcb31ce..85b22ad5 100644
--- a/tests/security/test_boundary_guard.py
+++ b/tests/security/test_boundary_guard.py
@@ -2,51 +2,100 @@
from __future__ import annotations
+import re
+from dataclasses import dataclass, field
+from typing import List
+
import pytest
from openjarvis.core.types import ToolCall
+# ---------------------------------------------------------------------------
+# Lightweight mock scanners that don't depend on Rust
+# ---------------------------------------------------------------------------
+
+@dataclass
+class _Finding:
+ pattern_name: str
+ matched_text: str
+ threat_level: str = "CRITICAL"
+
+
+@dataclass
+class _ScanResult:
+ findings: List[_Finding] = field(default_factory=list)
+
+
+class _MockSecretScanner:
+ """Regex-only secret scanner for testing without Rust."""
+
+ _PATTERNS = [
+ ("openai_key", re.compile(r"sk-[A-Za-z0-9_-]{20,}")),
+ ("aws_key", re.compile(r"AKIA[0-9A-Z]{16}")),
+ ("slack_token", re.compile(r"xoxb-[0-9A-Za-z\-]+")),
+ ]
+
+ def scan(self, text: str) -> _ScanResult:
+ findings = []
+ for name, pattern in self._PATTERNS:
+ for m in pattern.finditer(text):
+ findings.append(_Finding(pattern_name=name, matched_text=m.group()))
+ return _ScanResult(findings=findings)
+
+ def redact(self, text: str) -> str:
+ for name, pattern in self._PATTERNS:
+ text = pattern.sub(f"[REDACTED:{name}]", text)
+ return text
+
+
+def _make_guard(mode: str = "redact", enabled: bool = True):
+ """Create a BoundaryGuard with mock scanners (no Rust needed)."""
+ from openjarvis.security.boundary import BoundaryGuard
+
+ return BoundaryGuard(
+ mode=mode,
+ enabled=enabled,
+ scanners=[_MockSecretScanner()],
+ )
+
+
+# ---------------------------------------------------------------------------
+# Tests
+# ---------------------------------------------------------------------------
+
class TestBoundaryGuardScanOutbound:
"""scan_outbound should detect and redact secrets/PII."""
def test_redacts_openai_key(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact")
+ guard = _make_guard(mode="redact")
text = "Use this key: sk-proj-abc123def456ghi789jkl012mno345pqr678stu"
result = guard.scan_outbound(text, destination="openai")
assert "sk-proj-" not in result
assert "[REDACTED" in result
def test_redacts_aws_key(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact")
+ guard = _make_guard(mode="redact")
text = "AWS key: AKIAIOSFODNN7EXAMPLE"
result = guard.scan_outbound(text, destination="openai")
assert "AKIAIOSFODNN7EXAMPLE" not in result
def test_warn_mode_does_not_alter_text(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="warn")
+ guard = _make_guard(mode="warn")
text = "Use this key: sk-proj-abc123def456ghi789jkl012mno345pqr678stu"
result = guard.scan_outbound(text, destination="openai")
assert result == text
def test_block_mode_raises(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard, SecurityBlockError
+ from openjarvis.security.boundary import SecurityBlockError
- guard = BoundaryGuard(mode="block")
+ guard = _make_guard(mode="block")
text = "Use this key: sk-proj-abc123def456ghi789jkl012mno345pqr678stu"
with pytest.raises(SecurityBlockError):
guard.scan_outbound(text, destination="openai")
def test_clean_text_passes_through(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact")
+ guard = _make_guard(mode="redact")
text = "Hello, how are you?"
result = guard.scan_outbound(text, destination="openai")
assert result == text
@@ -56,9 +105,7 @@ class TestBoundaryGuardCheckOutbound:
"""check_outbound should redact secrets in tool call arguments."""
def test_redacts_tool_call_arguments(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact")
+ guard = _make_guard(mode="redact")
tc = ToolCall(
id="test_1",
name="web_search",
@@ -72,17 +119,15 @@ class TestBoundaryGuardCheckOutbound:
assert result.name == "web_search"
def test_clean_args_pass_through(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact")
+ guard = _make_guard(mode="redact")
tc = ToolCall(id="test_2", name="web_search", arguments='{"query": "weather"}')
result = guard.check_outbound(tc)
assert result.arguments == tc.arguments
def test_block_mode_raises_on_tool_call(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard, SecurityBlockError
+ from openjarvis.security.boundary import SecurityBlockError
- guard = BoundaryGuard(mode="block")
+ guard = _make_guard(mode="block")
tc = ToolCall(
id="test_3",
name="web_search",
@@ -96,9 +141,7 @@ class TestBoundaryGuardDisabled:
"""When disabled, BoundaryGuard should pass everything through."""
def test_disabled_passes_secrets_through(self) -> None:
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact", enabled=False)
+ guard = _make_guard(mode="redact", enabled=False)
text = "sk-proj-abc123def456ghi789jkl012mno345pqr678stu"
result = guard.scan_outbound(text, destination="openai")
assert result == text
@@ -198,10 +241,7 @@ class TestToolExecutorBoundaryIntegration:
)
def test_external_tool_args_scanned(self) -> None:
- from openjarvis.core.types import ToolCall
- from openjarvis.security.boundary import BoundaryGuard
-
- guard = BoundaryGuard(mode="redact")
+ guard = _make_guard(mode="redact")
executor = self._make_executor(boundary_guard=guard)
tc = ToolCall(
@@ -215,8 +255,6 @@ class TestToolExecutorBoundaryIntegration:
assert "sk-proj-" not in result.content
def test_no_guard_passes_through(self) -> None:
- from openjarvis.core.types import ToolCall
-
executor = self._make_executor(boundary_guard=None)
tc = ToolCall(
id="t2",
diff --git a/tests/security/test_log_sanitization.py b/tests/security/test_log_sanitization.py
index 46282a09..e3c95546 100644
--- a/tests/security/test_log_sanitization.py
+++ b/tests/security/test_log_sanitization.py
@@ -3,6 +3,9 @@
from __future__ import annotations
import logging
+import os
+import tempfile
+from pathlib import Path
class TestSanitizingFormatter:
@@ -74,11 +77,6 @@ class TestSanitizingFormatter:
assert "xoxb-" not in result
-import os
-import tempfile
-from pathlib import Path
-
-
class TestScopedCredentialAccess:
"""get_tool_credential should return values without polluting os.environ."""
diff --git a/tests/security/test_network_defaults.py b/tests/security/test_network_defaults.py
index 4655b8ed..1b9d82ad 100644
--- a/tests/security/test_network_defaults.py
+++ b/tests/security/test_network_defaults.py
@@ -2,6 +2,10 @@
from __future__ import annotations
+import ipaddress
+
+import pytest
+
class TestServerConfigDefaults:
"""ServerConfig should bind to loopback by default."""
@@ -56,3 +60,80 @@ class TestSecurityConfigDefaults:
cfg = SecurityConfig()
assert cfg.profile == ""
+
+
+def _is_loopback(host: str) -> bool:
+ """Check if a host string is a loopback address."""
+ try:
+ return ipaddress.ip_address(host).is_loopback
+ except ValueError:
+ return host in ("localhost", "")
+
+
+class TestNonLoopbackAuthEnforcement:
+ """Server must require API key when binding non-loopback."""
+
+ def test_loopback_allows_no_key(self) -> None:
+ assert _is_loopback("127.0.0.1")
+
+ def test_wildcard_is_not_loopback(self) -> None:
+ assert not _is_loopback("0.0.0.0")
+
+ def test_non_loopback_requires_key(self) -> None:
+ starlette = pytest.importorskip("starlette") # noqa: F841
+ from openjarvis.server.auth_middleware import check_bind_safety
+
+ try:
+ check_bind_safety("0.0.0.0", api_key="")
+ assert False, "Should have raised"
+ except SystemExit:
+ pass
+
+ def test_non_loopback_with_key_ok(self) -> None:
+ starlette = pytest.importorskip("starlette") # noqa: F841
+ from openjarvis.server.auth_middleware import check_bind_safety
+
+ check_bind_safety("0.0.0.0", api_key="oj_sk_test123")
+
+
+class TestCORSConfiguration:
+ """CORS should use configured origins, not wildcard."""
+
+ def test_create_app_uses_configured_origins(self) -> None:
+ pytest.importorskip("fastapi")
+ from unittest.mock import MagicMock
+
+ from fastapi.testclient import TestClient
+
+ from openjarvis.server.app import create_app
+
+ mock_engine = MagicMock()
+ mock_engine.health.return_value = True
+ mock_engine.list_models.return_value = ["test-model"]
+
+ app = create_app(
+ mock_engine,
+ "test-model",
+ cors_origins=["http://localhost:3000"],
+ )
+ client = TestClient(app)
+
+ resp = client.options(
+ "/health",
+ headers={
+ "Origin": "http://localhost:3000",
+ "Access-Control-Request-Method": "GET",
+ },
+ )
+ assert (
+ resp.headers.get("access-control-allow-origin") == "http://localhost:3000"
+ )
+
+ resp2 = client.options(
+ "/health",
+ headers={
+ "Origin": "http://evil.com",
+ "Access-Control-Request-Method": "GET",
+ },
+ )
+ assert resp2.headers.get("access-control-allow-origin") != "http://evil.com"
diff --git a/tests/security/test_webhook_validation.py b/tests/security/test_webhook_validation.py
index 25b35fec..9bd411ea 100644
--- a/tests/security/test_webhook_validation.py
+++ b/tests/security/test_webhook_validation.py
@@ -4,14 +4,19 @@ from __future__ import annotations
from unittest.mock import patch
+import pytest
+
class TestTwilioValidationFailClosed:
"""Twilio validation must reject when SDK is unavailable."""
def test_missing_sdk_returns_false(self) -> None:
+ pytest.importorskip("fastapi")
from openjarvis.server.webhook_routes import _validate_twilio_signature
- with patch.dict("sys.modules", {"twilio": None, "twilio.request_validator": None}):
+ with patch.dict(
+ "sys.modules", {"twilio": None, "twilio.request_validator": None}
+ ):
result = _validate_twilio_signature(
auth_token="test_token",
url="https://example.com/webhooks/twilio",
@@ -21,6 +26,7 @@ class TestTwilioValidationFailClosed:
assert result is False
def test_empty_auth_token_returns_false(self) -> None:
+ pytest.importorskip("fastapi")
from openjarvis.server.webhook_routes import _validate_twilio_signature
result = _validate_twilio_signature(