Skip to content

World's first open-source, agentic video production system. 12 production pipelines, 100+ tools, 700+ agent skill and production-knowledge files. Turn your AI coding assistant into a full video production studio.

fix(stock-sources): raise transport errors instead of reporting no results

Roger Brogan108f8238f5a4
diff --git a/tools/video/stock_sources/dareful.py b/tools/video/stock_sources/dareful.py
index 03347cfa..4f33b1dd 100644
--- a/tools/video/stock_sources/dareful.py
+++ b/tools/video/stock_sources/dareful.py
@@ -66,8 +66,10 @@ class DarefulSource:
)
r.raise_for_status()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("Dareful search failed: %s", e)
- return []
+ raise
soup = BeautifulSoup(r.text, "html.parser")
out: list[Candidate] = []
diff --git a/tools/video/stock_sources/esa.py b/tools/video/stock_sources/esa.py
index a38b4297..68476557 100644
--- a/tools/video/stock_sources/esa.py
+++ b/tools/video/stock_sources/esa.py
@@ -73,8 +73,10 @@ class ESASource:
)
r.raise_for_status()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("ESA search failed: %s", e)
- return []
+ raise
soup = BeautifulSoup(r.text, "html.parser")
out: list[Candidate] = []
diff --git a/tools/video/stock_sources/jaxa.py b/tools/video/stock_sources/jaxa.py
index 2b913120..f1f3f40b 100644
--- a/tools/video/stock_sources/jaxa.py
+++ b/tools/video/stock_sources/jaxa.py
@@ -76,8 +76,10 @@ class JAXASource:
)
r.raise_for_status()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("JAXA search failed: %s", e)
- return []
+ raise
soup = BeautifulSoup(r.text, "html.parser")
out: list[Candidate] = []
diff --git a/tools/video/stock_sources/loc.py b/tools/video/stock_sources/loc.py
index bc7208cc..d4515c73 100644
--- a/tools/video/stock_sources/loc.py
+++ b/tools/video/stock_sources/loc.py
@@ -83,8 +83,10 @@ class LibraryOfCongressSource:
r.raise_for_status()
data = r.json()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("Library of Congress search failed: %s", e)
- return []
+ raise
results = data.get("results", []) or []
out: list[Candidate] = []
diff --git a/tools/video/stock_sources/mixkit.py b/tools/video/stock_sources/mixkit.py
index bf665d31..9983053c 100644
--- a/tools/video/stock_sources/mixkit.py
+++ b/tools/video/stock_sources/mixkit.py
@@ -69,8 +69,10 @@ class MixkitSource:
)
r.raise_for_status()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("Mixkit search failed: %s", e)
- return []
+ raise
soup = BeautifulSoup(r.text, "html.parser")
out: list[Candidate] = []
diff --git a/tools/video/stock_sources/nara.py b/tools/video/stock_sources/nara.py
index decd4238..60e67765 100644
--- a/tools/video/stock_sources/nara.py
+++ b/tools/video/stock_sources/nara.py
@@ -86,8 +86,10 @@ class NARASource:
r.raise_for_status()
data = r.json()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("NARA search failed: %s", e)
- return []
+ raise
results = data.get("results", []) or []
out: list[Candidate] = []
diff --git a/tools/video/stock_sources/noaa.py b/tools/video/stock_sources/noaa.py
index b150fb48..4ee5235d 100644
--- a/tools/video/stock_sources/noaa.py
+++ b/tools/video/stock_sources/noaa.py
@@ -119,7 +119,10 @@ class NOAASource:
)
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("NOAA search failed: %s", e)
+ raise
return out
diff --git a/tools/video/stock_sources/videvo.py b/tools/video/stock_sources/videvo.py
index 48944d75..8acdca26 100644
--- a/tools/video/stock_sources/videvo.py
+++ b/tools/video/stock_sources/videvo.py
@@ -83,8 +83,10 @@ class VidevoSource:
r.raise_for_status()
data = r.json()
except Exception as e:
+ # Contract: an empty list means "nothing matched", so a
+ # transport failure has to propagate. See `base.StockSource`.
_log.warning("Videvo search failed: %s", e)
- return []
+ raise
hits = data.get("data", []) or data.get("results", []) or data.get("clips", []) or []
out: list[Candidate] = []