World's first open-source, agentic video production system. 12 production pipelines, 100+ tools, 700+ agent skill and production-knowledge files. Turn your AI coding assistant into a full video production studio.
Python agentagentic-aiaiclaudecopilotcursorelevenlabsffmpegfluximage-generationopen-sourceopenaipythonremotionstable-diffusiontext-to-speechtext-to-videovideo-generationvideo-production
fix(kling): avoid replaying ambiguous task submissions (#706)
Rudy Mizrahi Celekli9468d72fdd8a
diff --git a/tests/contracts/test_kling_submission_transport.py b/tests/contracts/test_kling_submission_transport.pynew file mode 100644index 00000000..ead31b1b--- /dev/null+++ b/tests/contracts/test_kling_submission_transport.py@@ -0,0 +1,118 @@+"""Owned loopback transport receipts for task creation and read retries."""++import json+import socket+from contextlib import contextmanager+from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer+from threading import Thread++import pytest++from tools._kling.client import KlingClient+from tools._kling.errors import KlingAPIError+++@contextmanager+def task_server(drop_first=True, first_status=None):+ receipts = []++ class Handler(BaseHTTPRequestHandler):+ def log_message(self, *args):+ pass++ def answer(self, method):+ payload = json.loads(self.rfile.read(int(self.headers.get("Content-Length", 0))) or b"{}")+ receipts.append((method, self.path, payload))+ if first_status is not None and len(receipts) == 1:+ content = json.dumps({"code": 5000, "message": "Temporary provider error", "request_id": "owned-first"}).encode()+ self.send_response(first_status)+ self.send_header("Content-Length", str(len(content)))+ self.end_headers()+ self.wfile.write(content)+ return+ if drop_first and len(receipts) == 1:+ # The task has been accepted; only its response is lost.+ self.connection.shutdown(socket.SHUT_RDWR)+ self.connection.close()+ self.close_connection = True+ return+ content = json.dumps({"code": 0, "data": {"task_id": "owned-task", "id": "owned-turbo"}}).encode()+ self.send_response(200)+ self.send_header("Content-Type", "application/json")+ self.send_header("Content-Length", str(len(content)))+ self.end_headers()+ self.wfile.write(content)++ def do_POST(self):+ self.answer("POST")++ def do_GET(self):+ self.answer("GET")++ server = ThreadingHTTPServer(("127.0.0.1", 0), Handler)+ thread = Thread(target=server.serve_forever, kwargs={"poll_interval": 0.01})+ thread.start()+ try:+ yield f"http://127.0.0.1:{server.server_port}", receipts+ finally:+ server.shutdown()+ server.server_close()+ thread.join(timeout=5)+ assert not thread.is_alive()++[email protected]("family", ["classic", "turbo"])+def test_lost_creation_response_is_not_replayed(monkeypatch, family):+ monkeypatch.setattr("tools._kling.client.time.sleep", lambda delay: None)+ with task_server() as (base_url, receipts):+ client = KlingClient(api_key="owned-offline-key", base_url=base_url)+ try:+ with pytest.raises(KlingAPIError):+ if family == "classic":+ client.create_classic_task("/v1/images/generations", {"prompt": "A tree"})+ else:+ client.create_turbo("/text-to-video/kling-3.0-turbo", {"prompt": "A tree"})+ finally:+ client.session.close()+ assert len(receipts) == 1, "One generation call must accept at most one task"+ assert receipts[0][0] == "POST"+ assert receipts[0][2] == {"prompt": "A tree"}++[email protected]("first_status", [None, 503])+def test_read_transport_retry_remains_available(monkeypatch, first_status):+ monkeypatch.setattr("tools._kling.client.time.sleep", lambda delay: None)+ with task_server(first_status=first_status) as (base_url, receipts):+ client = KlingClient(api_key="owned-offline-key", base_url=base_url)+ try:+ result = client.get("/v1/images/generations/owned-task")+ finally:+ client.session.close()+ assert result["data"]["task_id"] == "owned-task"+ assert len(receipts) == 2+ assert all(method == "GET" for method, _, _ in receipts)+++def test_successful_submission_is_sent_once():+ with task_server(drop_first=False) as (base_url, receipts):+ client = KlingClient(api_key="owned-offline-key", base_url=base_url)+ try:+ assert client.create_classic_task("/v1/images/generations", {"prompt": "A tree"}) == "owned-task"+ finally:+ client.session.close()+ assert len(receipts) == 1+++def test_retryable_submission_error_is_reported_once(monkeypatch):+ monkeypatch.setattr("tools._kling.client.time.sleep", lambda delay: None)+ with task_server(first_status=503) as (base_url, receipts):+ client = KlingClient(api_key="owned-offline-key", base_url=base_url)+ try:+ with pytest.raises(KlingAPIError) as error:+ client.create_classic_task("/v1/images/generations", {"prompt": "A tree"})+ finally:+ client.session.close()+ assert len(receipts) == 1+ assert error.value.http_status == 503+ assert error.value.request_id == "owned-first"+ assert error.value.message == "Temporary provider error"diff --git a/tools/_kling/client.py b/tools/_kling/client.pyindex bfde8d87..bf392498 100644--- a/tools/_kling/client.py+++ b/tools/_kling/client.py@@ -137,7 +137,10 @@ class KlingClient:def _request(self, method: str, path: str, **kwargs: Any) -> dict[str, Any]:url = self._url(path)last_error: KlingAPIError | None = None- for attempt in range(self.max_retries + 1):+ # A lost create response can still mean a paid task was accepted.+ # Retry reads only; do not replay submissions with an unknown outcome.+ max_retries = self.max_retries if method == "get" else 0+ for attempt in range(max_retries + 1):try:response = getattr(self.session, method)(url, headers=self.headers, timeout=30, **kwargs)self._raise_for_http_error(response)@@ -146,12 +149,12 @@ class KlingClient:return dataexcept KlingAPIError as error:last_error = error- if attempt >= self.max_retries or not is_retryable_kling_error(error):+ if attempt >= max_retries or not is_retryable_kling_error(error):raisetime.sleep(min(2.0 * (attempt + 1), 8.0))except requests.RequestException as exc:last_error = KlingAPIError(str(exc))- if attempt >= self.max_retries:+ if attempt >= max_retries:raise last_error from exctime.sleep(min(2.0 * (attempt + 1), 8.0))raise last_error or KlingAPIError("Kling API request failed")