Secure, Fast, and Extensible Sandbox runtime for AI agents.
fix(csharp): preserve optional command stream exit code
leo pein03be1da5abbf
diff --git a/sdks/sandbox/csharp/src/OpenSandbox/Models/Execd.cs b/sdks/sandbox/csharp/src/OpenSandbox/Models/Execd.csindex ed6e3cdef..c6e679ab7 100644--- a/sdks/sandbox/csharp/src/OpenSandbox/Models/Execd.cs+++ b/sdks/sandbox/csharp/src/OpenSandbox/Models/Execd.cs@@ -57,6 +57,15 @@ public class ServerStreamEvent[JsonPropertyName("execution_count")]public int? ExecutionCount { get; set; }+ /// <summary>+ /// Gets or sets the successful foreground command exit status (zero).+ /// Absent for older servers, background startup, and code execution.+ /// Non-zero command exits are reported in the error payload instead.+ /// </summary>+ [JsonPropertyName("exit_code")]+ [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]+ public int? ExitCode { get; set; }+/// <summary>/// Gets or sets the execution time in milliseconds./// </summary>diff --git a/sdks/sandbox/csharp/tests/OpenSandbox.Tests/CommandsAdapterTests.cs b/sdks/sandbox/csharp/tests/OpenSandbox.Tests/CommandsAdapterTests.csindex f0a1f35ed..1621234ea 100644--- a/sdks/sandbox/csharp/tests/OpenSandbox.Tests/CommandsAdapterTests.cs+++ b/sdks/sandbox/csharp/tests/OpenSandbox.Tests/CommandsAdapterTests.cs@@ -29,6 +29,33 @@ namespace OpenSandbox.Tests;public class CommandsAdapterTests{+ [Theory]+ [InlineData(false, false)]+ [InlineData(true, false)]+ [InlineData(false, true)]+ public async Task RunStreamAsync_ShouldPreserveOptionalSuccessExitCode(bool explicitExitCode, bool background)+ {+ var eventJson = explicitExitCode+ ? "{\"type\":\"execution_complete\",\"exit_code\":0}"+ : "{\"type\":\"execution_complete\"}";+ var handler = new StubHttpMessageHandler((_, _) =>+ Task.FromResult(new HttpResponseMessage(HttpStatusCode.OK)+ {+ Content = new StringContent($"data: {eventJson}\n\n", Encoding.UTF8, "text/event-stream")+ }));+ IExecdCommands commands = CreateAdapter(handler);+ var events = new List<ServerStreamEvent>();++ await foreach (var streamEvent in commands.RunStreamAsync("exit 0", new RunCommandOptions { Background = background }))+ {+ events.Add(streamEvent);+ }++ var complete = events.Should().ContainSingle().Which;+ complete.Type.Should().Be(ServerStreamEventTypes.ExecutionComplete);+ complete.ExitCode.Should().Be(explicitExitCode ? 0 : (int?)null);+ }+[Theory][InlineData(false)][InlineData(true)]diff --git a/sdks/sandbox/csharp/tests/OpenSandbox.Tests/ModelsTests.cs b/sdks/sandbox/csharp/tests/OpenSandbox.Tests/ModelsTests.csindex b33597b14..11346117b 100644--- a/sdks/sandbox/csharp/tests/OpenSandbox.Tests/ModelsTests.cs+++ b/sdks/sandbox/csharp/tests/OpenSandbox.Tests/ModelsTests.cs@@ -21,6 +21,25 @@ namespace OpenSandbox.Tests;public class ModelsTests{+ [Theory]+ [InlineData("{\"type\":\"execution_complete\",\"exit_code\":0}", 0)]+ [InlineData("{\"type\":\"execution_complete\"}", null)]+ public void ServerStreamEvent_ShouldPreserveOptionalZeroExitCode(string json, int? expected)+ {+ var streamEvent = JsonSerializer.Deserialize<ServerStreamEvent>(json)!;+ streamEvent.ExitCode.Should().Be(expected);++ using var serialized = JsonDocument.Parse(JsonSerializer.Serialize(streamEvent));+ if (expected.HasValue)+ {+ serialized.RootElement.GetProperty("exit_code").GetInt32().Should().Be(0);+ }+ else+ {+ serialized.RootElement.TryGetProperty("exit_code", out _).Should().BeFalse();+ }+ }+[Fact]public void RenewalPolicy_ShouldAcceptBoundaries(){