Skip to content

Secure, Fast, and Extensible Sandbox runtime for AI agents.

fix(execd): reject allocation when upper usage scan fails

Qiu4a3b3bee59f9
diff --git a/components/execd/pkg/isolation/upper.go b/components/execd/pkg/isolation/upper.go
index 62244beaa..ffd6c854e 100644
--- a/components/execd/pkg/isolation/upper.go
+++ b/components/execd/pkg/isolation/upper.go
@@ -167,7 +167,10 @@ func (m *UpperManager) AllocateN(n int) (sessionID string, pairs []UpperDirPair,
if m.maxBytes > 0 {
usage, usageErr := m.usageLocked()
- if usageErr == nil && usage >= m.maxBytes {
+ if usageErr != nil {
+ return "", nil, fmt.Errorf("upper: measure usage before allocation: %w", usageErr)
+ }
+ if usage >= m.maxBytes {
return "", nil, fmt.Errorf("%w: %d >= %d bytes", ErrUpperLimitExceeded, usage, m.maxBytes)
}
}
diff --git a/components/execd/pkg/isolation/upper_test.go b/components/execd/pkg/isolation/upper_test.go
index 5a2bf3051..2dc1ceac6 100644
--- a/components/execd/pkg/isolation/upper_test.go
+++ b/components/execd/pkg/isolation/upper_test.go
@@ -261,6 +261,41 @@ func TestUpperManager_UsageRejectsMissingInUseUpper(t *testing.T) {
}
}
+func TestUpperManager_AllocateRejectsInvalidUsageWithLimit(t *testing.T) {
+ root := filepath.Join(t.TempDir(), "isolation")
+ mgr, err := NewUpperManager(root, 100)
+ if err != nil {
+ t.Fatal(err)
+ }
+
+ _, healthyUpper, _, err := mgr.Allocate()
+ if err != nil {
+ t.Fatal(err)
+ }
+ _, missingUpper, _, err := mgr.Allocate()
+ if err != nil {
+ t.Fatal(err)
+ }
+ if err := os.WriteFile(filepath.Join(healthyUpper, "full.bin"), make([]byte, 100), 0o600); err != nil {
+ t.Fatal(err)
+ }
+ if err := os.RemoveAll(missingUpper); err != nil {
+ t.Fatal(err)
+ }
+
+ // Unknown usage must not let new allocations bypass an exhausted quota.
+ if _, _, err := mgr.AllocateN(1); !errors.Is(err, os.ErrNotExist) {
+ t.Fatalf("AllocateN() error = %v, want missing upper directory error", err)
+ }
+ // Once measurement recovers, the intact upper still consumes the budget.
+ if err := os.MkdirAll(missingUpper, 0o755); err != nil {
+ t.Fatal(err)
+ }
+ if _, _, err := mgr.AllocateN(1); !errors.Is(err, ErrUpperLimitExceeded) {
+ t.Fatalf("AllocateN() error = %v, want ErrUpperLimitExceeded", err)
+ }
+}
+
func TestUpperManager_Allocate(t *testing.T) {
mgr := newTestUpperManager(t)